clank/clank-together
1
0
Fork 0
Code Issues Wiki Activity

Withdraw held functions the submission did not write, also when main has code for them

Browse source 
Verification compiles the unit a function lives in on main, so a held but
unwritten function was found compiled from main code and sent to peer
review as if submitted; reviewers shown the submitted files could not find
it (592 verdicts said so, 196 such functions were waiting).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
Saty 2026-10-20 03:55:05 +02:00
commit 347ce4ea24
1 changed files with 4 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

6
src/server/verify.js
View file

@ -410,8 +410,10 @@ export class Verifier {
for (const a of attempts) {
const ev = this.evaluate({ check, rec, targetId: a.symbol_id, files: merged.files, changedHeaders, outside });
// Held but not written: no annotation for it anywhere in the submission. Not a failure; it
// goes back to the author's claim.
if (!ev.feedback.target && !Object.values(submitted).some((text) => new RegExp(`//\\s*(FUNCTION|STUB)\\s*:\\s*${a.symbol_id}\\b`).test(String(text)))) {
// goes back to the author's claim. Also when main has code for it (verification compiles the
// unit a function lives in): that code is not this submission's, and reviewers shown the
// submitted files would not find it.
if (!Object.values(submitted).some((text) => new RegExp(`//\\s*(FUNCTION|STUB)\\s*:\\s*${a.symbol_id}\\b`).test(String(text)))) {
this.withdraw(a);
withdrawn++;
continue;