clank/clank-together
1
0
Fork 0
Code Issues Wiki Activity

Batches page: list every batch, including those sent back before review

Browse source 
GET /api/batches lists batches newest first with state, reason, notes and per-state function counts; filters by state and author, pages with before/limit. The batch detail adds notes, times and file paths. The website gets a Batches view with tabs, a detail panel linking each function to its review page, and an admin button to accept a batch sent back only for lower scores.
This commit is contained in:
ragnarok-clanker 2026-10-27 00:21:49 +01:00
commit 6472a15a17
4 changed files with 208 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

22
test/server.test.js
View file

@ -1885,3 +1885,25 @@ test('global rules reject undefined data in code and maintenance batches, includ
ctx.regions.release(ctx.accounts.byName('globalguard'), { kind: 'unit', key: unit });
}
});
test('the batch list shows every batch, also those sent back before review, filtered by state and author and paged', async () => {
const token = await activeUser('blister');
const lister = ctx.accounts.byName('blister');
const head = ctx.repo.head();
const task = ctx.store.get('SELECT id FROM tasks LIMIT 1').id;
const batch = (state, result) => Number(ctx.store.run(`INSERT INTO batches (user_id, base_commit, files_json, state, result_json, created_at) VALUES (?, ?, '{}', ?, ?, ?)`, lister.id, head, state, result ? JSON.stringify(result) : null, now()).lastInsertRowid);
const sentBack = batch('returned', { returned: '3 of 6 functions need work' });
ctx.store.run(`INSERT INTO attempts (task_id, user_id, base_commit, files_json, state, batch_id, created_at) VALUES (?, ?, ?, '{}', 'needs_cleanup', ?, ?)`, task, lister.id, head, sentBack, now());
const merged = batch('merged');
assert.equal((await call('GET', '/api/batches')).status, 401);
const mine = (await call('GET', '/api/batches?author=BLISTER', null, token)).body;
assert.deepEqual(mine.map((b) => b.id), [merged, sentBack], 'newest first, author matched without case');
const back = mine.find((b) => b.id === sentBack);
assert.equal(back.returned, '3 of 6 functions need work');
assert.deepEqual(back.functions, { needs_cleanup: 1 });
assert.deepEqual((await call('GET', '/api/batches?state=returned&author=blister', null, token)).body.map((b) => b.id), [sentBack]);
assert.deepEqual((await call('GET', `/api/batches?author=blister&before=${merged}`, null, token)).body.map((b) => b.id), [sentBack]);
assert.deepEqual((await call('GET', '/api/batches?author=blister&limit=1', null, token)).body.map((b) => b.id), [merged]);
ctx.store.run(`UPDATE attempts SET state = 'rejected' WHERE batch_id = ?`, sentBack);
});