clank/clank-together
1
0
Fork 0
Code Issues Wiki Activity

Peer reviews are handed out closest to a decision first

Browse source 
Functions waiting for their 4th and 5th confirmation never came up while
hundreds waited in peer review, so nothing was ever auto-accepted.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01RNwtXPYqFu3oKaaXwYwNWW
This commit is contained in:
Saty 2026-10-18 12:07:09 +02:00
commit ced71caa75
1 changed files with 6 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

8
src/server/peer.js
View file

@ -42,7 +42,11 @@ export class PeerReviews {
return (this.project.matchPolicy.peerLeaseMinutes ?? 60) * 60_000;
}
/** Attempts waiting for peer review that `user` may take. */
/**
* Attempts waiting for peer review that `user` may take, closest to a decision first: a function
* one verdict short of acceptance (or of going back) beats one nobody has looked at yet, so
* decisions get finished instead of verdicts spread thinly over the whole queue.
*/
available(user, limit = 20) {
return this.store.all(
`SELECT a.id AS attempt_id, a.batch_id, a.task_id, a.state, t.symbol_id, s.name, a.finished_at,
@ -53,7 +57,7 @@ export class PeerReviews {
WHERE a.state IN ('peer_review', 'in_review') AND a.user_id != ?
AND NOT EXISTS (SELECT 1 FROM users b WHERE b.id = ? AND b.peer_review_blocked = 1)
AND NOT EXISTS (SELECT 1 FROM peer_reviews p WHERE p.attempt_id = a.id AND p.reviewer_id = ?)
ORDER BY a.state = 'in_review', a.finished_at
ORDER BY MAX(confirmations, objections) DESC, a.finished_at
LIMIT ?`,
now(),
user.id,