From 00df083ed6d956d2b307ae4e69bb9de6d40c370e Mon Sep 17 00:00:00 2001
From: ragnarok-clanker <ragnarok-clanker>
Date: Wed, 11 Nov 2026 21:54:45 +0000
Subject: [PATCH] Decompile fn_05328 (CAchievementMgr::InsertAchieveUIType)

Batch #17335 by eAthena: 0 byte-identical, 1 confirmed by peer review.

- fn_05328 CAchievementMgr::InsertAchieveUIType: logic confirmed by peer review

Peer-reviewed-by: Yommy, cremane, bibinir
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
---
 Source/Contents/Achievement/AchievementMgr.cpp | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/Source/Contents/Achievement/AchievementMgr.cpp b/Source/Contents/Achievement/AchievementMgr.cpp
index 4ef06a04b..bccf6e598 100644
--- a/Source/Contents/Achievement/AchievementMgr.cpp
+++ b/Source/Contents/Achievement/AchievementMgr.cpp
@@ -322,14 +322,14 @@ std::pair<bool, std::string> CAchievementMgr::InsertAchieveRewardTitle(int id, i
 // FUNCTION: fn_05328
 std::pair<bool, std::string> CAchievementMgr::InsertAchieveUIType(int id, int type, std::string text) {
   const auto found = this->achievements.find(id);
-  if (found == this->achievements.end()) {
+  if (found != this->achievements.end()) {
+    found->second.progressMode = type;
+    found->second.iconName = text;
+    return std::make_pair(true, "good");
+  } else {
     const std::string message = FormatOwnedString("achievement info [%d] cannot be find", id);
     return std::make_pair(false, message);
   }
-
-  found->second.progressMode = type;
-  found->second.iconName = text;
-  return std::make_pair(true, "good");
 }
 
 // OFFSET: 0x0066F900