Confirm fn_19636 (CNavigationManager::RouteToSavedTarget)

Batch #17159 by eAthena: 0 byte-identical, 1 confirmed by peer review.

- fn_19636 CNavigationManager::RouteToSavedTarget: logic confirmed by peer review (already on main)

Peer-reviewed-by: ragnarok-clanker, Yommy, Toshiro
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
This commit is contained in:
ragnarok-clanker 2026-11-11 14:18:10 +00:00
commit 129edaa22f
15 changed files with 33 additions and 0 deletions

View file

@ -19,6 +19,8 @@ extern "C" {
#include <utility>
#include <windows.h>
extern template int std::_Traits_compare<std::char_traits<char>>(const char*, std::size_t, const char*, std::size_t) noexcept;
// GLOBAL: gl_24856
CAchievementMgr* g_achievementMgr;

View file

@ -2,6 +2,8 @@
#include <algorithm>
extern template bool std::_Traits_equal<std::char_traits<char>>(const char*, std::size_t, const char*, std::size_t) noexcept;
using ActorNameCardTree = std::_Tree<std::_Tmap_traits<
std::uint32_t, CActorNameCard, std::less<std::uint32_t>,
std::allocator<std::pair<const std::uint32_t, CActorNameCard>>, false>>;

View file

@ -33,6 +33,8 @@ extern "C" {
#include <windows.h>
#include <timeapi.h>
extern template bool std::_Traits_equal<std::char_traits<char>>(const char*, std::size_t, const char*, std::size_t) noexcept;
namespace {
struct SkillOwnerPacket {

View file

@ -49,6 +49,9 @@
#include <string>
#include <vector>
extern template std::string::basic_string(const std::string&);
extern template std::vector<unsigned char>::vector(std::size_t, const unsigned char&, const std::allocator<unsigned char>&);
namespace {
#pragma pack(push, 1)
struct MessengerRecordHeader {

View file

@ -2,6 +2,8 @@
#include <cstring>
extern template std::string::basic_string(const std::string&);
// OFFSET: 0x00B974D0
// FUNCTION: fn_19599
bool CNavigationManager::LoadStates(std::vector<char> packet) {

View file

@ -38,6 +38,9 @@
#include "Resource/MSGSTRINGID.h"
#include "Network/Packets/PacketId.h"
extern template std::string& std::string::operator=(std::string&&) noexcept;
namespace {
// GLOBAL: gl_25136
int g_locationFrame = 1;

View file

@ -12,6 +12,8 @@
#include <windows.h>
#include <timeapi.h>
extern template std::string& std::string::operator=(std::string&&) noexcept;
namespace {
constexpr char sourceFile[] = "C:\\repositories\\RagnarokClient\\RagnarokClient\\Contents\\AdventurerAgency\\CRegisterPartyAsyncWork.cpp";

View file

@ -15,6 +15,9 @@
#include <cstring>
#include <utility>
extern template std::vector<int>::vector(const std::vector<int>&);
extern template std::vector<int>::~vector();
extern "C" void JsonDestroy();
struct JsonValueCopy {

View file

@ -13,6 +13,8 @@
#include <json/value.h>
#include <json/writer.h>
extern template std::vector<std::string>::~vector();
// OFFSET: 0x00605BF0
// FUNCTION: fn_04226
CMCStoreInfoBackup::CMCStoreInfoBackup() : loaded(false), pendingSaves(0), saveUrl(""), loadUrl(""), title(""), type(0) {

View file

@ -9,6 +9,9 @@
#include <json/value.h>
#include <json/writer.h>
extern template std::string& std::string::assign(const char*, std::string::size_type);
extern template std::vector<std::string>::~vector();
// OFFSET: 0x00DE0E40
// FUNCTION: fn_23474
int CSession::UseLevel(int id) const {

View file

@ -9,6 +9,8 @@
#include <t2embapi.h>
#include <vector>
extern template std::string::basic_string(const std::string&);
// GLOBAL: gl_24812
CEmbedFont* g_embedFont;

View file

@ -38,6 +38,8 @@
#include <string>
#include <vector>
extern template std::vector<int>::~vector();
#pragma pack(push, 1)
struct PACKET_CZ_ITEM_REFORM {
/* 0000 */ std::int16_t packetType;

View file

@ -29,6 +29,7 @@
#include <windows.h>
#include <timeapi.h>
extern template std::vector<int>::~vector();
namespace {
struct RandomCombineItemPacket {

View file

@ -6,6 +6,8 @@
#include <windows.h>
#include <utility>
extern template std::string::basic_string(std::_String_constructor_concat_tag, const std::string&, const char*, std::size_t, const char*, std::size_t);
namespace {
// INLINED
bool Hex(unsigned char value) {

View file

@ -8,6 +8,8 @@
#include "UI/Lists/UIScrollBar.h"
#include "UI/Text/CreateLineInfo.h"
extern template std::string::basic_string(const char*);
// OFFSET: 0x0083E1B0
// FUNCTION: fn_10515
UITagTextViewer::UITagTextViewer()