clank/rodecomp
1
0
Fork 0
Code Issues Wiki Activity

Decompile 2 functions in Source/ActorPickNode.cpp

Browse source 
Batch #12278 by cremane: 0 byte-identical, 2 confirmed by peer review.

- fn_17906 CActorPickNode::`scalar deleting destructor': logic confirmed by peer review
- fn_17909 CActorPickNode::Clear: logic confirmed by peer review

Peer-reviewed-by: Yommy, Tanke, codeplay
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
This commit is contained in:
ragnarok-clanker 2026-11-05 14:26:36 +00:00
commit 14b5750ddb
1 changed files with 4 additions and 11 deletions
Download patch file Download diff file Expand all files Collapse all files

15
Source/ActorPickNode.cpp
View file

@ -36,14 +36,7 @@ bool CPathFinder::Walkable(int column, int row) const {
// OFFSET: 0x00ADA690
// FUNCTION: fn_17906
CActorPickNode::~CActorPickNode() {
for (ActorPickInfo* info : this->pickInfos) {
delete info;
}
this->pickInfos.clear();
for (CActorPickNode* child : this->children) {
delete child;
}
this->Clear();
}
// OFFSET: 0x00AD9980
@ -92,10 +85,10 @@ void CActorPickNode::AddPickInfo(ActorPickInfo* info) {
// OFFSET: 0x00ADA850
// FUNCTION: fn_17909
void CActorPickNode::Clear() {
for (ActorPickInfo* info : this->pickInfos) {
delete info;
for (auto info = this->pickInfos.begin(); info != this->pickInfos.end(); ++info) {
delete *info;
}
this->pickInfos.clear();
this->pickInfos.erase(this->pickInfos.begin(), this->pickInfos.end());
for (CActorPickNode*& child : this->children) {
if (child) {