clank/rodecomp
1
0
Fork 0
Code Issues Wiki Activity

Decompile 2 functions in Source/Contents/Skills/ClientSkills.cpp, Source/Contents/Skills/ClientSkills.h, ...

Browse source 
Batch #1471 by ragnarok-clanker: 0 byte-identical, 2 confirmed by peer review.

- fn_23753 CSession::ResetItems2B50: logic confirmed by peer review
- fn_23770 GetSkillFactor: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
This commit is contained in:
ragnarok-clanker 2026-10-28 15:32:17 +00:00
commit 16b72c624f
3 changed files with 37 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

1
Source/Client/Session.h
View file

@ -134,6 +134,7 @@ public:
NormalItemSlot& SkillHotkey(int index) {
return reinterpret_cast<NormalItemSlot*>(reinterpret_cast<unsigned char*>(this) + offsetof(CSession, unknown_06EB))[index];
}
void ResetItems2B50();
int GetPetFood(int job);
void GetPetIllustName(int job, int, char* buffer);
int GetPetJobByEggItem(int eggItemId);

32
Source/Contents/Skills/ClientSkills.cpp
View file

@ -1,5 +1,6 @@
#include "Contents/Skills/ClientSkills.h"
#include "Client/Session.h"
#include "Contents/ClientState.h"
#include "Script/LuaScript.h"
#include "UI/Window/UIWindow.h"
#include "UI/Window/UIWindowMgr.h"
@ -593,3 +594,34 @@ void CSession::NotifyMercSkillWindows() {
g_windowMgr.window_01E8->SendMsg(nullptr, 23, 0, 0, 0, 0);
}
}
// OFFSET: 0x00E08260
// FUNCTION: fn_23753
void CSession::ResetItems2B50() {
for (int index = 0; index < 10; ++index) {
this->unknown_2B50[index].Reset();
}
RequestBasicInfoRefresh();
}
// OFFSET: 0x00E08B40
// FUNCTION: fn_23770
float GetSkillFactor(int skillId) {
if ((skillId < 4023 || skillId > 4029) && skillId != 4045 && skillId != 4191 && static_cast<unsigned>(skillId - 4030) > 0xE &&
static_cast<unsigned>(skillId - 4096) > 0x10 && static_cast<unsigned>(skillId - 4158) > 0x18 && (skillId < 4194 || skillId > 4196) &&
skillId != 4193 && static_cast<unsigned>(skillId - 4205) > 5 && skillId != 4220 && static_cast<unsigned>(skillId - 4222) > 0x10 &&
skillId != 4241 && skillId != 4242 && skillId != 4244 && skillId != 4247 && skillId != 4248 && skillId != 4352 && skillId != 4354) {
return 1.0f;
}
if (g_session.IsReducedSkill(skillId)) {
return 0.8f;
}
if ((skillId >= 4023 && skillId <= 4029) || skillId == 4045 || skillId == 4191) {
return 0.75f;
}
return 0.82f;
}

6
Source/Contents/Skills/ClientSkills.h
View file

@ -66,6 +66,10 @@ struct ClientSkills {
static_assert(sizeof(ActiveSkillEffect) == 28);
#if defined(_WIN32) && !defined(_WIN64)
static_assert(offsetof(ActiveSkillEffect, unknown_0018) == 0x18);
#endif
float GetSkillFactor(int skillId);
#endif
float GetSkillFactor(int skillId);
#endif