From 1864c8de09455e2773d236937e66d254ddcdde9c Mon Sep 17 00:00:00 2001 From: ragnarok-clanker Date: Wed, 11 Nov 2026 11:06:23 +0000 Subject: [PATCH] Decompile 3 functions in Source/Contents/Skills/SkillInfo.cpp Batch #16904 by eAthena: 1 byte-identical, 2 confirmed by peer review. - fn_08447 CSkillAction_BO_DUST_EXPLOSION::OnSkillEffect: byte-identical - fn_08315 CSkillInfo::DisplayName: logic confirmed by peer review (already on main) - fn_08318 CSkillInfo::DisplayName: logic confirmed by peer review Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes). --- Source/Contents/Skills/SkillInfo.cpp | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/Source/Contents/Skills/SkillInfo.cpp b/Source/Contents/Skills/SkillInfo.cpp index 662997552..14a2ec5e8 100644 --- a/Source/Contents/Skills/SkillInfo.cpp +++ b/Source/Contents/Skills/SkillInfo.cpp @@ -442,7 +442,7 @@ const char* CSkillInfo::DisplayName(LuaScript&, int skillId) { } const char* result = nullptr; - return g_session.m_hotkeyScript->Call("GetSkillName", "d>s", skillId, &result) ? result : "Unknown-Skill"; + return g_session.m_hotkeyScript->Call("GetSkillName", "d>s", skillId, &result) == true ? result : "Unknown-Skill"; } // OFFSET: 0x007739F0 @@ -1813,12 +1813,13 @@ void CSkillAction_BO_DUST_EXPLOSION::OnSkillEffect(int level, CGameActor* source } const DustExplosionSpawner spawnDustExplosion{}; + const vector3d& position = target->render.position; for (int delay = 0; delay < 600; delay += 200) { const int quadrant = std::ranges::max(std::rand() % 4, 0); - if (CEffect* effect = spawnDustExplosion(quadrant, target->render.position)) { + if (CEffect* effect = spawnDustExplosion(quadrant, position)) { effect->SetDelay(delay); } - if (CEffect* effect = spawnDustExplosion((quadrant + 2) % 4, target->render.position)) { + if (CEffect* effect = spawnDustExplosion((quadrant + 2) % 4, position)) { effect->SetDelay(delay); } }