clank/rodecomp
1
0
Fork 0
Code Issues Wiki Activity

Maintenance: Replace raw address calls in UIAdventureGuide.cpp: 0x009E0350 CUIQuestInfo::SetTitle, 0x009DE7D0 SetTip, 0x009DE560 CUIL

Browse source 
Batch #8890 by ragnarok-clanker: forced by an admin (1 lower score(s), 2 changed function(s)); checked with 19 compiled unit(s), including every includer of Source/UI/Lists/UIListBoxTemplate.h.
This commit is contained in:
ragnarok-clanker 2026-10-31 22:28:38 +00:00
commit 1a001292b1
2 changed files with 7 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

14
Source/UI/AdventureGuide/UIAdventureGuide.cpp
View file

@ -517,7 +517,7 @@ void CUIItem::BindItem(CUIItemInfo* item, const CItemData& data) {
void __stdcall BindQuestInfo(CUIQuestInfo* owner, const CQuestInfo& data) {
switch (data.type) {
case 1:
reinterpret_cast<void(__thiscall*)(CUIQuestInfo*, int)>(0x009E0350)(owner, data.id);
owner->SetTitle(data.id);
owner->SetViewerLines(data.rewards);
owner->unknown_00F8 = data.title;
reinterpret_cast<CUITextViewer*>(owner->unknown_00F4)->Clear();
@ -526,7 +526,7 @@ void __stdcall BindQuestInfo(CUIQuestInfo* owner, const CQuestInfo& data) {
owner->unknown_00E8->Show(g_renewQuestMgr->IsNewQuest(data.questId));
break;
case 3:
reinterpret_cast<void(__thiscall*)(CUIQuestInfo*, int)>(0x009E0350)(owner, data.id);
owner->SetTitle(data.id);
owner->SetViewerLines(data.rewards);
owner->unknown_00F8 = data.title;
reinterpret_cast<CUITextViewer*>(owner->unknown_00F4)->Clear();
@ -534,7 +534,7 @@ void __stdcall BindQuestInfo(CUIQuestInfo* owner, const CQuestInfo& data) {
owner->unknown_00E8->Show(0);
return;
case 4:
reinterpret_cast<void(__thiscall*)(CUIQuestInfo*, int)>(0x009DE7D0)(owner, data.id);
owner->SetTip(data.id);
owner->SetViewerLines(data.rewards);
owner->unknown_00F8 = data.title;
reinterpret_cast<CUITextViewer*>(owner->unknown_00F4)->Clear();
@ -924,8 +924,7 @@ void CUIAdventureGuide::Slot16() {
};
for (const auto& [type, intro] : g_adventureGuideMgr->m_intros) {
AdventureGuide::CUITab* tab =
reinterpret_cast<AdventureGuide::CUITab*(__thiscall*)(CUIListBox<AdventureGuide::CUITab>*)>(0x009DB4B0)(this->tabs);
AdventureGuide::CUITab* tab = this->tabs->CreateItem();
tab->type = type;
tab->unknown_00E8->SetText(intro.text.c_str(), intro.text.size());
tab->unknown_00F0 = intro.title;
@ -947,8 +946,7 @@ void CUIAdventureGuide::Slot16() {
CUIListBox<AdventureGuide::CUISubTab>* subTabs = tab->CreateSubTabList();
subTabs->Resize(subTabs->geometry.width, subTabs->rowHeight * static_cast<int>(details.size()));
for (const auto& [id, detail] : details) {
AdventureGuide::CUISubTab* subTab =
reinterpret_cast<AdventureGuide::CUISubTab*(__thiscall*)(CUIListBox<AdventureGuide::CUISubTab>*)>(0x009DB280)(subTabs);
AdventureGuide::CUISubTab* subTab = subTabs->CreateItem();
subTab->unknown_00E8->SetText(detail.text.c_str(), detail.text.size());
subTab->id = id;
subTab->unknown_00F4 = detail.unknown_0008;
@ -968,7 +966,7 @@ void CUIAdventureGuide::Slot16() {
if (!this->tabs->items.empty()) {
AdventureGuide::CUITab* first = this->tabs->items.front();
if (first) {
reinterpret_cast<void(__thiscall*)(CUIListBox<AdventureGuide::CUITab>*, CUIListItem*)>(0x009DE560)(this->tabs, first);
this->tabs->SelectItem(first);
}
}
g_renewQuestMgr->SendQuestStatusRequest();

1
Source/UI/Lists/UIListBoxTemplate.h
View file

@ -246,6 +246,7 @@ public:
}
void SelectItem(CUIListItem* item);
T* CreateItem();
// INLINED
void SetOnSelect(std::function<void(T*)> handler) {