clank/rodecomp
1
0
Fork 0
Code Issues Wiki Activity

Maintenance: Fold alias global gl_25097 g_saleOpenWindow (0x1457854) into its evidenced owner member g_windowMgr.unknown_01D4. 0x1457

Browse source 
Batch #10396 by ragnarok-clanker: no function's compiled code changes; checked with 190 compiled unit(s), including every includer of Source/Client/Mode/CGameMode.h.
This commit is contained in:
ragnarok-clanker 2026-11-03 21:50:07 +00:00
commit 1a162f0f4b
3 changed files with 4 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

1
Source/Client/Mode/CGameMode.h
View file

@ -1025,7 +1025,6 @@ static_assert(sizeof(CGameMode) == 0x670);
extern char g_pendingWhisperCount;
extern int g_whisperRecord;
extern int g_timeAttackStart;
extern UIWindow* g_saleOpenWindow;
void sub_CCFF10();
extern int g_localMapMove;
extern unsigned char g_gameModePacketBuffer[0x10000];

7
Source/Client/Mode/GameModePackets.cpp
View file

@ -137,9 +137,6 @@ char g_pendingWhisperCount;
// GLOBAL: gl_25102
int g_whisperRecord;
// GLOBAL: gl_25097
UIWindow* g_saleOpenWindow;
// GLOBAL: gl_25098
UIWindow* g_saleResultWindow;
@ -1897,8 +1894,8 @@ void __declspec(noinline) __stdcall sub_D08670(int field14, int itemId, int quan
UIWindow* window = g_windowMgr.EnsureWindow(0x102);
window->SendMsg(nullptr, 0x17, reinterpret_cast<std::intptr_t>(&item), field10, field14, 0);
g_session.RemoveItem1758ByItemId(item);
if (g_saleOpenWindow != nullptr) {
g_saleOpenWindow->SendMsg(nullptr, 0x17, 0, 0, 0, 0);
if (g_windowMgr.unknown_01D4 != nullptr) {
g_windowMgr.unknown_01D4->SendMsg(nullptr, 0x17, 0, 0, 0, 0);
}
if (g_saleResultWindow != nullptr) {
g_saleResultWindow->SendMsg(nullptr, 0x77, fieldC, 0, 0, 0);

4
Source/Contents/Configuration/ServiceOptions.cpp
View file

@ -948,8 +948,8 @@ void ApplyServiceOptionItemWnd(int id, unsigned char value, bool notify, int ena
}
}
if (g_saleOpenWindow != nullptr) {
static_cast<UIItemWnd*>(g_saleOpenWindow)->RefreshOptionBox();
if (g_windowMgr.unknown_01D4 != nullptr) {
static_cast<UIItemWnd*>(g_windowMgr.unknown_01D4)->RefreshOptionBox();
}
}