From 1f7809ae403242d7cdcd84d1a79a52d8c41d04e3 Mon Sep 17 00:00:00 2001 From: ragnarok-clanker Date: Sat, 7 Nov 2026 07:09:52 +0000 Subject: [PATCH] Decompile fn_03439 (AsyncDiagnostic::MoveFrom) Batch #14098 by Yommy: 0 byte-identical, 1 confirmed by peer review. - fn_03439 AsyncDiagnostic::MoveFrom: logic confirmed by peer review Peer-reviewed-by: secret, KWDev, codeplay Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes). --- Source/Utility/Async/AsyncDiagnostic.cpp | 11 +++-------- Source/Utility/Async/AsyncDiagnostic.h | 2 +- 2 files changed, 4 insertions(+), 9 deletions(-) diff --git a/Source/Utility/Async/AsyncDiagnostic.cpp b/Source/Utility/Async/AsyncDiagnostic.cpp index e6cec1ab6..55278d8c1 100644 --- a/Source/Utility/Async/AsyncDiagnostic.cpp +++ b/Source/Utility/Async/AsyncDiagnostic.cpp @@ -10,15 +10,10 @@ AsyncDiagnostic::AsyncDiagnostic(const bool* success, std::string* message, cons // OFFSET: 0x005B9D90 // FUNCTION: fn_03439 -AsyncDiagnostic& AsyncDiagnostic::MoveFrom(AsyncDiagnostic& other) { +AsyncDiagnostic& AsyncDiagnostic::MoveFrom(AsyncDiagnostic& other) noexcept { this->success = other.success; - if (&this->message != &other.message) { - this->message = std::move(other.message); - } - - if (&this->file != &other.file) { - this->file = std::move(other.file); - } + this->message = std::move(other.message); + this->file = std::move(other.file); this->line = other.line; return *this; diff --git a/Source/Utility/Async/AsyncDiagnostic.h b/Source/Utility/Async/AsyncDiagnostic.h index 21826a8e1..1b00ff9d7 100644 --- a/Source/Utility/Async/AsyncDiagnostic.h +++ b/Source/Utility/Async/AsyncDiagnostic.h @@ -12,7 +12,7 @@ struct AsyncDiagnostic { : AsyncDiagnostic(&success, &message, file, &line) { } ~AsyncDiagnostic(); - AsyncDiagnostic& MoveFrom(AsyncDiagnostic& other); + AsyncDiagnostic& MoveFrom(AsyncDiagnostic& other) noexcept; /* 0000 */ std::uint32_t line; /* 0004 */ std::string file;