From 204c70e5fef62255e347e770746d9d2593ca419d Mon Sep 17 00:00:00 2001 From: ragnarok-clanker Date: Fri, 6 Nov 2026 16:00:44 +0000 Subject: [PATCH] Confirm 15 functions in Source/Utility/Async/NAsyncWork.h, Source/Utility/Async/NRecycleObject.h, ... Batch #12608 by Yommy: 0 byte-identical, 15 confirmed by peer review. - fn_03963 CEmblemDataDownloadAsyncWork::CEmblemDataDownloadAsyncWork: logic confirmed by peer review (already on main) - fn_03978 CEmblemDataUploadAsyncWork::CEmblemDataUploadAsyncWork: logic confirmed by peer review (already on main) - fn_03657 CAdventurerAgencyMgr::RequestChangeMaster: logic confirmed by peer review (already on main) - fn_03677 CChangePartyMasterAsyncWork::CChangePartyMasterAsyncWork: logic confirmed by peer review (already on main) - fn_03685 CLoadMyPartyAsyncWork::CLoadMyPartyAsyncWork: logic confirmed by peer review (already on main) - fn_03692 CLoadPartyInfoAsyncWork::CLoadPartyInfoAsyncWork: logic confirmed by peer review (already on main) - fn_03698 CLoadPartyListAsyncWork::CLoadPartyListAsyncWork: logic confirmed by peer review (already on main) - fn_03704 CRegisterPartyAsyncWork::CRegisterPartyAsyncWork: logic confirmed by peer review (already on main) - fn_03711 CStopRecruitingAsyncWork::CStopRecruitingAsyncWork: logic confirmed by peer review (already on main) - fn_04241 CMCStoreInfoBackupLoadAsyncWork::CMCStoreInfoBackupLoadAsyncWork: logic confirmed by peer review (already on main) - fn_04247 CMCStoreInfoBackupSaveAsyncWork::CMCStoreInfoBackupSaveAsyncWork: logic confirmed by peer review (already on main) - fn_03440 CAccountLinkedUserDataLoadAsyncWork::CAccountLinkedUserDataLoadAsyncWork: logic confirmed by peer review (already on main) - fn_03478 CAccountLinkedUserDataSaveAsyncWork::CAccountLinkedUserDataSaveAsyncWork: logic confirmed by peer review (already on main) - fn_03916 CCharacterLinkedUserDataLoadAsyncWork::CCharacterLinkedUserDataLoadAsyncWork: logic confirmed by peer review (already on main) - fn_03944 CCharacterLinkedUserDataSaveAsyncWork::CCharacterLinkedUserDataSaveAsyncWork: logic confirmed by peer review (already on main) Peer-reviewed-by: gordaoprogramas, Tanke, Toshiro, cremane, codeplay, aDw Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes). --- Source/Utility/Async/NAsyncWork.cpp | 8 -------- Source/Utility/Async/NAsyncWork.h | 5 ++++- Source/Utility/Async/NRecycleObject.h | 5 ++++- 3 files changed, 8 insertions(+), 10 deletions(-) diff --git a/Source/Utility/Async/NAsyncWork.cpp b/Source/Utility/Async/NAsyncWork.cpp index 9468fff2..fc88b0d8 100644 --- a/Source/Utility/Async/NAsyncWork.cpp +++ b/Source/Utility/Async/NAsyncWork.cpp @@ -2,17 +2,9 @@ #include -// INLINED -inline NRecycleObject::NRecycleObject(std::string poolName) : m_poolName(std::move(poolName)) { -} - // INLINED inline NRecycleObject::~NRecycleObject() = default; -// INLINED -NAsyncWork::NAsyncWork(std::string poolName) : NRecycleObject(std::move(poolName)), m_group(0), m_key(0) { -} - // INLINED NAsyncWork::~NAsyncWork() = default; diff --git a/Source/Utility/Async/NAsyncWork.h b/Source/Utility/Async/NAsyncWork.h index 6710dce8..eea42750 100644 --- a/Source/Utility/Async/NAsyncWork.h +++ b/Source/Utility/Async/NAsyncWork.h @@ -5,7 +5,10 @@ class NAsyncWork : public NRecycleObject { public: - explicit NAsyncWork(std::string poolName); + // INLINED + __forceinline explicit NAsyncWork(std::string poolName) : NRecycleObject(poolName), m_group(0), m_key(0) { + } + ~NAsyncWork() override; virtual bool Execute(); virtual void Complete(); diff --git a/Source/Utility/Async/NRecycleObject.h b/Source/Utility/Async/NRecycleObject.h index f3151482..9c078b88 100644 --- a/Source/Utility/Async/NRecycleObject.h +++ b/Source/Utility/Async/NRecycleObject.h @@ -14,7 +14,10 @@ class NRecycleObject { public: - explicit NRecycleObject(std::string poolName); + // INLINED + explicit NRecycleObject(std::string poolName) : m_poolName(poolName) { + } + virtual void Reset() = 0; virtual ~NRecycleObject();