From 2347ee10eff47558477ff0fc1f1ddfb5d54a0484 Mon Sep 17 00:00:00 2001
From: ragnarok-clanker <ragnarok-clanker>
Date: Wed, 11 Nov 2026 11:44:20 +0000
Subject: [PATCH] Decompile 14 functions in
 Source/Client/Mode/GameModeNotices.cpp

Batch #16951 by eAthena: 0 byte-identical, 14 confirmed by peer review.

- fn_22138 CGameMode::ReceiveActorEffect228: logic confirmed by peer review
- fn_22078 CGameMode::ReceiveItemSlotAddOptions: logic confirmed by peer review (already on main)
- fn_22079 CGameMode::ReceiveItemSlotAddGrade: logic confirmed by peer review (already on main)
- fn_22093 CGameMode::ReceiveItemOptionsRefresh: logic confirmed by peer review (already on main)
- fn_21627 CGameMode::ReceiveGuildStorageLog: logic confirmed by peer review
- fn_21846 CGameMode::ReceiveStorageEquipList4: logic confirmed by peer review (already on main)
- fn_21847 CGameMode::ReceiveStorageEquipList5: logic confirmed by peer review (already on main)
- fn_22094 CGameMode::ReceiveItemUpgrade: logic confirmed by peer review (already on main)
- fn_22131 CGameMode::ReceiveVendingItemList2: logic confirmed by peer review (already on main)
- fn_22130 CGameMode::ReceiveShopItemListPacket: logic confirmed by peer review (already on main)
- fn_22068 CGameMode::ReceiveRodexReadMail: logic confirmed by peer review (already on main)
- fn_22091 CGameMode::RefreshInventoryOrEquipItem: logic confirmed by peer review (already on main)
- fn_22092 CGameMode::RefreshInventoryOrEquipItem2: logic confirmed by peer review (already on main)
- fn_22055 CGameMode::ReceiveGuildStorageLogItems: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker, Yommy, br4yan
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
---
 Source/Client/Mode/GameModeNotices.cpp | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/Source/Client/Mode/GameModeNotices.cpp b/Source/Client/Mode/GameModeNotices.cpp
index 645e34f79..15bc5626d 100644
--- a/Source/Client/Mode/GameModeNotices.cpp
+++ b/Source/Client/Mode/GameModeNotices.cpp
@@ -1225,9 +1225,9 @@ void CGameMode::ReceiveActorEffect228(const unsigned char* data) {
     actor->SendMsg(nullptr, AM_DELETE_EFFECT, 0, 228, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0);
   }
 
-  if (packet->state == 0) {
+  if (0 == packet->state) {
     actor->SendMsg(nullptr, AM_DELETE_EFFECT, 0, 228, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0);
-  } else if (packet->state != 1 || static_cast<EffectActor*>(actor)->HasId(228)) {
+  } else if (1 != packet->state || static_cast<EffectActor*>(actor)->HasId(228)) {
     return;
   }
 
@@ -3217,7 +3217,7 @@ struct GuildStorageLogPacket {
 // FUNCTION: fn_21627
 void CGameMode::ReceiveGuildStorageLog(const unsigned char* data) {
   const auto* packet = reinterpret_cast<const GuildStorageLogPacket*>(data);
-  if (packet->result == 0) {
+  if (0 == packet->result) {
     for (int i = 0; i < packet->count; ++i) {
       const GuildStorageLogPacketEntry& source = packet->entries[i];
       ITEM_INFO item;
@@ -3246,7 +3246,7 @@ void CGameMode::ReceiveGuildStorageLog(const unsigned char* data) {
       entry.category = source.highlighted;
       g_guildStorageLogs[0].push_back(entry);
     }
-  } else if (packet->result == 1) {
+  } else if (1 == packet->result) {
     for (int i = 0; i < packet->count; ++i) {
       const GuildStorageLogPacketEntry& source = packet->entries[i];
       ITEM_INFO item;
@@ -3289,7 +3289,7 @@ void CGameMode::ReceiveGuildStorageLog(const unsigned char* data) {
     g_windowMgr.EnsureWindow(WID_GUILD_STORAGE_LOG);
   } else {
     char text[252];
-    if (packet->result == 2) {
+    if (2 == packet->result) {
       std::memset(text, 0, 250);
       std::sprintf(text, LookupMessage(MSI_GUILD_STORAGE_LOG_OUT));
     } else {
@@ -7582,7 +7582,7 @@ void CGameMode::ReceiveGuildStorageLogItems(const unsigned char* data) {
   const auto* packet = reinterpret_cast<const GuildStorageLogItemsPacket*>(data);
   std::vector<GuildStorageLogItem> items;
   items.reserve(packet->count);
-  if (packet->result == 0 || packet->result == 1) {
+  if (0 == packet->result || 1 == packet->result) {
     for (long long index = 0; index < packet->count; ++index) {
       const GuildStorageLogItemRecord& record = packet->records[index];
       ITEM_INFO item;