clank/rodecomp
1
0
Fork 0
Code Issues Wiki Activity

Maintenance: [forced, user-approved] Family W3: remove invented ModelLightingContext and WorldModelLoading. Evidence: C3dActor::Prepa

Browse source 
Batch #10256 by ragnarok-clanker: forced by an admin (0 lower score(s), 8 changed function(s)); checked with 113 compiled unit(s), including every includer of Source/Contents/Models/ModelActor.h, Source/Contents/Models/ModelNode.h, Source/Contents/Models/ModelRendering.h, Source/Contents/World/World.h, Source/Contents/World/WorldModelLoading.h.
This commit is contained in:
ragnarok-clanker 2026-11-03 12:59:38 +00:00
commit 26277f915c
8 changed files with 60 additions and 186 deletions
Download patch file Download diff file Expand all files Collapse all files

32
Source/Contents/Models/ModelActor.cpp
View file

@ -128,51 +128,29 @@ void C3dActor::UpdateBounds() {
// OFFSET: 0x00ABBA50
// FUNCTION: fn_17518
void C3dActor::Prepare(ModelLightingContext&) {
void C3dActor::Prepare(const float*, const float*, const float*) {
}
// OFFSET: 0x00ABBA60
// FUNCTION: fn_17519
void C3dActorV1::Prepare(ModelLightingContext& context) {
void C3dActorV1::Prepare(const float* direction, const float* diffuse, const float* ambient) {
if (this->dirty == 1) {
this->UpdateMatrix();
}
const float* previousPosition = context.position;
const std::uint32_t* previousColor = context.color;
const int* previousShade = context.shade;
context.position = this->position;
context.color = &this->color;
context.shade = &this->shade;
this->root->Prepare(this->transform.values, context);
context.position = previousPosition;
context.color = previousColor;
context.shade = previousShade;
this->root->Prepare(this->transform.values, direction, diffuse, ambient, this->shade);
}
// OFFSET: 0x00ABBAA0
// FUNCTION: fn_17520
void C3dActorV2::Prepare(ModelLightingContext& context) {
void C3dActorV2::Prepare(const float* direction, const float* diffuse, const float* ambient) {
if (this->dirty == 1) {
this->UpdateMatrix();
}
const float* previousPosition = context.position;
const std::uint32_t* previousColor = context.color;
const int* previousShade = context.shade;
context.position = this->position;
context.color = &this->color;
context.shade = &this->shade;
for (C3dNodeV2* root : this->roots) {
root->Prepare(this->transform.values, context);
root->Prepare(this->transform.values, direction, diffuse, ambient, this->shade);
}
context.position = previousPosition;
context.color = previousColor;
context.shade = previousShade;
}
// OFFSET: 0x00AB9060