From 293db20ff9362f708ace313febcae94520f383e7 Mon Sep 17 00:00:00 2001 From: ragnarok-clanker Date: Fri, 6 Nov 2026 19:56:51 +0000 Subject: [PATCH] Decompile 2 functions in Source/Contents/Skills/PlayerSkillBundle.cpp, Source/Contents/Skills/PlayerSkillBundle.h, ... Batch #13464 by SapitoSucio: 0 byte-identical, 2 confirmed by peer review. - fn_08274 CPlayerSkillBundle::AddExtra: logic confirmed by peer review - fn_23746 CSession::UpdateSkill: logic confirmed by peer review Peer-reviewed-by: eAthena, StrawberrysherbetIX Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes). --- Source/Contents/Skills/ClientSkills.cpp | 2 +- Source/Contents/Skills/PlayerSkillBundle.cpp | 4 ++-- Source/Contents/Skills/PlayerSkillBundle.h | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/Source/Contents/Skills/ClientSkills.cpp b/Source/Contents/Skills/ClientSkills.cpp index be9f4bbeb..07fb2da51 100644 --- a/Source/Contents/Skills/ClientSkills.cpp +++ b/Source/Contents/Skills/ClientSkills.cpp @@ -240,7 +240,7 @@ bool CSession::UpdateSkill(const CSkillInfo& value, unsigned char notify, unsign } else { snapshot.unknown_0024 = UINT32_MAX; snapshot.unknown_002C = 0; - this->m_skillBundle.AddExtra(snapshot, g_windowMgr); + this->m_skillBundle.AddExtra(snapshot); } } diff --git a/Source/Contents/Skills/PlayerSkillBundle.cpp b/Source/Contents/Skills/PlayerSkillBundle.cpp index b3c285c18..4ebcc6166 100644 --- a/Source/Contents/Skills/PlayerSkillBundle.cpp +++ b/Source/Contents/Skills/PlayerSkillBundle.cpp @@ -168,9 +168,9 @@ void CPlayerSkillBundle::ClearExtra() { // OFFSET: 0x007713E0 // FUNCTION: fn_08274 -void CPlayerSkillBundle::AddExtra(const CSkillInfo& value, WindowManagerWindows& windows) { +void CPlayerSkillBundle::AddExtra(const CSkillInfo& value) { this->extraIds.push_back(value.id); - if (UIWindow* window = windows.LookupWindow(37)) { + if (UIWindow* window = g_windowMgr.LookupWindow(37)) { window->SendMsg(nullptr, 161, 0, 0, 0, 0); } diff --git a/Source/Contents/Skills/PlayerSkillBundle.h b/Source/Contents/Skills/PlayerSkillBundle.h index 217c70899..ef2a2abc3 100644 --- a/Source/Contents/Skills/PlayerSkillBundle.h +++ b/Source/Contents/Skills/PlayerSkillBundle.h @@ -36,7 +36,7 @@ public: CSkillInfo* FindExtra(std::uint32_t id); void ClearExtra(); bool RemoveExtra(std::uint32_t id); - void AddExtra(const CSkillInfo& value, WindowManagerWindows& windows); + void AddExtra(const CSkillInfo& value); void NumberExtra(); void AddGrouped(int group, const CSkillInfo& value); void ClearGroups();