Maintenance: Move the extern template declaration of std::_Traits_compare<char_traits<char>> from 18 units into Source/Utility/StdStr

Batch #15807 by ragnarok-clanker: no function's compiled code changes; checked with 18 compiled unit(s), including every includer of Source/Utility/StdStringCompare.h.

Source/ActorPickNode.cpp

@@ -14,8 +14,7 @@
 
 #include <map>
 #include <string>
-
-extern template int std::_Traits_compare<std::char_traits<char>>(const char*, std::size_t, const char*, std::size_t) noexcept;
+#include "Utility/StdStringCompare.h"
 
 // OFFSET: 0x00AD9530
 // FUNCTION: fn_17878

Source/Client/Mode/GameMode.cpp

@@ -9128,8 +9128,7 @@ void CGameMode::UpdateHoverNameBalloon() {
 #include <direct.h>
 #include <format>
 #include <io.h>
-
-extern template int std::_Traits_compare<std::char_traits<char>>(const char*, std::size_t, const char*, std::size_t) noexcept;
+#include "Utility/StdStringCompare.h"
 
 #pragma pack(push, 1)
 struct TalkWhisperSettingPacket {

Source/Client/Session.cpp

@@ -74,8 +74,7 @@
 #include <vector>
 #include <windows.h>
 #include <timeapi.h>
-
-extern template int std::_Traits_compare<std::char_traits<char>>(const char*, std::size_t, const char*, std::size_t) noexcept;
+#include "Utility/StdStringCompare.h"
 
 // STATIC: 0x01732638
 // GLOBAL: gl_24474

Source/Client/SessionAchievements.cpp

@@ -12,8 +12,7 @@
 #include <algorithm>
 #include <string>
 #include <vector>
-
-extern template int std::_Traits_compare<std::char_traits<char>>(const char*, std::size_t, const char*, std::size_t) noexcept;
+#include "Utility/StdStringCompare.h"
 
 struct JobTitleLess {
   bool operator()(int left, int right) const;

Source/Contents/ClientTiming.cpp

@@ -22,8 +22,8 @@
 #include <cstring>
 #include <timeapi.h>
 #include <windows.h>
+#include "Utility/StdStringCompare.h"
 
-extern template int std::_Traits_compare<std::char_traits<char>>(const char*, std::size_t, const char*, std::size_t) noexcept;
 extern template bool std::_Traits_equal<std::char_traits<char>>(const char*, std::size_t, const char*, std::size_t) noexcept;
 
 // GLOBAL: gl_24705

Source/Contents/EffectResourceSwitcher.cpp

@@ -20,8 +20,7 @@
 #include <new>
 #include <string>
 #include <vector>
-
-extern template int std::_Traits_compare<std::char_traits<char>>(const char*, std::size_t, const char*, std::size_t) noexcept;
+#include "Utility/StdStringCompare.h"
 
 // GLOBAL: gl_24485
 template <>

Source/Contents/Items/ItemInfo.cpp

@@ -13,8 +13,7 @@
 #include <cstring>
 #include <list>
 #include <vector>
-
-extern template int std::_Traits_compare<std::char_traits<char>>(const char*, std::size_t, const char*, std::size_t) noexcept;
+#include "Utility/StdStringCompare.h"
 
 namespace {
 #pragma pack(push, 1)

Source/Contents/Messenger/ClientMessenger.cpp

@@ -59,9 +59,8 @@
 
 extern "C" {
 #include <lualib.h>
-
-extern template int std::_Traits_compare<std::char_traits<char>>(const char*, std::size_t, const char*, std::size_t) noexcept;
 }
+#include "Utility/StdStringCompare.h"
 
 void __fastcall RefreshItemWindows(UIWindowMgr* mgr);
 

Source/Contents/Messenger/WhisperBlockMgr.cpp

@@ -2,8 +2,7 @@
 #include "Network/TextEncoding.h"
 
 #include <new>
-
-extern template int std::_Traits_compare<std::char_traits<char>>(const char*, std::size_t, const char*, std::size_t) noexcept;
+#include "Utility/StdStringCompare.h"
 
 // STATIC: 0x01389940
 // GLOBAL: gl_24357

Source/Contents/Models/ModelLighting.cpp

@@ -10,8 +10,7 @@
 #include "Utility/Math/ScalarConversion.h"
 #include <cmath>
 #include <cstring>
-
-extern template int std::_Traits_compare<std::char_traits<char>>(const char*, std::size_t, const char*, std::size_t) noexcept;
+#include "Utility/StdStringCompare.h"
 
 union ModelColor {
   std::uint32_t value;

Source/Contents/Movies/BinkMovies.cpp

@@ -11,8 +11,7 @@
 #include <algorithm>
 #include <cmath>
 #include <new>
-
-extern template int std::_Traits_compare<std::char_traits<char>>(const char*, std::size_t, const char*, std::size_t) noexcept;
+#include "Utility/StdStringCompare.h"
 
 // INLINED
 NamedBinkMovie::NamedBinkMovie() : radius(150.0f) {

Source/Contents/PrivateAirplaneMgr.cpp

@@ -10,9 +10,8 @@ extern "C" {
 #include <lauxlib.h>
 #include <lua.h>
 #include <lualib.h>
-
-extern template int std::_Traits_compare<std::char_traits<char>>(const char*, std::size_t, const char*, std::size_t) noexcept;
 }
+#include "Utility/StdStringCompare.h"
 
 // GLOBAL: gl_24636
 CPrivateAirplaneMgr* g_privateAirplaneItems;

Source/Contents/TownInfoMgr.cpp

@@ -14,8 +14,7 @@ extern "C" {
 #include <cstring>
 #include <new>
 #include <utility>
-
-extern template int std::_Traits_compare<std::char_traits<char>>(const char*, std::size_t, const char*, std::size_t) noexcept;
+#include "Utility/StdStringCompare.h"
 
 // GLOBAL: gl_24817
 CTownInfoMgr* g_townInfoMgr;

Source/Render/Primitives/ScreenLine.cpp

@@ -30,8 +30,7 @@
 #include <cmath>
 #include <windows.h>
 #include <timeapi.h>
-
-extern template int std::_Traits_compare<std::char_traits<char>>(const char*, std::size_t, const char*, std::size_t) noexcept;
+#include "Utility/StdStringCompare.h"
 
 namespace {
   __declspec(noinline) float ScreenLineSine(float angle) {

Source/Resource/ResourceFailures.cpp

@@ -5,8 +5,7 @@
 
 #include <cstdint>
 #include <cstring>
-
-extern template int std::_Traits_compare<std::char_traits<char>>(const char*, std::size_t, const char*, std::size_t) noexcept;
+#include "Utility/StdStringCompare.h"
 
 // GLOBAL: gl_24582
 ResourceFailures g_resourceFailures;

Source/UI/CashShop/UICashShopWnd.cpp

@@ -48,8 +48,7 @@
 #include <windows.h>
 #include <shellapi.h>
 #include <timeapi.h>
-
-extern template int std::_Traits_compare<std::char_traits<char>>(const char*, std::size_t, const char*, std::size_t) noexcept;
+#include "Utility/StdStringCompare.h"
 
 
 #pragma pack(push, 1)

Source/UI/EntryQueue/UIEntryQueueWnd.cpp

@@ -30,8 +30,7 @@
 #include <string>
 #include <utility>
 #include <windows.h>
-
-extern template int std::_Traits_compare<std::char_traits<char>>(const char*, std::size_t, const char*, std::size_t) noexcept;
+#include "Utility/StdStringCompare.h"
 
 // OFFSET: 0x00BA3920
 // FUNCTION: fn_19677

Source/UI/Item/UIMerchantItemLogWnd.cpp

@@ -30,8 +30,7 @@
 #include <cstdio>
 #include <cstdlib>
 #include <cstring>
-
-extern template int std::_Traits_compare<std::char_traits<char>>(const char*, std::size_t, const char*, std::size_t) noexcept;
+#include "Utility/StdStringCompare.h"
 
 // OFFSET: 0x0099E0E0
 // FUNCTION: fn_13571

Source/Utility/StdStringCompare.h

@@ -0,0 +1,6 @@
+#pragma once
+
+#include <cstddef>
+#include <string>
+
+extern template int std::_Traits_compare<std::char_traits<char>>(const char*, std::size_t, const char*, std::size_t) noexcept;