From 2f05afd82900d26ce92eb2af4b36870844f66057 Mon Sep 17 00:00:00 2001 From: ragnarok-clanker Date: Sat, 7 Nov 2026 04:10:23 +0000 Subject: [PATCH] Decompile fn_06324 (SetOption) Batch #13993 by eAthena: 0 byte-identical, 1 confirmed by peer review. - fn_06324 SetOption: logic confirmed by peer review Peer-reviewed-by: Yommy, KWDev, aDw Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes). --- Source/Contents/Configuration/ServiceOptions.cpp | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/Source/Contents/Configuration/ServiceOptions.cpp b/Source/Contents/Configuration/ServiceOptions.cpp index dff0ea7c8..21c7457c2 100644 --- a/Source/Contents/Configuration/ServiceOptions.cpp +++ b/Source/Contents/Configuration/ServiceOptions.cpp @@ -713,16 +713,18 @@ void GameSettings::ToggleOption(int id) { // OFFSET: 0x006C29A0 // FUNCTION: fn_06324 __declspec(noinline) int SetOption(const char* name, unsigned char value) { - if (!name || name[0] == '\0') { + if (IsNullOrEmpty(name)) { return 3; } int optionId = 3; std::string strings[3]; g_session.GetTalkType(name, &optionId, strings); - if (optionId != 3) { - g_serviceOptions.values[static_cast(optionId)] = value; + if (optionId == 3) { + return 3; } + + g_serviceOptions.values[static_cast(optionId)] = value; return optionId; }