From 2fa263e9337b8b816ab52c856e2e07377a857e3e Mon Sep 17 00:00:00 2001 From: ragnarok-clanker Date: Wed, 11 Nov 2026 22:19:54 +0000 Subject: [PATCH] Decompile 2 functions in Source/Client/Mode/GameModeHandlers.cpp Batch #17340 by eAthena: 0 byte-identical, 2 confirmed by peer review. - fn_22038 CGameMode::ReceiveAchievementUpdate: logic confirmed by peer review - fn_22024 CGameMode::ReceiveRuneSetGrades: logic confirmed by peer review Peer-reviewed-by: Yommy, alisonrag, SapitoSucio, cremane Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes). --- Source/Client/Mode/GameModeHandlers.cpp | 10 ++++------ 1 file changed, 4 insertions(+), 6 deletions(-) diff --git a/Source/Client/Mode/GameModeHandlers.cpp b/Source/Client/Mode/GameModeHandlers.cpp index e5ea30361..a09e04768 100644 --- a/Source/Client/Mode/GameModeHandlers.cpp +++ b/Source/Client/Mode/GameModeHandlers.cpp @@ -1852,9 +1852,10 @@ void CGameMode::ReceiveRuneSetGrades(const unsigned char* data) { count = size / sizeof(RuneSetGradeEntry); } - for (unsigned int i = 0; i < count; ++i) { - const RuneSetGradeEntry& entry = packet->entries[i]; - g_runeSystemMgr->SetRuneGrade(packet->tagId, 0, entry.id, entry.grade, entry.gradeLevel); + const RuneSetGradeEntry* entry = packet->entries; + for (; count != 0; --count) { + g_runeSystemMgr->SetRuneGrade(packet->tagId, 0, entry->id, entry->grade, entry->gradeLevel); + ++entry; } CTagData* tag = g_runeSystemMgr->GetTag(packet->tagId); @@ -2208,9 +2209,6 @@ void CGameMode::ReceiveAchievementUpdate( } AchievementInfo info; - info.rewardItemId = -1; - info.rewardTitleId = -1; - info.rewardBuffId = -1; g_achievementMgr->GetAchievement(info, id); const std::string text = FormatOwnedString(LookupMessage(MSI_NOTICE_NEXT_ROULLETE_STAGE), info.title.c_str()); static_cast(this->achievementBalloon)->WrapText(text.c_str(), 72);