From 30d9874ba2abf476b140d66b4fcb9211fa4b2672 Mon Sep 17 00:00:00 2001 From: ragnarok-clanker Date: Tue, 10 Nov 2026 16:41:10 +0000 Subject: [PATCH] Decompile fn_05324 (CAchievementMgr::InsertAchieveResource) Batch #16267 by Yommy: 0 byte-identical, 1 confirmed by peer review. - fn_05324 CAchievementMgr::InsertAchieveResource: logic confirmed by peer review Peer-reviewed-by: youko, kyoshi Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes). --- Source/Contents/AchievementMgr.cpp | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Source/Contents/AchievementMgr.cpp b/Source/Contents/AchievementMgr.cpp index ae47e7c8f..cbf79df0b 100644 --- a/Source/Contents/AchievementMgr.cpp +++ b/Source/Contents/AchievementMgr.cpp @@ -301,7 +301,8 @@ std::pair CAchievementMgr::InsertAchieveResource(int id, std: } std::vector& rewards = found->second.rewards; - if (std::find_if(rewards.begin(), rewards.end(), [text](const AchievementReward& reward) { return reward.text == text; }) == rewards.end()) { + const auto end = rewards.end(); + if (std::find_if(rewards.begin(), end, [text](const AchievementReward& reward) { return text.compare(reward.text) == 0; }) == end) { const AchievementReward reward(text, unknown0018, unknown001C); rewards.push_back(reward); return std::make_pair(true, "good");