From 31d94dabccf71ded3f22c1d030c707ec0cb3b50e Mon Sep 17 00:00:00 2001 From: ragnarok-clanker Date: Thu, 12 Nov 2026 10:46:22 +0000 Subject: [PATCH] Decompile 3 functions in Source/Contents/Effects/Skills/CherryBlossomEffect.cpp, Source/Contents/Effects/Skills/EnergyOrbEffect.cpp, ... Batch #18190 by eAthena: 0 byte-identical, 3 confirmed by peer review. - fn_19214 CStormGustEffect::OnProcess: logic confirmed by peer review - fn_19225 CStormKickEffect::OnProcess: logic confirmed by peer review - fn_19236 CThrowItemEffect::OnProcess: logic confirmed by peer review Peer-reviewed-by: ragnarok-clanker, Yommy, KWDev Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes). --- Source/Contents/Effects/Skills/StormGustEffect.cpp | 7 ++++--- Source/Contents/Effects/Skills/StormKickEffect.cpp | 7 ++++--- Source/Contents/Effects/Skills/ThrowEffects.cpp | 8 ++++---- 3 files changed, 12 insertions(+), 10 deletions(-) diff --git a/Source/Contents/Effects/Skills/StormGustEffect.cpp b/Source/Contents/Effects/Skills/StormGustEffect.cpp index f5cab59f7..90d1bb85f 100644 --- a/Source/Contents/Effects/Skills/StormGustEffect.cpp +++ b/Source/Contents/Effects/Skills/StormGustEffect.cpp @@ -72,10 +72,11 @@ bool CStormGustEffect::IsAlive() { // FUNCTION: fn_19214 void CStormGustEffect::OnProcess() { for (auto it = this->particles.begin(); it != this->particles.end(); ++it) { - (*it)->position.x = this->position[0]; - (*it)->position.y = this->position[1]; - (*it)->position.z = this->position[2]; CParticle* particle = *it; + vector3d& particlePosition = (*it)->position; + particlePosition.x = this->position[0]; + particlePosition.y = this->position[1]; + particlePosition.z = this->position[2]; if (particle) { if (particle->elapsedFrames == 3) { particle->speedParameter = 0.0f; diff --git a/Source/Contents/Effects/Skills/StormKickEffect.cpp b/Source/Contents/Effects/Skills/StormKickEffect.cpp index f215f0417..e967c6941 100644 --- a/Source/Contents/Effects/Skills/StormKickEffect.cpp +++ b/Source/Contents/Effects/Skills/StormKickEffect.cpp @@ -266,9 +266,10 @@ bool CStormKickEffect::IsAlive() { void CStormKickEffect::OnProcess() { for (auto it = this->storms.begin(); it != this->storms.end(); ++it) { CParticle* particle = *it; - particle->position.x = this->position[0]; - particle->position.y = this->position[1]; - particle->position.z = this->position[2]; + vector3d& particlePosition = (*it)->position; + particlePosition.x = this->position[0]; + particlePosition.y = this->position[1]; + particlePosition.z = this->position[2]; if (particle) { int alpha = particle->alpha; if (particle->elapsedFrames > 60 && this->id != EF_STORMKICK7) { diff --git a/Source/Contents/Effects/Skills/ThrowEffects.cpp b/Source/Contents/Effects/Skills/ThrowEffects.cpp index 2196603d5..89b8fa962 100644 --- a/Source/Contents/Effects/Skills/ThrowEffects.cpp +++ b/Source/Contents/Effects/Skills/ThrowEffects.cpp @@ -306,10 +306,10 @@ bool CThrowItemEffect::IsAlive() { void CThrowItemEffect::OnProcess() { for (auto particle = this->particles.begin(); particle != this->particles.end(); ++particle) { CParticle* target = *particle; - - target->position.x = this->position[0]; - target->position.y = this->position[1]; - target->position.z = this->position[2]; + vector3d& targetPosition = (*particle)->position; + targetPosition.x = this->position[0]; + targetPosition.y = this->position[1]; + targetPosition.z = this->position[2]; if (target != nullptr && this->launchDelay <= this->frame) { float& angle = target->speedParameter;