clank/rodecomp
1
0
Fork 0
Code Issues Wiki Activity

Maintenance: [forced, user-approved] Family W4: remove invented EffectAttachments (reference bundle over EffectActorState effects/fir

Browse source 
Batch #10257 by ragnarok-clanker: forced by an admin (7 lower score(s), 31 changed function(s)); checked with 95 compiled unit(s), including every includer of Source/Contents/Effects/EffectActor.h, Source/Contents/Effects/EffectAttachments.h.
Deletes: Source/Contents/Effects/EffectAttachments.h
This commit is contained in:
ragnarok-clanker 2026-11-03 13:09:24 +00:00
commit 3be8819db2
22 changed files with 118 additions and 177 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Source/Contents/Actors/Skill.cpp
View file

@ -543,7 +543,7 @@ void CSkill::SendMsg(CGameObject* sender, int message, int a, int b, int c, int
case 0x94:
this->render.unknown_00A4Bytes[1] = 1;
this->sub_E55320(this->GetTrapModelName());
if (this->render.enabled && !this->state.Attachments().HasId(0x91)) {
if (this->render.enabled && !this->HasId(0x91)) {
this->LaunchEffect(0x91, vector3d{0.0f, 0.0f, 0.0f}, 0.0f);
}
return;
@ -636,7 +636,7 @@ void CSkill::SendMsg(CGameObject* sender, int message, int a, int b, int c, int
this->m_effectId = 0x6B;
this->render.unknown_00A4Bytes[1] = 0;
this->sub_E55320(this->GetTrapModelName());
if (!this->state.Attachments().HasId(0x91)) {
if (!this->HasId(0x91)) {
this->LaunchEffect(0x91, vector3d{0.0f, 0.0f, 0.0f}, 0.0f);
}
return;
@ -940,7 +940,7 @@ void CSkill::SendMsg(CGameObject* sender, int message, int a, int b, int c, int
this->render.enabled = 1;
this->sub_E55320(this->GetTrapModelName());
if (this->GetEffectiveJob(-1) == 0x94 && !this->state.Attachments().HasId(0x91)) {
if (this->GetEffectiveJob(-1) == 0x94 && !this->HasId(0x91)) {
this->LaunchEffect(0x91, vector3d{0.0f, 0.0f, 0.0f}, 0.0f);
}