Decompile 10 functions in Source/Contents/Achievement/AchievementMgr.cpp, Source/Contents/Configuration/ServiceOptions.cpp, ...

Batch #18422 by KWDev: 10 byte-identical, 0 confirmed by peer review.

- fn_05337 CAchievementMgr::L_InsertAchieveInfo: byte-identical
- fn_06320 CGameSettingsMgr::ApplyScriptOption: byte-identical
- fn_06369 ApplyServiceOptionAskOnDisable: byte-identical
- fn_06938 CCommonFloorEffect::Open: byte-identical
- fn_06941 CCommonFloorEffect::OnProcess: byte-identical
- fn_07036 CHitLineEffect::Open: byte-identical
- fn_07505 CTalismanMarkEffect::OnProcess: byte-identical
- fn_02232 CRendererDX9::LockBackBuffer: byte-identical
- fn_11341 UIBarGraphPlayer::Paint: byte-identical
- fn_11342 UIBarGraphPlayerAP::Paint: byte-identical

Merged automatically: every function is byte-identical to the original.

Source/Contents/Achievement/AchievementMgr.cpp

@@ -386,9 +386,9 @@ int CAchievementMgr::L_InsertAchieveInfo(lua_State* state) {
     const std::string title = lua_tostring(state, -4);
     const std::string summaryText = lua_tostring(state, -3);
     const std::string description = lua_tostring(state, -2);
+    const double value = lua_tonumber(state, -1);
     CAchievementMgr* const manager = g_achievementMgr;
-    const std::pair<bool, std::string> result =
-      manager->InsertAchieveInfo(id, title, summaryText, description, static_cast<int>(lua_tonumber(state, -1)));
+    const std::pair<bool, std::string> result = manager->InsertAchieveInfo(id, title, summaryText, description, static_cast<int>(value));
     if (!result.first) {
       lua_pushboolean(state, 0);
       lua_pushstring(state, FormatString("InsertAchieveInfo : %s", result.second.c_str()));

Source/Contents/Configuration/ServiceOptions.cpp

@@ -745,7 +745,7 @@ bool ServiceOptions::Set(int id, unsigned char value) {
 // FUNCTION: fn_06320
 __declspec(noinline) void GameSettings::ApplyScriptOption(int id, const char* key) {
   for (const GameSettingsOption& option : this->options) {
-    if (option.id != id) {
+    if (id != option.id) {
       continue;
     }
 
@@ -1062,7 +1062,7 @@ void ApplyServiceOptionCursorClip(int id, unsigned char value, bool notify, int
 // OFFSET: 0x006C5DF0
 // FUNCTION: fn_06369
 void ApplyServiceOptionAskOnDisable(int id, unsigned char value, bool notify, int enabledMessage, int disabledMessage) {
-  if (g_serviceOptions.Get(0x128) == value) {
+  if (value == g_serviceOptions.Get(0x128)) {
     return;
   }
 

Source/Contents/Effects/Skills/CommonFloorEffect.cpp

@@ -46,9 +46,9 @@ void CCommonFloorEffect::Open() {
     if (particle) {
       particle->SetTexture("effect\\ra_unlimit.tga");
       particle->effectId = this->id;
-      particle->groupIndex = 1;
       particle->columnIndex = i;
       particle->rowIndex = 0;
+      particle->groupIndex = 1;
       particle->alpha = 90;
       *reinterpret_cast<float*>(&particle->angleBits) = static_cast<float>(angle);
       particle->phaseParameter = angle;
@@ -90,7 +90,7 @@ bool CCommonFloorEffect::IsAlive() {
 void CCommonFloorEffect::OnProcess() {
   for (auto it = this->particles.begin(); it != this->particles.end(); ++it) {
     CParticle* particle = *it;
-    vector3d& position = (*it)->position;
+    vector3d& position = particle->position;
     position.x = this->position[0];
     position.y = this->position[1];
     position.z = this->position[2];
@@ -118,7 +118,7 @@ void CCommonFloorEffect::OnProcess() {
       result.Compose(scale, rotation);
       particle->transform = result;
     }
-    ++(*it)->elapsedFrames;
+    ++particle->elapsedFrames;
   }
 }
 

Source/Contents/Effects/Skills/HitLineEffect.cpp

@@ -41,8 +41,9 @@ void CHitLineEffect::Open() {
         CParticle* particle = CreateParticle(reinterpret_cast<const vector3d*>(this->position), 5);
         if (particle) {
           particle->SetTexture("effect\\white02.bmp");
+          const int id = this->id;
           particle->rowIndex = line;
-          particle->effectId = this->id;
+          particle->effectId = id;
           particle->columnIndex = segment;
           particle->groupIndex = 4;
           particle->elapsedFrames = delay;

Source/Contents/Effects/Skills/TalismanMarkEffect.cpp

@@ -127,7 +127,7 @@ void CTalismanMarkEffect::OnProcess() {
       continue;
     }
 
-    switch (particle->animationState) {
+    switch (static_cast<signed char>(particle->animationState)) {
     case 0:
       if (IsParticleActive(particle)) {
         break;

Source/Render/DX9/RendererBackBuffer.cpp

@@ -16,16 +16,16 @@ int CRendererDX9::LockBackBuffer() {
 
   int bitsPerPixel;
   switch (owner.backBufferDescription.Format) {
-  case D3DFMT_A8R8G8B8:
-  case D3DFMT_X8R8G8B8:
-    bitsPerPixel = 32;
-    break;
   case D3DFMT_R5G6B5:
   case D3DFMT_X1R5G5B5:
   case D3DFMT_A1R5G5B5:
   case D3DFMT_A4R4G4B4:
     bitsPerPixel = 16;
     break;
+  case D3DFMT_A8R8G8B8:
+  case D3DFMT_X8R8G8B8:
+    bitsPerPixel = 32;
+    break;
   default:
     bitsPerPixel = 0;
     break;

Source/UI/Gauges/UIBarGraph.cpp

@@ -199,7 +199,8 @@ void UIBarGraphPlayer::Paint() {
     return;
   }
 
-  this->DrawBitmap(0, 0, static_cast<CBitmapRes*>(ResourceMgr::Instance().Load(Resolve("유저인터페이스\\basic_interface\\gze_bg1.bmp"))), false);
+  CBitmapRes* background = static_cast<CBitmapRes*>(ResourceMgr::Instance().Load(Resolve("유저인터페이스\\basic_interface\\gze_bg1.bmp")));
+  this->DrawBitmap(0, 0, background, false);
   if (0 == maximum) {
     return;
   }
@@ -238,7 +239,8 @@ void UIBarGraphPlayerAP::Paint() {
     return;
   }
 
-  this->DrawBitmap(0, 0, static_cast<CBitmapRes*>(ResourceMgr::Instance().Load(Resolve("유저인터페이스\\basic_interface\\gze_bg1.bmp"))), false);
+  CBitmapRes* background = static_cast<CBitmapRes*>(ResourceMgr::Instance().Load(Resolve("유저인터페이스\\basic_interface\\gze_bg1.bmp")));
+  this->DrawBitmap(0, 0, background, false);
   if (maximum > 0) {
     const double ratio = static_cast<double>(current) / static_cast<double>(maximum);
     if (ratio > 0.0) {