From 45a975ac837e21bb48ecfc3a340f1393e8eff61c Mon Sep 17 00:00:00 2001 From: ragnarok-clanker Date: Wed, 11 Nov 2026 13:46:15 +0000 Subject: [PATCH] Confirm 8 functions in Source/Contents/Items/ClientItemLists.cpp Batch #16949 by eAthena: 0 byte-identical, 8 confirmed by peer review. - fn_21640 CGameMode::ReceiveItem1738Add: logic confirmed by peer review (already on main) - fn_21642 CGameMode::ReceiveItemSlotOptions: logic confirmed by peer review (already on main) - fn_21645 CGameMode::ReceiveItem1740AddOptions: logic confirmed by peer review (already on main) - fn_21646 CGameMode::ReceiveItem1740AddGrade: logic confirmed by peer review (already on main) - fn_21647 CGameMode::ReceiveItem1738AddOptions: logic confirmed by peer review (already on main) - fn_21648 CGameMode::ReceiveItem1738AddGrade: logic confirmed by peer review (already on main) - fn_21832 CGameMode::ReceiveEquipItemList: logic confirmed by peer review (already on main) - fn_21833 CGameMode::ReceiveItemListPart: logic confirmed by peer review (already on main) Peer-reviewed-by: Yommy, alisonrag, br4yan Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes). --- Source/Contents/Items/ClientItemLists.cpp | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Source/Contents/Items/ClientItemLists.cpp b/Source/Contents/Items/ClientItemLists.cpp index 0fe9489dc..a97628e2e 100644 --- a/Source/Contents/Items/ClientItemLists.cpp +++ b/Source/Contents/Items/ClientItemLists.cpp @@ -256,7 +256,7 @@ void __fastcall RefreshItemWindows(UIWindowMgr* mgr) { static int CountItemOptions(const ItemRandomOption* options) { int count = 0; for (int index = 0; index < 5; ++index) { - if (options[index].id != 0) { + if (0 != options[index].id) { ++count; } } @@ -1001,7 +1001,7 @@ void CSession::MergeShopItem(const ITEM_INFO& item) { // OFFSET: 0x00DD7B80 // FUNCTION: fn_23299 -bool CSession::AddCartItem(const ITEM_INFO& item, unsigned char refresh) { +__declspec(noinline) bool CSession::AddCartItem(const ITEM_INFO& item, unsigned char refresh) { if (g_replayAnimationScaling && !Replay::Instance().header.options.Get(ReplayRecordOption::Item)) { return true; }