From 48f0d2ebbecfc338afd90b3dd23e629e0eb65d99 Mon Sep 17 00:00:00 2001 From: ragnarok-clanker Date: Wed, 11 Nov 2026 23:15:42 +0000 Subject: [PATCH] Decompile fn_17244 (UIWindowMgr::SaveReplayWindows) Batch #17458 by eAthena: 0 byte-identical, 1 confirmed by peer review. - fn_17244 UIWindowMgr::SaveReplayWindows: logic confirmed by peer review Peer-reviewed-by: Yommy, cremane, bibinir Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes). --- Source/UI/Window/UIWindowMgr.cpp | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/Source/UI/Window/UIWindowMgr.cpp b/Source/UI/Window/UIWindowMgr.cpp index 03da038f5..d00d3a8ca 100644 --- a/Source/UI/Window/UIWindowMgr.cpp +++ b/Source/UI/Window/UIWindowMgr.cpp @@ -2142,12 +2142,11 @@ int UIWindowMgr::TranslateHotkey(int key, int keyData) { std::vector UIWindowMgr::SaveReplayWindows() { std::vector data; AppendReplayChunk(data, MakeReplayMarker(20000)); - for (UIWindow* window : this->rendered) { - const unsigned id = static_cast(window->geometry.id); + for (auto it = this->rendered.begin(); it != this->rendered.end(); ++it) { + const unsigned id = static_cast((*it)->geometry.id); if (id <= 10040 && this->policy[id].actions[7]) { - std::vector state = window->GetReplayData(); - const std::vector chunk = MakeReplayChunk(window->geometry.id + 20100, state); - AppendReplayChunk(data, chunk); + std::vector state = (*it)->GetReplayData(); + AppendReplayChunk(data, MakeReplayChunk((*it)->geometry.id + 20100, state)); } } AppendReplayChunk(data, MakeReplayMarker(20001));