From 4acb9d975df94f73bf48750e8fca55fc67ebdf66 Mon Sep 17 00:00:00 2001
From: ragnarok-clanker <ragnarok-clanker>
Date: Tue, 10 Nov 2026 13:29:50 +0000
Subject: [PATCH] Decompile fn_03929
 (CCharacterLinkedUserDataMgr::LoadNormalItemSlots)

Batch #16066 by Yommy: 0 byte-identical, 1 confirmed by peer review.

- fn_03929 CCharacterLinkedUserDataMgr::LoadNormalItemSlots: logic confirmed by peer review

Peer-reviewed-by: eAthena, alisonrag
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
---
 Source/UI/Shortcuts/NormalItemSlotLoad.cpp | 13 ++++++++-----
 1 file changed, 8 insertions(+), 5 deletions(-)

diff --git a/Source/UI/Shortcuts/NormalItemSlotLoad.cpp b/Source/UI/Shortcuts/NormalItemSlotLoad.cpp
index d258a62aa..64dc877ef 100644
--- a/Source/UI/Shortcuts/NormalItemSlotLoad.cpp
+++ b/Source/UI/Shortcuts/NormalItemSlotLoad.cpp
@@ -12,10 +12,11 @@
 // OFFSET: 0x005E65E0
 // FUNCTION: fn_03929
 void CCharacterLinkedUserDataMgr::LoadNormalItemSlots(Json::Value& data) {
+  const Json::Value& root = data;
   NormalItemSlotWindow& saved = g_windowMgr.m_normalItemSlotWindow;
   bool& itemSlotActive = g_session.ItemSlotActive();
 
-  Json::Value& values = data["NormalItemSlot"];
+  const Json::Value& values = root["NormalItemSlot"];
 
   if (values.isNull()) {
     return;
@@ -24,7 +25,7 @@ void CCharacterLinkedUserDataMgr::LoadNormalItemSlots(Json::Value& data) {
   g_session.ClearNormalItemSlots();
 
   for (auto entry = values.begin(); entry != values.end(); ++entry) {
-    Json::Value& value = *entry;
+    const Json::Value& value = *entry;
 
     if (!value.isObject()) {
       continue;
@@ -35,10 +36,12 @@ void CCharacterLinkedUserDataMgr::LoadNormalItemSlots(Json::Value& data) {
     g_session.m_normalItemSlots[index].itemId = static_cast<std::uint32_t>(item);
   }
 
-  Json::Value& info = data["SlotInfo"];
+  const Json::Value& info = root["SlotInfo"];
 
   if (info.empty()) {
-    saved.Reset();
+    NormalItemSlotWindow defaults;
+    defaults.Reset();
+    saved = defaults;
   } else {
     const int x = info.get("SlotX", 0).asInt();
     const int y = info.get("SlotY", 0).asInt();
@@ -53,7 +56,7 @@ void CCharacterLinkedUserDataMgr::LoadNormalItemSlots(Json::Value& data) {
     saved.show = show;
   }
 
-  Json::Value& active = data["ItemSlotActive"];
+  const Json::Value& active = root["ItemSlotActive"];
   itemSlotActive = active.isNull() ? true : active.asBool();
 
   UIWindow* window = g_windowMgr.LookupWindow(WID_SHORTCUTWND);