From 4f0caebf03dd4c7dce6d75e91f3aeb5e37920d93 Mon Sep 17 00:00:00 2001 From: ragnarok-clanker Date: Wed, 4 Nov 2026 18:11:18 +0000 Subject: [PATCH] Decompile 7 functions in Source/Contents/ClientItemLists.cpp Batch #10801 by kyoshi: 0 byte-identical, 7 confirmed by peer review. - fn_23338 CSession::RemoveItem1758ByItemId: logic confirmed by peer review - fn_23339 CSession::RemoveItem1710: logic confirmed by peer review (already on main) - fn_23340 CSession::RemoveItem1768: logic confirmed by peer review - fn_23341 CSession::RemoveItem1740: logic confirmed by peer review - fn_23345 CSession::RemoveItem1718ByItemId: logic confirmed by peer review - fn_23347 CSession::RemoveItem1720ByName: logic confirmed by peer review - fn_23351 CSession::RemoveItem1738: logic confirmed by peer review Peer-reviewed-by: dori, cremane, StrawberrysherbetIX Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes). --- Source/Contents/ClientItemLists.cpp | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/Source/Contents/ClientItemLists.cpp b/Source/Contents/ClientItemLists.cpp index 823e8705..c7ff7749 100644 --- a/Source/Contents/ClientItemLists.cpp +++ b/Source/Contents/ClientItemLists.cpp @@ -1517,7 +1517,7 @@ void CSession::RemoveItem1758ByItemId(ITEM_INFO& item) { if (std::atoi(it->itemId.c_str()) == std::atoi(item.itemId.c_str())) { item.itemId = it->itemId; it->quantity -= item.quantity; - if (it->quantity < 1) { + if (it->quantity <= 0) { this->unknown_1758.erase(it); } return; @@ -1555,7 +1555,7 @@ bool CSession::RemoveItem1768(const ITEM_INFO& item, unsigned char alternate) { if (it->unknown_0000[1] == item.unknown_0000[1]) { if (!alternate) { it->quantity -= item.quantity; - if (it->quantity < 1) { + if (it->quantity <= 0) { this->unknown_1768.erase(it); reinterpret_cast(this)->RefreshItem1768Window(0, index + 1); return true; @@ -1578,7 +1578,7 @@ bool CSession::RemoveItem1740(const ITEM_INFO& item) { for (auto it = this->unknown_1740.begin(); it != this->unknown_1740.end(); ++it) { if (it->unknown_0000[1] == item.unknown_0000[1]) { it->quantity -= item.quantity; - if (it->quantity < 1) { + if (it->quantity <= 0) { this->unknown_1740.erase(it); } for (auto it2 = this->unknown_1740.begin(); it2 != this->unknown_1740.end(); ++it2) { @@ -1631,7 +1631,7 @@ void CSession::RemoveItem1718ByItemId(const ITEM_INFO& item) { if (std::atoi(it->itemId.c_str()) == std::atoi(item.itemId.c_str())) { if (it->quantity != -1) { it->quantity -= item.quantity; - if (it->quantity < 1) { + if (it->quantity <= 0) { this->unknown_1718.erase(it); } } @@ -1662,7 +1662,7 @@ void CSession::RemoveItem1720ByName(const ITEM_INFO& item) { for (auto it = this->unknown_1720.begin(); it != this->unknown_1720.end(); ++it) { if (it->itemId == item.itemId) { it->quantity -= item.quantity; - if (it->quantity < 1) { + if (it->quantity <= 0) { this->unknown_1720.erase(it); } return; @@ -1704,7 +1704,7 @@ bool CSession::RemoveItem1738(const ITEM_INFO& item) { for (auto it = this->unknown_1738.begin(); it != this->unknown_1738.end(); ++it) { if (it->unknown_0000[1] == item.unknown_0000[1]) { it->quantity -= item.quantity; - if (it->quantity < 1) { + if (it->quantity <= 0) { this->unknown_1738.erase(it); } for (auto it2 = this->unknown_1738.begin(); it2 != this->unknown_1738.end(); ++it2) {