From 525fd80cea5415425eb321176bd7d206f63cd2e9 Mon Sep 17 00:00:00 2001 From: ragnarok-clanker Date: Sat, 31 Oct 2026 12:45:41 +0000 Subject: [PATCH] Decompile 2 functions in Source/UI/Quest/UIOngoingQuestInfo.cpp, Source/UI/Quest/UIOngoingQuestInfo.h Batch #7940 by eAthena: 0 byte-identical, 2 confirmed by peer review. - fn_16218 CUIListBoxEx::~CUIListBoxEx: logic confirmed by peer review - fn_16222 CreateOngoingQuestInfo: logic confirmed by peer review Peer-reviewed-by: ragnarok-clanker, Yommy Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes). --- Source/UI/Quest/UIOngoingQuestInfo.cpp | 36 ++++++++++++++++++++++++++ Source/UI/Quest/UIOngoingQuestInfo.h | 13 +++------- 2 files changed, 40 insertions(+), 9 deletions(-) diff --git a/Source/UI/Quest/UIOngoingQuestInfo.cpp b/Source/UI/Quest/UIOngoingQuestInfo.cpp index 98cc6eae..6a0e493c 100644 --- a/Source/UI/Quest/UIOngoingQuestInfo.cpp +++ b/Source/UI/Quest/UIOngoingQuestInfo.cpp @@ -52,6 +52,18 @@ CUIListBoxEx unknown_00E0(1), rebind(0) { } +// OFFSET: 0x00A4F7F0 +// FUNCTION: fn_16218 +template <> +CUIListBoxEx::~CUIListBoxEx() { +} + +// OFFSET: 0x00A4FD60 +// FUNCTION: fn_16222 +CUIOngoingQuestInfo* CreateOngoingQuestInfo() { + return new CUIOngoingQuestInfo(); +} + // OFFSET: 0x00A4FDE0 // FUNCTION: fn_16223 template <> @@ -567,3 +579,27 @@ void CUIScrollWindow::Slot15(int width, int height) { } } + +namespace OngoingQuestInfo { +// OFFSET: 0x00A54D00 +CUIContents::CUIContents(UIWindowContext& context) : CUIControl(context), title(nullptr), textViewer(nullptr), icon(nullptr) { +} +} + +// OFFSET: 0x00A54D90 +CUIOngoingQuestInfo::CUIOngoingQuestInfo() + : titleBar(nullptr), unknown_00DC{}, titleText(nullptr), scrollWindow(nullptr), dateText(nullptr), unknown_00EC{}, questId(0) { +} + +namespace OngoingQuestInfo { +// OFFSET: 0x00A54F20 +CUIRewards::CUIRewards(UIWindowContext& context) + : CUIControl(context), title(nullptr), firstLabel(nullptr), firstText(nullptr), secondLabel(nullptr), secondText(nullptr), thirdLabel(nullptr), + rewardList(nullptr), npcSprite(nullptr) { +} + +// OFFSET: 0x00A54FF0 +CUIScrollWindow::CUIScrollWindow(UIWindowContext& context) + : CUIControl(context), firstLine(nullptr), secondContents(nullptr), secondLine(nullptr), rewards(nullptr), scrollBar(nullptr), firstContents(nullptr) { +} +} diff --git a/Source/UI/Quest/UIOngoingQuestInfo.h b/Source/UI/Quest/UIOngoingQuestInfo.h index 637a8297..9afb5291 100644 --- a/Source/UI/Quest/UIOngoingQuestInfo.h +++ b/Source/UI/Quest/UIOngoingQuestInfo.h @@ -16,6 +16,7 @@ class CUIScrollWindow; class CUIOngoingQuestInfo : public CUIFrameWnd { public: + __declspec(noinline) CUIOngoingQuestInfo(); void Slot16() override; void OnFirstAction(); virtual void Slot53(); @@ -41,8 +42,7 @@ public: class CUIContents : public CUIControl { public: - __declspec(noinline) explicit CUIContents(UIWindowContext& context) : CUIControl(context), title(nullptr), textViewer(nullptr), icon(nullptr) { - } + __declspec(noinline) explicit CUIContents(UIWindowContext& context); void Slot15(int width, int height) override; void Slot16() override; @@ -74,10 +74,7 @@ public: class CUIRewards : public CUIControl { public: - __declspec(noinline) explicit CUIRewards(UIWindowContext& context) - : CUIControl(context), title(nullptr), firstLabel(nullptr), firstText(nullptr), secondLabel(nullptr), secondText(nullptr), thirdLabel(nullptr), - rewardList(nullptr), npcSprite(nullptr) { - } + __declspec(noinline) explicit CUIRewards(UIWindowContext& context); void Slot16() override; void Paint() override; @@ -103,9 +100,7 @@ public: class CUIScrollWindow : public CUIControl { public: - __declspec(noinline) explicit CUIScrollWindow(UIWindowContext& context) - : CUIControl(context), firstLine(nullptr), secondContents(nullptr), secondLine(nullptr), rewards(nullptr), scrollBar(nullptr), firstContents(nullptr) { - } + __declspec(noinline) explicit CUIScrollWindow(UIWindowContext& context); void Slot15(int width, int height) override; void Slot16() override;