clank/rodecomp
1
0
Fork 0
Code Issues Wiki Activity

Decompile fn_17136 (UIWindowMgr::CreateBrowser)

Browse source 
Batch #15514 by youko: 0 byte-identical, 1 confirmed by peer review.

- fn_17136 UIWindowMgr::CreateBrowser: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker, eAthena, Yommy
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
This commit is contained in:
ragnarok-clanker 2026-11-10 09:12:53 +00:00
commit 589e502c9e
1 changed files with 9 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

19
Source/Client/Browser/BrowserFactory.cpp
View file

@ -15,16 +15,15 @@ namespace {
// OFFSET: 0x00A8C840
// FUNCTION: fn_17136
CWebBrowser* UIWindowMgr::CreateBrowser(int width, int height) {
if (this->browsers.size() >= maximumBrowserCount) {
this->SendNotice(UIM_OPENCHATWND, 0, 0, 0, 0, 0);
this->SendNotice(UIM_PUSHINTOCHATHISTORY, reinterpret_cast<std::intptr_t>(LookupMessage(MSI_FAILED_ADD_TAB)), RGB(255, 0, 0), 0, 0, 0);
return nullptr;
}
CWebBrowser* browser = new CWebBrowser();
if (browser && browser->Create(hWnd, g_instance, width, height)) {
this->browsers.emplace(browser->host, browser);
return browser;
if (this->browsers.size() < maximumBrowserCount) {
CWebBrowser* browser = new CWebBrowser();
if (browser && browser->Create(hWnd, g_instance, width, height)) {
this->browsers.insert(std::make_pair(browser->host, browser));
return browser;
}
} else {
g_windowMgr.SendNotice(UIM_OPENCHATWND, 0, 0, 0, 0, 0);
g_windowMgr.SendNotice(UIM_PUSHINTOCHATHISTORY, reinterpret_cast<std::intptr_t>(LookupMessage(MSI_FAILED_ADD_TAB)), RGB(255, 0, 0), 0, 0, 0);
}
return nullptr;