From 74bcb64ce49a59ae6bcb51e0a4e893506d46726a Mon Sep 17 00:00:00 2001 From: ragnarok-clanker Date: Wed, 11 Nov 2026 21:41:47 +0000 Subject: [PATCH] Decompile 3 functions in Source/Contents/Achievement/AchievementMgr.cpp Batch #17336 by eAthena: 0 byte-identical, 3 confirmed by peer review. - fn_05325 CAchievementMgr::InsertAchieveRewardBuff: logic confirmed by peer review - fn_05326 CAchievementMgr::InsertAchieveRewardItem: logic confirmed by peer review - fn_05327 CAchievementMgr::InsertAchieveRewardTitle: logic confirmed by peer review Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes). --- .../Contents/Achievement/AchievementMgr.cpp | 24 +++++++++---------- 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/Source/Contents/Achievement/AchievementMgr.cpp b/Source/Contents/Achievement/AchievementMgr.cpp index 1f887c768..4ef06a04b 100644 --- a/Source/Contents/Achievement/AchievementMgr.cpp +++ b/Source/Contents/Achievement/AchievementMgr.cpp @@ -283,39 +283,39 @@ std::pair CAchievementMgr::InsertAchieveResource(int id, std: // FUNCTION: fn_05325 std::pair CAchievementMgr::InsertAchieveRewardBuff(int id, int value) { const auto found = this->achievements.find(id); - if (found == this->achievements.end()) { + if (found != this->achievements.end()) { + found->second.rewardBuffId = value; + return std::make_pair(true, "good"); + } else { const std::string message = FormatOwnedString("achievement info [%d] cannot be find", id); return std::make_pair(false, message); } - - found->second.rewardBuffId = value; - return std::make_pair(true, "good"); } // OFFSET: 0x0066F570 // FUNCTION: fn_05326 std::pair CAchievementMgr::InsertAchieveRewardItem(int id, int value) { const auto found = this->achievements.find(id); - if (found == this->achievements.end()) { + if (found != this->achievements.end()) { + found->second.rewardItemId = value; + return std::make_pair(true, "good"); + } else { const std::string message = FormatOwnedString("achievement info [%d] cannot be find", id); return std::make_pair(false, message); } - - found->second.rewardItemId = value; - return std::make_pair(true, "good"); } // OFFSET: 0x0066F690 // FUNCTION: fn_05327 std::pair CAchievementMgr::InsertAchieveRewardTitle(int id, int value) { const auto found = this->achievements.find(id); - if (found == this->achievements.end()) { + if (found != this->achievements.end()) { + found->second.rewardTitleId = value; + return std::make_pair(true, "good"); + } else { const std::string message = FormatOwnedString("achievement info [%d] cannot be find", id); return std::make_pair(false, message); } - - found->second.rewardTitleId = value; - return std::make_pair(true, "good"); } // OFFSET: 0x0066F7B0