clank/rodecomp
1
0
Fork 0
Code Issues Wiki Activity

Decompile fn_23900 (EmotionHotkeys::HasChanges)

Browse source 
Batch #14863 by codeplay: 0 byte-identical, 1 confirmed by peer review.

- fn_23900 EmotionHotkeys::HasChanges: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker, ntrl, NYD, Stingor
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
This commit is contained in:
ragnarok-clanker 2026-11-08 14:19:55 +00:00
commit 7caabd2fda
2 changed files with 7 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Source/Contents/Hotkeys/EmotionHotkeys.cpp
View file

@ -11,6 +11,8 @@
#include <json/value.h>
#include <io.h>
extern template bool std::_Traits_equal<std::char_traits<char>>(const char*, std::size_t, const char*, std::size_t) noexcept;
// OFFSET: 0x005BC230
// FUNCTION: fn_03463
void EmotionHotkeys::Load(Json::Value& data) {
@ -29,8 +31,10 @@ void EmotionHotkeys::Load(Json::Value& data) {
// FUNCTION: fn_23900
bool EmotionHotkeys::HasChanges() const {
if (!this->saved.empty()) {
const std::string* current = this->current.data();
const std::string* saved = this->saved.data();
for (int i = 0; i < 10; ++i) {
if (this->saved[i] != this->current[i]) {
if (saved[i] != current[i]) {
return true;
}
}

2
Source/Contents/Hotkeys/UserHotkeyScript.cpp
View file

@ -2,6 +2,8 @@
#include "Contents/Hotkeys/UserHotkeyScript.h"
#include "Network/TextEncoding.h"
template bool std::_Traits_equal<std::char_traits<char>>(const char*, std::size_t, const char*, std::size_t) noexcept;
// OFFSET: 0x005F7D60
// FUNCTION: fn_04055
void ClearUserHotkeys() {