From 7d2a55bd4e07d80f588827d9690aaa43e595ef16 Mon Sep 17 00:00:00 2001
From: ragnarok-clanker <ragnarok-clanker>
Date: Tue, 10 Nov 2026 09:28:56 +0000
Subject: [PATCH] Decompile fn_01894 (DeviceOwnerDX7::CreateSurfaces)

Batch #15581 by Yommy: 0 byte-identical, 1 confirmed by peer review.

- fn_01894 DeviceOwnerDX7::CreateSurfaces: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker, eAthena
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
---
 Source/Render/DX7/DeviceOwnerDX7.cpp | 53 ++++++++++++++++++----------
 1 file changed, 34 insertions(+), 19 deletions(-)

diff --git a/Source/Render/DX7/DeviceOwnerDX7.cpp b/Source/Render/DX7/DeviceOwnerDX7.cpp
index b15f270d5..2300697f7 100644
--- a/Source/Render/DX7/DeviceOwnerDX7.cpp
+++ b/Source/Render/DX7/DeviceOwnerDX7.cpp
@@ -126,7 +126,6 @@ DeviceOwnerDX7::~DeviceOwnerDX7() {
 // OFFSET: 0x005498A0
 // FUNCTION: fn_01894
 HRESULT DeviceOwnerDX7::CreateSurfaces(const DDSURFACEDESC2* mode, DWORD flags) {
-  const bool buffered = (flags & 2) != 0;
   DDSURFACEDESC2 description;
   HRESULT status;
 
@@ -135,7 +134,11 @@ HRESULT DeviceOwnerDX7::CreateSurfaces(const DDSURFACEDESC2* mode, DWORD flags)
     this->width = this->source.right;
     this->height = this->source.bottom;
     this->destination = this->source;
-    const DWORD modeFlags = this->width == 320 && this->height == 200 && mode->ddpfPixelFormat.dwRGBBitCount == 8 ? DDSDM_STANDARDVGAMODE : 0;
+    DWORD modeFlags = 0;
+
+    if (this->width == 320 && this->height == 200 && mode->ddpfPixelFormat.dwRGBBitCount == 8) {
+      modeFlags = DDSDM_STANDARDVGAMODE;
+    }
 
     if (FAILED(this->draw->SetDisplayMode(this->width, this->height, mode->ddpfPixelFormat.dwRGBBitCount, mode->dwRefreshRate, modeFlags))) {
       return DeviceError(9);
@@ -144,7 +147,7 @@ HRESULT DeviceOwnerDX7::CreateSurfaces(const DDSURFACEDESC2* mode, DWORD flags)
     SurfaceDescription(&description, DDSD_CAPS, 0);
     description.ddsCaps.dwCaps = DDSCAPS_PRIMARYSURFACE | DDSCAPS_3DDEVICE;
 
-    if (buffered) {
+    if (flags & 2) {
       description.dwFlags |= DDSD_BACKBUFFERCOUNT;
       description.ddsCaps.dwCaps = DDSCAPS_PRIMARYSURFACE | DDSCAPS_3DDEVICE | DDSCAPS_COMPLEX | DDSCAPS_FLIP;
       description.dwBackBufferCount = 1;
@@ -156,7 +159,7 @@ HRESULT DeviceOwnerDX7::CreateSurfaces(const DDSURFACEDESC2* mode, DWORD flags)
       return SurfaceError(status, 7);
     }
 
-    if (buffered) {
+    if (flags & 2) {
       DDSCAPS2 caps{DDSCAPS_BACKBUFFER};
       status = this->primary->GetAttachedSurface(&caps, &this->backBuffer);
 
@@ -164,36 +167,48 @@ HRESULT DeviceOwnerDX7::CreateSurfaces(const DDSURFACEDESC2* mode, DWORD flags)
         return SurfaceError(status, 10);
       }
     }
+
+    IDirectDrawClipper* clipper;
+
+    if (FAILED(this->draw->CreateClipper(0, &clipper, nullptr))) {
+      return DeviceError(8);
+    }
+
+    clipper->SetHWnd(0, this->window);
+    this->primary->SetClipper(clipper);
+
+    if (clipper) {
+      clipper->Release();
+      clipper = nullptr;
+    }
   } else {
     GetClientRect(this->window, &this->source);
     this->width = this->source.right;
     this->height = this->source.bottom;
     this->destination = ClientRectangle(this->window);
     SurfaceDescription(&description, DDSD_CAPS, 0);
-    description.ddsCaps.dwCaps = buffered ? DDSCAPS_PRIMARYSURFACE : DDSCAPS_PRIMARYSURFACE | DDSCAPS_3DDEVICE;
+    description.ddsCaps.dwCaps = (flags & 2) ? DDSCAPS_PRIMARYSURFACE : DDSCAPS_PRIMARYSURFACE | DDSCAPS_3DDEVICE;
     status = this->draw->CreateSurface(&description, &this->primary, nullptr);
 
     if (FAILED(status)) {
       return SurfaceError(status, 7);
     }
-  }
 
-  IDirectDrawClipper* clipper;
+    IDirectDrawClipper* clipper;
 
-  if (FAILED(this->draw->CreateClipper(0, &clipper, nullptr))) {
-    return DeviceError(8);
-  }
+    if (FAILED(this->draw->CreateClipper(0, &clipper, nullptr))) {
+      return DeviceError(8);
+    }
 
-  clipper->SetHWnd(0, this->window);
-  this->primary->SetClipper(clipper);
+    clipper->SetHWnd(0, this->window);
+    this->primary->SetClipper(clipper);
 
-  if (clipper) {
-    clipper->Release();
-    clipper = nullptr;
-  }
+    if (clipper) {
+      clipper->Release();
+      clipper = nullptr;
+    }
 
-  if (!(flags & 1)) {
-    if (buffered) {
+    if (flags & 2) {
       description.dwWidth = this->width;
       description.dwHeight = this->height;
       description.dwFlags = DDSD_CAPS | DDSD_HEIGHT | DDSD_WIDTH;
@@ -221,7 +236,7 @@ HRESULT DeviceOwnerDX7::CreateSurfaces(const DDSURFACEDESC2* mode, DWORD flags)
   ChannelMask(this->green, this->greenMask);
   ChannelMask(this->blue, this->blueMask);
   ChannelMask(this->alpha, this->alphaMask);
-  this->renderTarget = buffered ? this->backBuffer : this->primary;
+  this->renderTarget = (flags & 2) ? this->backBuffer : this->primary;
   this->renderTarget->AddRef();
   SurfaceDescription(&description, DDSD_CAPS | DDSD_HEIGHT | DDSD_WIDTH | DDSD_PIXELFORMAT, 0);
   description.dwFlags = DDSD_CAPS | DDSD_HEIGHT | DDSD_WIDTH;