clank/rodecomp
1
0
Fork 0
Code Issues Wiki Activity

Confirm 4 functions in Source/UI/Window/UIWindowMgr.cpp

Browse source 
Batch #10787 by StrawberrysherbetIX: 0 byte-identical, 4 confirmed by peer review.

- fn_17099 UIWindowMgr::~UIWindowMgr: logic confirmed by peer review (already on main)
- fn_17220 UIWindowMgr::ProcessHotkeyAction: logic confirmed by peer review (already on main)
- fn_17225 UIWindowMgr::CycleWindowVisibility: logic confirmed by peer review (already on main)
- fn_17253 UIWindowMgr::SendNotice: logic confirmed by peer review (already on main)

Peer-reviewed-by: Yommy, dori, cremane
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
This commit is contained in:
ragnarok-clanker 2026-11-04 22:52:14 +00:00
commit 84475f03dd
1 changed files with 4 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Source/UI/Window/UIWindowMgr.cpp
View file

@ -915,7 +915,7 @@ UIWindowMgr::UIWindowMgr()
// OFFSET: 0x007375E0
// FUNCTION: fn_07649
CMiniPartyWndAreaMgr::CMiniPartyWndAreaMgr() {
__declspec(noinline) CMiniPartyWndAreaMgr::CMiniPartyWndAreaMgr() {
SetRect(&this->area, 0, 0, g_windowMgr.unknown_047C, g_windowMgr.unknown_0480);
}
@ -1245,7 +1245,7 @@ void UIWindowMgr::RefreshFrameSkins() {
// OFFSET: 0x00A8B840
// FUNCTION: fn_17124
void UIWindowMgr::RegisterNamedWindow(std::string name, UIWindow* window) {
__declspec(noinline) void UIWindowMgr::RegisterNamedWindow(std::string name, UIWindow* window) {
if (this->namedWindows.find(name) == this->namedWindows.end()) {
this->namedWindows[name] = window;
}
@ -1295,7 +1295,7 @@ void UIWindowMgr::AddRenderedFront(UIWindow* window) {
// OFFSET: 0x00A8C150
// FUNCTION: fn_17129
void UIWindowMgr::ShowWindows189(unsigned char show) {
__declspec(noinline) void UIWindowMgr::ShowWindows189(unsigned char show) {
for (auto it = this->rendered.begin(); it != this->rendered.end(); ++it) {
if ((*it)->geometry.id != 189) {
continue;
@ -1938,7 +1938,7 @@ int UIWindowMgr::SendNotice(int selector, std::intptr_t a, std::intptr_t b, std:
// OFFSET: 0x00AA8F50
// FUNCTION: fn_17252
void UIWindowMgr::BroadcastMessage21() {
__declspec(noinline) void UIWindowMgr::BroadcastMessage21() {
UIWindow* window = this->window_03DC;
if (window || (window = this->unknown_03B0) != nullptr) {
window->SendMsg(nullptr, 21, 0, 0, 0, 0);