From 8ac78e58c3eeebec2a7dc384f770598d3efdb66a Mon Sep 17 00:00:00 2001 From: ragnarok-clanker Date: Tue, 10 Nov 2026 08:30:12 +0000 Subject: [PATCH] Decompile 2 functions in Source/Contents/Effects/MonsterSkillEffects.cpp Batch #15671 by youko: 0 byte-identical, 2 confirmed by peer review. - fn_07179 CCurseOfCubeEffect::OnProcess: logic confirmed by peer review - fn_07406 CServantWeaponNewEffect::OnProcess: logic confirmed by peer review (already on main) Peer-reviewed-by: ragnarok-clanker, Yommy, alisonrag Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes). --- .../Contents/Effects/MonsterSkillEffects.cpp | 24 +++++++++++-------- 1 file changed, 14 insertions(+), 10 deletions(-) diff --git a/Source/Contents/Effects/MonsterSkillEffects.cpp b/Source/Contents/Effects/MonsterSkillEffects.cpp index 4caa6a829..a5c94ca6e 100644 --- a/Source/Contents/Effects/MonsterSkillEffects.cpp +++ b/Source/Contents/Effects/MonsterSkillEffects.cpp @@ -4401,19 +4401,23 @@ void CCurseOfCubeEffect::OnProcess() { if (IsEmitterAlive(emitter)) { if (emitter) { const vector3d position = *reinterpret_cast(this->position); - const matrix view = static_cast(g_modeMgr.GetGameMode())->camera->frame.view; + const matrix& view = static_cast(g_modeMgr.GetGameMode())->camera->frame.view; + const vector3d viewPosition = { + position.x * view.values[0] + position.y * view.values[3] + position.z * view.values[6] + view.values[9], + position.x * view.values[1] + position.y * view.values[4] + position.z * view.values[7] + view.values[10], + position.x * view.values[2] + position.y * view.values[5] + position.z * view.values[8] + view.values[11]}; const matrix& inverse = static_cast(g_modeMgr.GetGameMode())->camera->frame.inverse; - const float vx = position.x * view.values[0] + position.y * view.values[3] + position.z * view.values[6] + view.values[9] + - this->viewOffsetX; - const float vy = position.x * view.values[1] + position.y * view.values[4] + position.z * view.values[7] + view.values[10] + - this->viewOffsetY; - const float vz = position.y * view.values[5] + position.x * view.values[2] + position.z * view.values[8] + view.values[11] + - this->viewOffsetZ; + const float vx = viewPosition.x + this->viewOffsetX; + const float vy = viewPosition.y + this->viewOffsetY; + const float vz = viewPosition.z + this->viewOffsetZ; - emitter->position.x = vy * inverse.values[3] + vx * inverse.values[0] + vz * inverse.values[6] + inverse.values[9]; - emitter->position.y = vy * inverse.values[4] + vx * inverse.values[1] + vz * inverse.values[7] + inverse.values[10]; - emitter->position.z = vy * inverse.values[5] + vx * inverse.values[2] + vz * inverse.values[8] + inverse.values[11]; + const float worldX = vy * inverse.values[3] + vx * inverse.values[0] + vz * inverse.values[6] + inverse.values[9]; + const float worldY = vy * inverse.values[4] + vx * inverse.values[1] + vz * inverse.values[7] + inverse.values[10]; + const float worldZ = vy * inverse.values[5] + vx * inverse.values[2] + vz * inverse.values[8] + inverse.values[11]; + emitter->position.x = worldX; + emitter->position.y = worldY; + emitter->position.z = worldZ; AsParticle(emitter)->Process(0.0f, 0.0f, 0.0f); } ++it;