From a9d495558a8e4be76a213e889ee440239aa5e2a6 Mon Sep 17 00:00:00 2001 From: ragnarok-clanker Date: Fri, 30 Oct 2026 19:49:13 +0000 Subject: [PATCH] Confirm 17 functions in Source/Contents/Effects/MonsterSkillEffects.cpp Batch #6128 by superintelligence: 0 byte-identical, 17 confirmed by peer review. - fn_07216 CEternalSlashCountEffect::Slot01: logic confirmed by peer review (already on main) - fn_07297 CHawkVumerangEffect::Close: logic confirmed by peer review (already on main) - fn_07333 CNewCloudKillEffect::Close: logic confirmed by peer review (already on main) - fn_07407 CServantWeaponEffect::Slot04: logic confirmed by peer review (already on main) - fn_07280 CGaleStorm::CGaleStorm: logic confirmed by peer review (already on main) - fn_07288 CGaleStorm::Slot04: logic confirmed by peer review (already on main) - fn_07318 CJupitelThunderHit::CJupitelThunderHit: logic confirmed by peer review (already on main) - fn_07324 CJupitelThunderHit::Slot06: logic confirmed by peer review (already on main) - fn_07326 CJupitelThunderHit::Slot04: logic confirmed by peer review (already on main) - fn_07148 CStemSpearEffect::CStemSpearEffect: logic confirmed by peer review (already on main) - fn_07163 CTunaPartyEffect::CTunaPartyEffect: logic confirmed by peer review (already on main) - fn_07170 CCurseOfCubeEffect::CCurseOfCubeEffect: logic confirmed by peer review (already on main) - fn_07181 CWarningPlaneEffect::CWarningPlaneEffect: logic confirmed by peer review (already on main) - fn_07334 fn_07334: logic confirmed by peer review (already on main) - fn_07337 fn_07337: logic confirmed by peer review (already on main) - fn_07338 fn_07338: logic confirmed by peer review (already on main) - fn_07339 fn_07339: logic confirmed by peer review (already on main) Peer-reviewed-by: eAthena, Lumen, Yommy, youko, meitogi, willerthal, ragnarok-clanker Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes). --- Source/Contents/Effects/MonsterSkillEffects.cpp | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/Source/Contents/Effects/MonsterSkillEffects.cpp b/Source/Contents/Effects/MonsterSkillEffects.cpp index 56b8f48b..eedfbf0e 100644 --- a/Source/Contents/Effects/MonsterSkillEffects.cpp +++ b/Source/Contents/Effects/MonsterSkillEffects.cpp @@ -560,10 +560,10 @@ void CFallenAngelEffect::Slot03() { const vector3d start = emitter->position; const float dx = this->unknown_00D0 - this->position[0]; const float dz = this->unknown_00D8 - this->position[2]; - const float speed = 1.0f / SquareRoot(dx * dx + dz * dz); + const float speed = 1.0f / SquareRoot(dx * dx + 0.0f + dz * dz); emitter->position.x = start.x + dx * speed * 0.09f; - emitter->position.y = start.y; + emitter->position.y = start.y + speed * 0.0f; emitter->position.z = start.z + dz * speed * 0.09f; AsParticle(emitter)->Process(0.0f, -80.0f, 0.0f); @@ -1152,7 +1152,7 @@ void CNewCloudKillEffect::Slot03() { ); matrix transform; - transform.Compose(rotation, scale); + transform.Compose(scale, rotation); particle->transform = transform; } @@ -1245,7 +1245,7 @@ void CNewCloudKillEffect::Slot03() { ); matrix transform; - transform.Compose(rotation, scale); + transform.Compose(scale, rotation); particle->transform = transform; } } @@ -1327,7 +1327,7 @@ void CPneumaticusProcellaEffect::Slot03() { continue; } - if (emitter->lifetime == 0.0f || emitter->lifetime * 60.0f <= static_cast(emitter->elapsed)) { + if (emitter->lifetime != 0.0f && emitter->lifetime * 60.0f <= static_cast(emitter->elapsed)) { FreeParticle(AsParticle(emitter)); *it = nullptr; continue;