clank/rodecomp
1
0
Fork 0
Code Issues Wiki Activity

Maintenance: [forced, user-approved] Family V5: remove invented helper types that exist only to call real methods under old sub_ name

Browse source 
Batch #10281 by ragnarok-clanker: forced by an admin (1 lower score(s), 10 changed function(s)); checked with 6 compiled unit(s).
This commit is contained in:
ragnarok-clanker 2026-11-03 16:16:57 +00:00
commit ab4ef21fb8
6 changed files with 16 additions and 52 deletions
Download patch file Download diff file Expand all files Collapse all files

5
Source/UI/Window/UIWindowMgr.cpp
View file

@ -85,9 +85,6 @@ static_assert(sizeof(AddFriendPacket) == 26);
static_assert(offsetof(AddFriendPacket, name) == 2);
}
struct SessionCommandTarget {
int sub_DE1010(const char* name, int* optionId, std::string* strings);
};
// GLOBAL: gl_24525
CMiniPartyWndAreaMgr* g_miniPartyWndAreaMgr = nullptr;
@ -1478,7 +1475,7 @@ void UIWindowMgr::SendEmotionHotkey(int index) {
if (g_session.ProcessEmotionShortcut(text) == 0) {
std::string parts[3];
int talkType;
const int offset = reinterpret_cast<SessionCommandTarget*>(&g_session)->sub_DE1010(text, &talkType, parts);
const int offset = g_session.GetTalkType(text, &talkType, parts);
if (offset != -1) {
g_windowMgr.unknown_04DC = text + offset;
}