clank/rodecomp
1
0
Fork 0
Code Issues Wiki Activity

Confirm 2 functions in Source/Contents/Skills/SkillInfo.cpp, Source/Contents/Skills/SkillInfo.h

Browse source 
Batch #11743 by StrawberrysherbetIX: 1 byte-identical, 1 confirmed by peer review.

- fn_08322 IsSupportSkill: byte-identical (already on main)
- fn_11732 CSkillInfo::MatchesShortcut: logic confirmed by peer review (already on main)

Peer-reviewed-by: Yommy, dori, cremane
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
This commit is contained in:
ragnarok-clanker 2026-11-05 04:36:16 +00:00
commit b3f2ac575e
1 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Source/Contents/Skills/SkillInfo.h
View file

@ -112,7 +112,7 @@ public:
CSkillInfo(const CSkillInfo& other);
CSkillInfo& operator=(const CSkillInfo& other);
virtual ~CSkillInfo();
bool IsValid() const;
__declspec(noinline) bool IsValid() const;
bool MatchesShortcut(const NormalItemSlot* slot) const;
int UseApAmount(LuaScript& script, int skillLevel) const;
int UseSpAmount(LuaScript& script, int skillLevel) const;
@ -151,7 +151,7 @@ public:
static CSkillActionMgr* GetInstance();
bool IsSupportAction(int skillId);
__declspec(noinline) bool IsSupportAction(int skillId);
std::pair<bool, int> ActionSlot01(int skillId);
std::pair<bool, int> ActionSlot02(int skillId);
int ActionSlot14(int skillId);