Decompile 10 functions in Source/Render/DX9/RendererDX9Operations.cpp, Source/Utility/Text/StringUtil.cpp, ...

Batch #13116 by KWDev: 10 byte-identical, 0 confirmed by peer review.

- fn_02239 CRendererDX9::SetLighting: byte-identical
- fn_02757 CountCharacters: byte-identical
- fn_03898 UIChangeMaterialWnd_List::ShiftSelectedIndex: byte-identical
- fn_04317 UIReputeWnd::SetPage: byte-identical
- fn_09718 CSnapMgr::MoveConnected: byte-identical
- fn_09918 UIRefining_Notice::Slot19: byte-identical
- fn_10838 UIBitmapTab::Slot25: byte-identical
- fn_17501 C3dActor::SetSpeed: byte-identical
- fn_18836 CParticle::SetQuad: byte-identical
- fn_19338 ReplayFileList::Select: byte-identical

Merged automatically: every function is byte-identical to the original.

Source/Client/Replay.cpp

@@ -764,7 +764,7 @@ bool ReplayFileList::Select(int index) {
 
   const int count = static_cast<int>(this->files.size());
 
-  if (index >= count) {
+  if (count <= index) {
     index = count - 1;
   }
 

Source/Contents/Effects/Particle.cpp

@@ -796,9 +796,9 @@ void CParticle::SetQuad(RenderVertex* vertices, float top, float bottom, float l
   vertices[2].diffuse = color;
   vertices[3].diffuse = color;
 
+  vertices[0].u = left;
   vertices[0].v = top;
   vertices[1].v = top;
-  vertices[0].u = left;
   vertices[1].u = right;
   vertices[2].u = left;
   vertices[2].v = bottom;

Source/Contents/Models/ModelActor.cpp

@@ -182,7 +182,7 @@ void C3dActorV2::Animate(double frame) {
 void C3dActor::SetSpeed(float speed) {
   this->speed = speed;
 
-  if (speed != 0.0f) {
+  if (0.0f != speed) {
     this->speed = speed / 3.0f;
   }
 }

Source/Render/DX9/RendererDX9Operations.cpp

@@ -35,8 +35,8 @@ void CRendererDX9::SetLighting(const float* direction, const float* diffuse, con
   light.Diffuse.a = 255.0f;
   light.Ambient.r = ambient[0];
   light.Ambient.g = ambient[1];
-  light.Ambient.b = ambient[2];
   light.Ambient.a = 255.0f;
+  light.Ambient.b = ambient[2];
 
   this->nativeDevice->SetLight(0, &light);
   this->nativeDevice->LightEnable(0, TRUE);

Source/UI/Layout/SnapMgr.cpp

@@ -214,7 +214,7 @@ void CSnapMgr::ConstrainGroup(UIWindow* window, int& dx, int& dy) {
 // OFFSET: 0x007E3390
 // FUNCTION: fn_09718
 void CSnapMgr::MoveConnected(UIWindow* window, int dx, int dy) {
-  if (!this->root || this->root->window != window) {
+  if (!this->root || window != this->root->window) {
     return;
   }
 

Source/UI/UIChangeMaterialWnd.cpp

@@ -504,9 +504,9 @@ void UIChangeMaterialWnd_List::SortItems(bool ascending) {
 // FUNCTION: fn_03898
 void UIChangeMaterialWnd_List::ShiftSelectedIndex(int value) {
   const int index = static_cast<int>(std::max<int64_t>(0, this->m_selectedIndex - value));
-  if (index < this->m_scrollOffset || index >= this->m_scrollOffset + this->m_pageSize) {
+  if (index < this->m_scrollOffset || this->m_scrollOffset + this->m_pageSize <= index) {
     int newOffset = this->m_previousScrollOffset;
-    if (index < newOffset || index >= newOffset + this->m_pageSize) {
+    if (index < newOffset || newOffset + this->m_pageSize <= index) {
       newOffset = index > 0 ? index : 0;
     }
 

Source/UI/UIRefiningWnd.cpp

@@ -654,7 +654,7 @@ void UIRefiningWnd::Slot19() {
 // OFFSET: 0x007F7D80
 // FUNCTION: fn_09918
 void UIRefining_Notice::Slot19() {
-  if (this->expireTick != 0 && this->expireTick < timeGetTime()) {
+  if (this->expireTick != 0 && timeGetTime() > this->expireTick) {
     this->expireTick = 0;
     if (this->autoShown == 1) {
       this->autoShown = 0;

Source/UI/UIReputeWnd.cpp

@@ -342,7 +342,7 @@ void UIReputeWnd::SetPage(unsigned int page) {
 
   this->m_page = std::max(1u, std::min(this->m_pageCount, page));
   this->m_prevButton->Enable(this->m_page > 1);
-  this->m_nextButton->Enable(this->m_page < this->m_pageCount);
+  this->m_nextButton->Enable(this->m_pageCount > this->m_page);
 }
 
 // OFFSET: 0x00610C80

Source/UI/Window/UIBitmapTab.cpp

@@ -29,7 +29,7 @@ void UIBitmapTab::Slot25(int, int y) {
   int bottom = 0;
   for (unsigned index = 0; index < this->tabs.size(); ++index) {
     bottom += this->tabs[index].height;
-    if (bottom > y) {
+    if (y < bottom) {
       if (this->geometry.unknown_0030 != index) {
         this->geometry.unknown_0030 = index;
         this->Invalidate();

Source/Utility/Text/StringUtil.cpp

@@ -97,7 +97,7 @@ int CountCharacters(WORD codePage, const char* text, const char* end) {
   int count = 0;
   while (*text != '\0' && (end == nullptr || text < end)) {
     text = CharNextExA(codePage, text, 0);
-    if (end != nullptr && text > end) {
+    if (end != nullptr && end < text) {
       break;
     }
     ++count;