From e5d4b3b94c9ee8ace94ae32590c64fc12db034a7 Mon Sep 17 00:00:00 2001
From: ragnarok-clanker <ragnarok-clanker>
Date: Thu, 5 Nov 2026 16:54:18 +0000
Subject: [PATCH] Decompile fn_17510 (C3dActor::CopyVolumes)

Batch #12528 by cremane: 0 byte-identical, 1 confirmed by peer review.

- fn_17510 C3dActor::CopyVolumes: logic confirmed by peer review

Peer-reviewed-by: Yommy, gordaoprogramas, dori
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
---
 Source/Contents/Models/ModelActor.cpp | 6 ++++--
 Source/Contents/Models/ModelActor.h   | 2 +-
 2 files changed, 5 insertions(+), 3 deletions(-)

diff --git a/Source/Contents/Models/ModelActor.cpp b/Source/Contents/Models/ModelActor.cpp
index 462f5769..d1f278d1 100644
--- a/Source/Contents/Models/ModelActor.cpp
+++ b/Source/Contents/Models/ModelActor.cpp
@@ -220,8 +220,10 @@ C3dNode* C3dActorV2::Find(const char* name) {
 // OFFSET: 0x00AB94D0
 // FUNCTION: fn_17510
 void C3dActor::CopyVolumes(const std::list<ModelVolume*>& source) {
-  for (const ModelVolume* volume : source) {
-    this->volumes.push_back(new ModelVolume(*volume));
+  for (auto it = source.begin(); it != source.end(); ++it) {
+    ModelVolume* volume = new ModelVolume;
+    *volume = **it;
+    this->volumes.push_back(volume);
   }
 }
 
diff --git a/Source/Contents/Models/ModelActor.h b/Source/Contents/Models/ModelActor.h
index aa9a6230..f5139640 100644
--- a/Source/Contents/Models/ModelActor.h
+++ b/Source/Contents/Models/ModelActor.h
@@ -22,6 +22,7 @@ public:
   virtual void MarkOccluded(const float* ray);
   virtual void SetSpeed(float speed);
   void CopyVolumes(const std::list<ModelVolume*>& source);
+  void Fade();
 
   /* 0004 */ float position[3];
   /* 0010 */ float rotation[3];
@@ -50,7 +51,6 @@ public:
 
 protected:
   void FinishBounds(const float* bounds, bool modern);
-  void Fade();
   bool Reversed() const;
 };