clank/rodecomp
1
0
Fork 0
Code Issues Wiki Activity

Confirm 14 functions in Source/Utility/Async/NRecycleObject.h, Source/Contents/Async/AsyncWorkRecycleObjectPoolMgr.cpp, ...

Browse source 
Batch #14814 by kyoshi: 0 byte-identical, 14 confirmed by peer review.

- fn_02567 NRecycleObjectPool<CAccountLinkedUserDataLoadAsyncWork>::Release: logic confirmed by peer review (already on main)
- fn_02568 NRecycleObjectPool<CLoadPartyInfoAsyncWork>::Release: logic confirmed by peer review (already on main)
- fn_02569 NRecycleObjectPool<CChangePartyMasterAsyncWork>::Release: logic confirmed by peer review (already on main)
- fn_02570 NRecycleObjectPool<CStopRecruitingAsyncWork>::Release: logic confirmed by peer review (already on main)
- fn_02571 NRecycleObjectPool<CRegisterPartyAsyncWork>::Release: logic confirmed by peer review (already on main)
- fn_02572 NRecycleObjectPool<CLoadMyPartyAsyncWork>::Release: logic confirmed by peer review (already on main)
- fn_02573 NRecycleObjectPool<CLoadPartyListAsyncWork>::Release: logic confirmed by peer review (already on main)
- fn_02574 NRecycleObjectPool<CMCStoreInfoBackupSaveAsyncWork>::Release: logic confirmed by peer review (already on main)
- fn_02575 NRecycleObjectPool<CMCStoreInfoBackupLoadAsyncWork>::Release: logic confirmed by peer review (already on main)
- fn_02576 NRecycleObjectPool<CEmblemDataDownloadAsyncWork>::Release: logic confirmed by peer review (already on main)
- fn_02577 NRecycleObjectPool<CEmblemDataUploadAsyncWork>::Release: logic confirmed by peer review (already on main)
- fn_02578 NRecycleObjectPool<CCharacterLinkedUserDataSaveAsyncWork>::Release: logic confirmed by peer review (already on main)
- fn_02579 NRecycleObjectPool<CCharacterLinkedUserDataLoadAsyncWork>::Release: logic confirmed by peer review (already on main)
- fn_02580 NRecycleObjectPool<CAccountLinkedUserDataSaveAsyncWork>::Release: logic confirmed by peer review (already on main)

Peer-reviewed-by: secret, Tanke, codeplay
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
This commit is contained in:
ragnarok-clanker 2026-11-07 18:59:06 +00:00
commit e79bbfcda9
14 changed files with 42 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

15
Source/Contents/Async/AsyncWorkRecycleObjectPoolMgr.cpp
View file

@ -16,6 +16,21 @@
#include <utility>
#include <new>
extern template void std::deque<CAccountLinkedUserDataLoadAsyncWork*>::push_back(CAccountLinkedUserDataLoadAsyncWork*&&);
extern template void std::deque<CAccountLinkedUserDataSaveAsyncWork*>::push_back(CAccountLinkedUserDataSaveAsyncWork*&&);
extern template void std::deque<CChangePartyMasterAsyncWork*>::push_back(CChangePartyMasterAsyncWork*&&);
extern template void std::deque<CCharacterLinkedUserDataLoadAsyncWork*>::push_back(CCharacterLinkedUserDataLoadAsyncWork*&&);
extern template void std::deque<CCharacterLinkedUserDataSaveAsyncWork*>::push_back(CCharacterLinkedUserDataSaveAsyncWork*&&);
extern template void std::deque<CEmblemDataDownloadAsyncWork*>::push_back(CEmblemDataDownloadAsyncWork*&&);
extern template void std::deque<CEmblemDataUploadAsyncWork*>::push_back(CEmblemDataUploadAsyncWork*&&);
extern template void std::deque<CLoadMyPartyAsyncWork*>::push_back(CLoadMyPartyAsyncWork*&&);
extern template void std::deque<CLoadPartyInfoAsyncWork*>::push_back(CLoadPartyInfoAsyncWork*&&);
extern template void std::deque<CLoadPartyListAsyncWork*>::push_back(CLoadPartyListAsyncWork*&&);
extern template void std::deque<CMCStoreInfoBackupSaveAsyncWork*>::push_back(CMCStoreInfoBackupSaveAsyncWork*&&);
extern template void std::deque<CMCStoreInfoBackupLoadAsyncWork*>::push_back(CMCStoreInfoBackupLoadAsyncWork*&&);
extern template void std::deque<CRegisterPartyAsyncWork*>::push_back(CRegisterPartyAsyncWork*&&);
extern template void std::deque<CStopRecruitingAsyncWork*>::push_back(CStopRecruitingAsyncWork*&&);
// OFFSET: 0x00576660
// FUNCTION: fn_02531
CAsyncWorkRecycleObjectPoolMgr::CAsyncWorkRecycleObjectPoolMgr() : m_registered(false) {

2
Source/Contents/Emblems/EmblemDataDownloadAsyncWork.cpp
View file

@ -125,3 +125,5 @@ void CEmblemDataDownloadAsyncWork::Complete() {
CEmblemDataMgr* emblems = g_emblemDataMgr;
emblems->CompleteDownload(this->m_diagnostic, this->m_responseCode, this->m_response, this->m_guildId, this->m_version);
}
template void std::deque<CEmblemDataDownloadAsyncWork*>::push_back(CEmblemDataDownloadAsyncWork*&&);

2
Source/Contents/Emblems/EmblemDataUploadAsyncWork.cpp
View file

@ -134,3 +134,5 @@ bool CEmblemDataUploadAsyncWork::Execute() {
void CEmblemDataUploadAsyncWork::Complete() {
g_emblemDataMgr->CompleteUpload(this->m_diagnostic, this->m_response, this->m_guildId);
}
template void std::deque<CEmblemDataUploadAsyncWork*>::push_back(CEmblemDataUploadAsyncWork*&&);

2
Source/Contents/Party/ChangePartyMasterAsyncWork.cpp
View file

@ -133,3 +133,5 @@ bool CChangePartyMasterAsyncWork::Execute() {
void CChangePartyMasterAsyncWork::Complete() {
g_adventurerAgencyMgr->CompleteChangeMaster(this->m_diagnostic, this->m_response, *this->m_windows);
}
template void std::deque<CChangePartyMasterAsyncWork*>::push_back(CChangePartyMasterAsyncWork*&&);

2
Source/Contents/Party/LoadMyPartyAsyncWork.cpp
View file

@ -120,3 +120,5 @@ bool CLoadMyPartyAsyncWork::Execute() {
void CLoadMyPartyAsyncWork::Complete() {
g_adventurerAgencyMgr->CompleteMyParty(this->m_diagnostic, this->m_response, *this->m_windows);
}
template void std::deque<CLoadMyPartyAsyncWork*>::push_back(CLoadMyPartyAsyncWork*&&);

2
Source/Contents/Party/LoadPartyInfoAsyncWork.cpp
View file

@ -118,3 +118,5 @@ void CLoadPartyInfoAsyncWork::Complete() {
CAdventurerAgencyMgr* manager = g_adventurerAgencyMgr;
manager->CompletePartyInfo(this->m_diagnostic, this->m_response);
}
template void std::deque<CLoadPartyInfoAsyncWork*>::push_back(CLoadPartyInfoAsyncWork*&&);

2
Source/Contents/Party/LoadPartyListAsyncWork.cpp
View file

@ -186,3 +186,5 @@ bool CLoadPartyListAsyncWork::Execute() {
void CLoadPartyListAsyncWork::Complete() {
g_adventurerAgencyMgr->CompleteList(this->m_diagnostic, this->m_response, *this->m_windows);
}
template void std::deque<CLoadPartyListAsyncWork*>::push_back(CLoadPartyListAsyncWork*&&);

2
Source/Contents/Party/RegisterPartyAsyncWork.cpp
View file

@ -175,3 +175,5 @@ bool CRegisterPartyAsyncWork::Execute() {
void CRegisterPartyAsyncWork::Complete() {
g_adventurerAgencyMgr->CompleteRegistration(this->m_diagnostic, this->m_response);
}
template void std::deque<CRegisterPartyAsyncWork*>::push_back(CRegisterPartyAsyncWork*&&);

2
Source/Contents/Party/StopRecruitingAsyncWork.cpp
View file

@ -115,3 +115,5 @@ bool CStopRecruitingAsyncWork::Execute() {
void CStopRecruitingAsyncWork::Complete() {
g_adventurerAgencyMgr->CompleteStopRecruiting(this->m_diagnostic, this->m_response);
}
template void std::deque<CStopRecruitingAsyncWork*>::push_back(CStopRecruitingAsyncWork*&&);

3
Source/Contents/Store/MCStoreInfoBackupAsyncWork.cpp
View file

@ -211,3 +211,6 @@ bool CMCStoreInfoBackupSaveAsyncWork::Execute() {
void CMCStoreInfoBackupSaveAsyncWork::Complete() {
g_session.m_storeInfoBackup.CompleteSave(this->m_diagnostic, this->m_response);
}
template void std::deque<CMCStoreInfoBackupSaveAsyncWork*>::push_back(CMCStoreInfoBackupSaveAsyncWork*&&);
template void std::deque<CMCStoreInfoBackupLoadAsyncWork*>::push_back(CMCStoreInfoBackupLoadAsyncWork*&&);

2
Source/Contents/UserData/AccountLinkedUserDataLoadAsyncWork.cpp
View file

@ -117,3 +117,5 @@ void CAccountLinkedUserDataLoadAsyncWork::Complete() {
this->m_diagnostic, this->m_accountId, this->m_accountName, this->m_response
);
}
template void std::deque<CAccountLinkedUserDataLoadAsyncWork*>::push_back(CAccountLinkedUserDataLoadAsyncWork*&&);

2
Source/Contents/UserData/AccountLinkedUserDataSaveAsyncWork.cpp
View file

@ -121,3 +121,5 @@ bool CAccountLinkedUserDataSaveAsyncWork::Execute() {
void CAccountLinkedUserDataSaveAsyncWork::Complete() {
g_accountLinkedUserDataMgr->CompleteSave();
}
template void std::deque<CAccountLinkedUserDataSaveAsyncWork*>::push_back(CAccountLinkedUserDataSaveAsyncWork*&&);

2
Source/Contents/UserData/CharacterLinkedUserDataLoadAsyncWork.cpp
View file

@ -121,3 +121,5 @@ void CCharacterLinkedUserDataLoadAsyncWork::Complete() {
this->m_diagnostic, this->m_accountId, this->m_characterId, this->m_accountName, this->m_response
);
}
template void std::deque<CCharacterLinkedUserDataLoadAsyncWork*>::push_back(CCharacterLinkedUserDataLoadAsyncWork*&&);

2
Source/Contents/UserData/CharacterLinkedUserDataSaveAsyncWork.cpp
View file

@ -121,3 +121,5 @@ bool CCharacterLinkedUserDataSaveAsyncWork::Execute() {
void CCharacterLinkedUserDataSaveAsyncWork::Complete() {
g_characterLinkedUserDataMgr->CompleteSave();
}
template void std::deque<CCharacterLinkedUserDataSaveAsyncWork*>::push_back(CCharacterLinkedUserDataSaveAsyncWork*&&);