From ebdf746383a11f7e5112bd20c8af1baf1ba6b90a Mon Sep 17 00:00:00 2001 From: ragnarok-clanker Date: Tue, 10 Nov 2026 12:16:14 +0000 Subject: [PATCH] Decompile fn_21829 (CGameMode::ApplySkillUpdatePacket) Batch #15966 by Yommy: 0 byte-identical, 1 confirmed by peer review. - fn_21829 CGameMode::ApplySkillUpdatePacket: logic confirmed by peer review Peer-reviewed-by: eAthena, bgamez23 Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes). --- Source/Network/Packets/SkillUpdatePacket.cpp | 30 +++++++------------- 1 file changed, 10 insertions(+), 20 deletions(-) diff --git a/Source/Network/Packets/SkillUpdatePacket.cpp b/Source/Network/Packets/SkillUpdatePacket.cpp index d34ed0a05..9c4643257 100644 --- a/Source/Network/Packets/SkillUpdatePacket.cpp +++ b/Source/Network/Packets/SkillUpdatePacket.cpp @@ -22,23 +22,17 @@ void CGameMode::ApplySkillUpdatePacket(const void* packet) { *reinterpret_cast(&this->equipmentRequestState[0x0C]) = 0; const auto* bytes = static_cast(packet); - const auto opcode = Read(bytes); - const auto id = Read(bytes + 2); CSkillInfo value; - switch (opcode) { - case ID_ZC_SKILLINFO_UPDATE: - value = g_session.m_skillBundle.Lookup(id); - break; - case ID_ZC_HOSKILLINFO_UPDATE: - value = g_session.LookupHomunSkill(id); - break; - case ID_ZC_MER_SKILLINFO_UPDATE: - value = g_session.LookupMercSkill(id); - break; + if (Read(bytes) == ID_ZC_SKILLINFO_UPDATE) { + value = g_session.m_skillBundle.Lookup(Read(bytes + 2)); + } else if (Read(bytes) == ID_ZC_HOSKILLINFO_UPDATE) { + value = g_session.LookupHomunSkill(Read(bytes + 2)); + } else if (Read(bytes) == ID_ZC_MER_SKILLINFO_UPDATE) { + value = g_session.LookupMercSkill(Read(bytes + 2)); } - value.id = id; + value.id = Read(bytes + 2); value.level = Read(bytes + 4); value.spCost = static_cast(Read(bytes + 6)); value.upgradable = bytes[10]; @@ -46,16 +40,12 @@ void CGameMode::ApplySkillUpdatePacket(const void* packet) { value.apCost = value.UseApAmount(*g_session.m_hotkeyScript, value.level); g_session.m_skillBundle.ApplyLevelChange(value); - switch (opcode) { - case ID_ZC_SKILLINFO_UPDATE: + if (Read(bytes) == ID_ZC_SKILLINFO_UPDATE) { g_session.UpdateSkill(value, 1, 0); - break; - case ID_ZC_HOSKILLINFO_UPDATE: + } else if (Read(bytes) == ID_ZC_HOSKILLINFO_UPDATE) { g_session.UpdateHomunSkill(value, 1); - break; - case ID_ZC_MER_SKILLINFO_UPDATE: + } else if (Read(bytes) == ID_ZC_MER_SKILLINFO_UPDATE) { g_session.UpdateMercSkill(value, 1); - break; } }