clank/rodecomp
1
0
Fork 0
Code Issues Wiki Activity

Maintenance: Rename placeholder sub_XXXXXX functions to evidence-based names (Lua registration strings, log/error strings, packet ids

Browse source 
Batch #13412 by ragnarok-clanker: no function's compiled code changes; checked with 592 compiled unit(s), including every includer of Source/Client/Mode/CGameMode.h, Source/Client/Session.h, Source/Contents/Actors/GameActor.h, Source/Contents/CashEmotionMgr.h, Source/Contents/ClientItemLists.h, Source/Contents/ClientState.h, Source/Contents/Configuration/GameSettingsMgr.h, Source/Contents/Items/ItemInfo.h, Source/Contents/NavigationManager.h, Source/Contents/RenewQuestMgr.h, Source/Contents/ReputeMgr.h, Source/Contents/Schedule/TimeScheduler.h, Source/Contents/WorldView/WorldViewData.h, Source/UI/Buttons/UIDescriptRace.h, Source/UI/CashEmotion/UICashEmotionListWnd.h, Source/UI/Dialogs/UIPasswordWnd.h, Source/UI/Edit/UIEditCtrl.h, Source/UI/Edit/UIItemTagCtrl.h, Source/UI/GameSettings/GameSettingsUI.h, Source/UI/Item/UIItemStoreSubWnd.h, Source/UI/Items/UISwapEquipmentWnd.h, Source/UI/Lists/UIChatHisBox.h, Source/UI/Lists/UITagListBox.h, Source/UI/Quest/UIOngoingQuestInfo.h, Source/UI/Quest/UIRenewQuestUI.h, Source/UI/Rodex/UIRodexComposeWnd.h, Source/UI/Text/UIAchWnd.h, Source/UI/UIGradeEnchantWnd.h, Source/UI/UIIngredientInfoWnd.h, Source/UI/UIMacroUserInfoWnd.h, Source/UI/Window/UINewSkillListWnd.h, Source/UI/Window/UIRegisterMgr.h, Source/UI/Window/UIWindow.h, Source/UI/Window/UIWindowMgr.h, Source/Utility/JsonCppLoader.h.
This commit is contained in:
ragnarok-clanker 2026-11-06 16:30:12 +00:00
commit f8d3e8622d
120 changed files with 991 additions and 993 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Source/Client/Session.cpp
View file

@ -2010,7 +2010,7 @@ void CSession::UpdateUnknown1708(int enabled) {
// OFFSET: 0x00DFF150
// FUNCTION: fn_23611
void __fastcall sub_DFF150(CSession*) {
void __fastcall RefreshPartyWindows(CSession*) {
if (UIWindow* window = g_windowMgr.window_02C8) {
window->SendMsg(nullptr, 23, 0, 0, 0, 0);
}
@ -2662,7 +2662,7 @@ bool CSession::HasControlCharacter(std::string text) {
// OFFSET: 0x00DE3D90
// FUNCTION: fn_23488
void CSession::sub_DE3D90(char* text) {
void CSession::HiFriends(char* text) {
std::string greeting = "(Hi) ";
greeting += text ? text : "*^_^*";
@ -6998,7 +6998,7 @@ void CSession::ReloadLanguageTables() {
// OFFSET: 0x00DF33B0
// FUNCTION: fn_23506
void CSession::sub_DF33B0() {
void CSession::LoadSessionTables() {
CSession* session = this;
++g_sessionTableLoadCount;
session->InitJobHitWaveNames();