clank/rodecomp
1
0
Fork 0
Code Issues Wiki Activity

Maintenance: Rename placeholder sub_XXXXXX functions to evidence-based names (Lua registration strings, log/error strings, packet ids

Browse source 
Batch #13412 by ragnarok-clanker: no function's compiled code changes; checked with 592 compiled unit(s), including every includer of Source/Client/Mode/CGameMode.h, Source/Client/Session.h, Source/Contents/Actors/GameActor.h, Source/Contents/CashEmotionMgr.h, Source/Contents/ClientItemLists.h, Source/Contents/ClientState.h, Source/Contents/Configuration/GameSettingsMgr.h, Source/Contents/Items/ItemInfo.h, Source/Contents/NavigationManager.h, Source/Contents/RenewQuestMgr.h, Source/Contents/ReputeMgr.h, Source/Contents/Schedule/TimeScheduler.h, Source/Contents/WorldView/WorldViewData.h, Source/UI/Buttons/UIDescriptRace.h, Source/UI/CashEmotion/UICashEmotionListWnd.h, Source/UI/Dialogs/UIPasswordWnd.h, Source/UI/Edit/UIEditCtrl.h, Source/UI/Edit/UIItemTagCtrl.h, Source/UI/GameSettings/GameSettingsUI.h, Source/UI/Item/UIItemStoreSubWnd.h, Source/UI/Items/UISwapEquipmentWnd.h, Source/UI/Lists/UIChatHisBox.h, Source/UI/Lists/UITagListBox.h, Source/UI/Quest/UIOngoingQuestInfo.h, Source/UI/Quest/UIRenewQuestUI.h, Source/UI/Rodex/UIRodexComposeWnd.h, Source/UI/Text/UIAchWnd.h, Source/UI/UIGradeEnchantWnd.h, Source/UI/UIIngredientInfoWnd.h, Source/UI/UIMacroUserInfoWnd.h, Source/UI/Window/UINewSkillListWnd.h, Source/UI/Window/UIRegisterMgr.h, Source/UI/Window/UIWindow.h, Source/UI/Window/UIWindowMgr.h, Source/Utility/JsonCppLoader.h.
This commit is contained in:
ragnarok-clanker 2026-11-06 16:30:12 +00:00
commit f8d3e8622d
120 changed files with 991 additions and 993 deletions
Download patch file Download diff file Expand all files Collapse all files

14
Source/Contents/Actors/RenderObject.cpp
View file

@ -2402,7 +2402,7 @@ void CGameActor::LaunchAttackProjectile(int target, float scale) {
case 0x57F8:
case 0x5800:
case 0x5812:
sub_CDBC30(&this->render.position, target, scale, this->GetEffectiveJob(-1));
LaunchBulletSpriteEffect(&this->render.position, target, scale, this->GetEffectiveJob(-1));
return;
default:
return;
@ -4346,7 +4346,7 @@ __declspec(noinline) bool __stdcall IsTreeGroupThreeLocal(int job) {
// OFFSET: 0x00CAA4D0
// FUNCTION: fn_21017
void CGameActor::sub_CAA4D0() {
void CGameActor::UpdateMaxLevelAura() {
if (g_serviceOptions.Get(0x6b) != 0) {
return;
}
@ -4533,7 +4533,7 @@ void CGameActor::SetActorJob(int job) {
this->Slot21(slotJob);
this->ResetJobEffects();
this->sub_CAA4D0();
this->UpdateMaxLevelAura();
}
// OFFSET: 0x00CAAFD0
@ -4593,7 +4593,7 @@ void C3dGrannyGameActor::SpawnCorpseActor() {
// OFFSET: 0x00CC40D0
// FUNCTION: fn_21158
void CGameActor::sub_CC40D0() {
void CGameActor::ApplyNatureProtection() {
if (this->unknown_0404 == 3) {
return;
}
@ -4881,7 +4881,7 @@ void CGameActor::SetStatusStates(int bodyState, std::uint32_t stateFlags, int ef
}
this->RefreshGuildEmblemWindow();
if (this->unknown_02B4 != 0) {
this->sub_CAA4D0();
this->UpdateMaxLevelAura();
}
if (this->GetEffectiveJob(-1) == 45) {
this->LaunchEffect(321, vector3d{0.0f, 0.0f, 0.0f}, 0.0f);
@ -4932,7 +4932,7 @@ void CGameActor::SetStatusStates(int bodyState, std::uint32_t stateFlags, int ef
}
this->RefreshGuildEmblemWindow();
if (this->unknown_02B4 != 0) {
this->sub_CAA4D0();
this->UpdateMaxLevelAura();
}
}
}
@ -5025,7 +5025,7 @@ void CGameActor::SetStatusStates(int bodyState, std::uint32_t stateFlags, int ef
}
this->RefreshGuildEmblemWindow();
if (this->unknown_02B4 != 0) {
this->sub_CAA4D0();
this->UpdateMaxLevelAura();
}
}
}