clank/rodecomp
1
0
Fork 0
Code Issues Wiki Activity

Maintenance: Rename placeholder sub_XXXXXX functions to evidence-based names (Lua registration strings, log/error strings, packet ids

Browse source 
Batch #13412 by ragnarok-clanker: no function's compiled code changes; checked with 592 compiled unit(s), including every includer of Source/Client/Mode/CGameMode.h, Source/Client/Session.h, Source/Contents/Actors/GameActor.h, Source/Contents/CashEmotionMgr.h, Source/Contents/ClientItemLists.h, Source/Contents/ClientState.h, Source/Contents/Configuration/GameSettingsMgr.h, Source/Contents/Items/ItemInfo.h, Source/Contents/NavigationManager.h, Source/Contents/RenewQuestMgr.h, Source/Contents/ReputeMgr.h, Source/Contents/Schedule/TimeScheduler.h, Source/Contents/WorldView/WorldViewData.h, Source/UI/Buttons/UIDescriptRace.h, Source/UI/CashEmotion/UICashEmotionListWnd.h, Source/UI/Dialogs/UIPasswordWnd.h, Source/UI/Edit/UIEditCtrl.h, Source/UI/Edit/UIItemTagCtrl.h, Source/UI/GameSettings/GameSettingsUI.h, Source/UI/Item/UIItemStoreSubWnd.h, Source/UI/Items/UISwapEquipmentWnd.h, Source/UI/Lists/UIChatHisBox.h, Source/UI/Lists/UITagListBox.h, Source/UI/Quest/UIOngoingQuestInfo.h, Source/UI/Quest/UIRenewQuestUI.h, Source/UI/Rodex/UIRodexComposeWnd.h, Source/UI/Text/UIAchWnd.h, Source/UI/UIGradeEnchantWnd.h, Source/UI/UIIngredientInfoWnd.h, Source/UI/UIMacroUserInfoWnd.h, Source/UI/Window/UINewSkillListWnd.h, Source/UI/Window/UIRegisterMgr.h, Source/UI/Window/UIWindow.h, Source/UI/Window/UIWindowMgr.h, Source/Utility/JsonCppLoader.h.
This commit is contained in:
ragnarok-clanker 2026-11-06 16:30:12 +00:00
commit f8d3e8622d
120 changed files with 991 additions and 993 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Source/Contents/ClientItemLists.cpp
View file

@ -291,7 +291,7 @@ void CGameMode::ReceiveItem1738Add(const unsigned char* data) {
// OFFSET: 0x00D1F770
// FUNCTION: fn_21641
void sub_D1F770(const unsigned char* data) {
void ReceiveItemSlot(const unsigned char* data) {
const ItemAddSlotPacket* packet = reinterpret_cast<const ItemAddSlotPacket*>(data);
if (packet->slot < 0) {
g_modeMgr.gameMode->SendMsg(0x35, 0, 0, 0, 0);
@ -317,7 +317,7 @@ void sub_D1F770(const unsigned char* data) {
// OFFSET: 0x00D1F970
// FUNCTION: fn_21642
void sub_D1F970(const unsigned char* data) {
void ReceiveItemSlotOptions(const unsigned char* data) {
const ItemAddSlotOptionsPacket* packet = reinterpret_cast<const ItemAddSlotOptionsPacket*>(data);
if (packet->slot < 0) {
g_modeMgr.gameMode->SendMsg(0x35, 0, 0, 0, 0);
@ -369,7 +369,7 @@ void sub_D1F970(const unsigned char* data) {
// OFFSET: 0x00D1FBA0
// FUNCTION: fn_21643
void sub_D1FBA0(const unsigned char* data) {
void ReceiveFriendAddResult(const unsigned char* data) {
const FriendNoticePacket* packet = reinterpret_cast<const FriendNoticePacket*>(data);
char name[25];
std::memcpy(name, packet->name, 24);