clank/rodecomp
1
0
Fork 0
Code Issues Wiki Activity

Maintenance: Rename placeholder sub_XXXXXX functions to evidence-based names (Lua registration strings, log/error strings, packet ids

Browse source 
Batch #13412 by ragnarok-clanker: no function's compiled code changes; checked with 592 compiled unit(s), including every includer of Source/Client/Mode/CGameMode.h, Source/Client/Session.h, Source/Contents/Actors/GameActor.h, Source/Contents/CashEmotionMgr.h, Source/Contents/ClientItemLists.h, Source/Contents/ClientState.h, Source/Contents/Configuration/GameSettingsMgr.h, Source/Contents/Items/ItemInfo.h, Source/Contents/NavigationManager.h, Source/Contents/RenewQuestMgr.h, Source/Contents/ReputeMgr.h, Source/Contents/Schedule/TimeScheduler.h, Source/Contents/WorldView/WorldViewData.h, Source/UI/Buttons/UIDescriptRace.h, Source/UI/CashEmotion/UICashEmotionListWnd.h, Source/UI/Dialogs/UIPasswordWnd.h, Source/UI/Edit/UIEditCtrl.h, Source/UI/Edit/UIItemTagCtrl.h, Source/UI/GameSettings/GameSettingsUI.h, Source/UI/Item/UIItemStoreSubWnd.h, Source/UI/Items/UISwapEquipmentWnd.h, Source/UI/Lists/UIChatHisBox.h, Source/UI/Lists/UITagListBox.h, Source/UI/Quest/UIOngoingQuestInfo.h, Source/UI/Quest/UIRenewQuestUI.h, Source/UI/Rodex/UIRodexComposeWnd.h, Source/UI/Text/UIAchWnd.h, Source/UI/UIGradeEnchantWnd.h, Source/UI/UIIngredientInfoWnd.h, Source/UI/UIMacroUserInfoWnd.h, Source/UI/Window/UINewSkillListWnd.h, Source/UI/Window/UIRegisterMgr.h, Source/UI/Window/UIWindow.h, Source/UI/Window/UIWindowMgr.h, Source/Utility/JsonCppLoader.h.
This commit is contained in:
ragnarok-clanker 2026-11-06 16:30:12 +00:00
commit f8d3e8622d
120 changed files with 991 additions and 993 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Source/UI/Text/NavigationLink.cpp
View file

@ -1416,7 +1416,7 @@ int CCreateLineInfo::ParseItemName(int index) {
char name[260];
std::memset(name, 0, sizeof(name));
int capacity = sizeof(name);
item.sub_6D5810(name, capacity, 0);
item.GetIdDisplayName(name, capacity, 0);
this->AddSegment(LINE_SEGMENT_TEXT);
this->AppendText(std::string(name));
index += static_cast<int>(digits.size()) + 9;
@ -1770,7 +1770,7 @@ void OpenTextButtonNavigation(UITextButton* button) {
const int x = std::atoi(button->GetLine(1).c_str());
const int y = std::atoi(button->GetLine(2).c_str());
if (button->m_lines.size() <= 3) {
g_navigationManager.sub_B99030(name, 2, 5, false, x, y, 1002);
g_navigationManager.StartNavigation(name, 2, 5, false, x, y, 1002);
return;
}
@ -1783,7 +1783,7 @@ void OpenTextButtonNavigation(UITextButton* button) {
}
tag += name;
g_navigationManager.sub_B995D0(tag, mode, false);
g_navigationManager.SearchNavigation(tag, mode, false);
return;
}
@ -1798,7 +1798,7 @@ void OpenTextButtonNavigation(UITextButton* button) {
const unsigned char group = code < 10 ? hundreds : static_cast<unsigned char>(hundreds + 2);
const int remainder = code < 10 ? code : code - 10;
const unsigned char kind = remainder < 1 ? group : static_cast<unsigned char>(group + 4);
g_navigationManager.sub_B99030(name, mode, kind, flag == 0, x, y, id);
g_navigationManager.StartNavigation(name, mode, kind, flag == 0, x, y, id);
}
// OFFSET: 0x0083BAF0