clank/rodecomp
1
0
Fork 0
Code Issues Wiki Activity

Maintenance: Rename placeholder sub_XXXXXX functions to evidence-based names (Lua registration strings, log/error strings, packet ids

Browse source 
Batch #13412 by ragnarok-clanker: no function's compiled code changes; checked with 592 compiled unit(s), including every includer of Source/Client/Mode/CGameMode.h, Source/Client/Session.h, Source/Contents/Actors/GameActor.h, Source/Contents/CashEmotionMgr.h, Source/Contents/ClientItemLists.h, Source/Contents/ClientState.h, Source/Contents/Configuration/GameSettingsMgr.h, Source/Contents/Items/ItemInfo.h, Source/Contents/NavigationManager.h, Source/Contents/RenewQuestMgr.h, Source/Contents/ReputeMgr.h, Source/Contents/Schedule/TimeScheduler.h, Source/Contents/WorldView/WorldViewData.h, Source/UI/Buttons/UIDescriptRace.h, Source/UI/CashEmotion/UICashEmotionListWnd.h, Source/UI/Dialogs/UIPasswordWnd.h, Source/UI/Edit/UIEditCtrl.h, Source/UI/Edit/UIItemTagCtrl.h, Source/UI/GameSettings/GameSettingsUI.h, Source/UI/Item/UIItemStoreSubWnd.h, Source/UI/Items/UISwapEquipmentWnd.h, Source/UI/Lists/UIChatHisBox.h, Source/UI/Lists/UITagListBox.h, Source/UI/Quest/UIOngoingQuestInfo.h, Source/UI/Quest/UIRenewQuestUI.h, Source/UI/Rodex/UIRodexComposeWnd.h, Source/UI/Text/UIAchWnd.h, Source/UI/UIGradeEnchantWnd.h, Source/UI/UIIngredientInfoWnd.h, Source/UI/UIMacroUserInfoWnd.h, Source/UI/Window/UINewSkillListWnd.h, Source/UI/Window/UIRegisterMgr.h, Source/UI/Window/UIWindow.h, Source/UI/Window/UIWindowMgr.h, Source/Utility/JsonCppLoader.h.
This commit is contained in:
ragnarok-clanker 2026-11-06 16:30:12 +00:00
commit f8d3e8622d
120 changed files with 991 additions and 993 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Source/UI/Text/UITextViewer.cpp
View file

@ -116,7 +116,7 @@ void UIAchListWnd::Slot25(int x, int y) {
return;
}
this->sub_7B37F0(this->unknown_008C + row);
this->SelectAchievement(this->unknown_008C + row);
g_windowMgr.SetCapture(this);
}
@ -138,7 +138,7 @@ void UIAchTV::Slot25(int, int) {
void UIAchTab::Slot25(int x, int y) {
int a = 0;
int b = 0;
if (!this->sub_7B4370(x, y, &a, &b)) {
if (!this->HitTestTab(x, y, &a, &b)) {
return;
}
@ -149,7 +149,7 @@ void UIAchTab::Slot25(int x, int y) {
this->parent->Invalidate();
}
this->sub_7B7F10();
this->UpdateScrollBar();
this->Invalidate();
g_windowMgr.SetCapture(this);
}
@ -337,7 +337,7 @@ int UITextViewEX::SendMsg(UIWindow* sender, int message, std::intptr_t argument1
// OFFSET: 0x00874A40
// FUNCTION: fn_11193
std::string UIItemTagCtrl::sub_874A40(int tagId, unsigned int color) {
std::string UIItemTagCtrl::AddSkillTag(int tagId, unsigned int color) {
std::string label;
const std::string title = g_itemTagOwner->Title(tagId, &label, 17);