clank/rodecomp
1
0
Fork 0
Code Issues Wiki Activity

Maintenance: Rename placeholder sub_XXXXXX functions to evidence-based names (Lua registration strings, log/error strings, packet ids

Browse source 
Batch #13412 by ragnarok-clanker: no function's compiled code changes; checked with 592 compiled unit(s), including every includer of Source/Client/Mode/CGameMode.h, Source/Client/Session.h, Source/Contents/Actors/GameActor.h, Source/Contents/CashEmotionMgr.h, Source/Contents/ClientItemLists.h, Source/Contents/ClientState.h, Source/Contents/Configuration/GameSettingsMgr.h, Source/Contents/Items/ItemInfo.h, Source/Contents/NavigationManager.h, Source/Contents/RenewQuestMgr.h, Source/Contents/ReputeMgr.h, Source/Contents/Schedule/TimeScheduler.h, Source/Contents/WorldView/WorldViewData.h, Source/UI/Buttons/UIDescriptRace.h, Source/UI/CashEmotion/UICashEmotionListWnd.h, Source/UI/Dialogs/UIPasswordWnd.h, Source/UI/Edit/UIEditCtrl.h, Source/UI/Edit/UIItemTagCtrl.h, Source/UI/GameSettings/GameSettingsUI.h, Source/UI/Item/UIItemStoreSubWnd.h, Source/UI/Items/UISwapEquipmentWnd.h, Source/UI/Lists/UIChatHisBox.h, Source/UI/Lists/UITagListBox.h, Source/UI/Quest/UIOngoingQuestInfo.h, Source/UI/Quest/UIRenewQuestUI.h, Source/UI/Rodex/UIRodexComposeWnd.h, Source/UI/Text/UIAchWnd.h, Source/UI/UIGradeEnchantWnd.h, Source/UI/UIIngredientInfoWnd.h, Source/UI/UIMacroUserInfoWnd.h, Source/UI/Window/UINewSkillListWnd.h, Source/UI/Window/UIRegisterMgr.h, Source/UI/Window/UIWindow.h, Source/UI/Window/UIWindowMgr.h, Source/Utility/JsonCppLoader.h.
This commit is contained in:
ragnarok-clanker 2026-11-06 16:30:12 +00:00
commit f8d3e8622d
120 changed files with 991 additions and 993 deletions
Download patch file Download diff file Expand all files Collapse all files

14
Source/Utility/JsonCppLoader.cpp
View file

@ -107,7 +107,7 @@ struct JsonCppLoaderJsonOptionsGuard {
// OFFSET: 0x004F3CC0
// FUNCTION: fn_00487
bool JsonCppLoader::sub_4F3CC0(const std::string& path) {
bool JsonCppLoader::LoadBson(const std::string& path) {
try {
std::ifstream file(path.c_str(), std::ios::binary);
if (!file.is_open()) {
@ -134,7 +134,7 @@ bool JsonCppLoader::sub_4F3CC0(const std::string& path) {
// OFFSET: 0x004F3ED0
// FUNCTION: fn_00489
bool JsonCppLoader::sub_4F3ED0(const std::string& path) {
bool JsonCppLoader::LoadJson(const std::string& path) {
try {
std::ifstream file(path.c_str());
if (!file.is_open()) {
@ -161,7 +161,7 @@ bool JsonCppLoader::sub_4F3ED0(const std::string& path) {
// OFFSET: 0x004F3C70
// FUNCTION: fn_00486
bool JsonCppLoader::sub_4F3C70(std::vector<unsigned char>& buffer, bool bson) {
bool JsonCppLoader::Load(std::vector<unsigned char>& buffer, bool bson) {
if (buffer.empty()) {
this->Fail("error : JsonCppLoader::Load failed (reason : 비어있는 버퍼가 전달되었습니다.)");
return false;
@ -169,9 +169,9 @@ bool JsonCppLoader::sub_4F3C70(std::vector<unsigned char>& buffer, bool bson) {
bool parsed;
if (bson == true) {
parsed = this->sub_4F3DF0(buffer);
parsed = this->LoadBson(buffer);
} else {
parsed = this->sub_4F4040(buffer);
parsed = this->LoadJson(buffer);
}
if (parsed) {
@ -184,7 +184,7 @@ bool JsonCppLoader::sub_4F3C70(std::vector<unsigned char>& buffer, bool bson) {
// OFFSET: 0x004F3DF0
// FUNCTION: fn_00488
__declspec(noinline) bool JsonCppLoader::sub_4F3DF0(std::vector<unsigned char>& buffer) {
__declspec(noinline) bool JsonCppLoader::LoadBson(std::vector<unsigned char>& buffer) {
if (buffer.empty()) {
this->Fail("비어있는 버퍼가 전달되었습니다.");
return false;
@ -208,7 +208,7 @@ __declspec(noinline) bool JsonCppLoader::sub_4F3DF0(std::vector<unsigned char>&
// OFFSET: 0x004F4040
// FUNCTION: fn_00490
__declspec(noinline) bool JsonCppLoader::sub_4F4040(std::vector<unsigned char>& buffer) {
__declspec(noinline) bool JsonCppLoader::LoadJson(std::vector<unsigned char>& buffer) {
if (buffer.empty()) {
this->Fail("비어있는 버퍼가 전달되었습니다.");
return false;