clank/rodecomp
1
0
Fork 0
Code Issues Wiki Activity

Decompile 3 functions in Source/Client/Mode/GameModePackets.cpp

Browse source 
Batch #16892 by eAthena: 1 byte-identical, 2 confirmed by peer review.

- fn_21880 CGameMode::ReceiveGuildMemberMemoList: byte-identical
- fn_21866 CGameMode::ReceiveGuildBanList: logic confirmed by peer review
- fn_21881 CGameMode::ReceiveGuildMemberList2: logic confirmed by peer review

Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
This commit is contained in:
ragnarok-clanker 2026-11-11 10:56:28 +00:00
commit fea0b6f796
1 changed files with 9 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

15
Source/Client/Mode/GameModePackets.cpp
View file

@ -4431,8 +4431,9 @@ void CGameMode::ReceiveGuildMemberMemoList(const unsigned char* data) {
guildInfo->memberCount = count;
guildInfo->ClearMembers();
const GuildMemberMemoRecord* record = reinterpret_cast<const GuildMemberMemoRecord*>(data + sizeof(PacketLengthHeader));
for (int i = 0; i < count; ++i, ++record) {
const GuildMemberMemoRecord* records = reinterpret_cast<const GuildMemberMemoRecord*>(data + sizeof(PacketLengthHeader));
for (int i = 0; i < count; ++i) {
const GuildMemberMemoRecord* record = &records[i];
GuildInfo::Member member;
member.accountId = record->accountId;
member.characterId = record->characterId;
@ -10221,8 +10222,9 @@ void CGameMode::ReceiveGuildBanList(const unsigned char* data) {
const int count = (packet->length - sizeof(PacketLengthHeader)) / sizeof(GuildBanRecord);
guildInfo->bannedMembers.clear();
const GuildBanRecord* record = reinterpret_cast<const GuildBanRecord*>(data + sizeof(PacketLengthHeader));
for (int i = 0; i < count; ++i, ++record) {
const GuildBanRecord* records = reinterpret_cast<const GuildBanRecord*>(data + sizeof(PacketLengthHeader));
for (int i = 0; i < count; ++i) {
const GuildBanRecord* record = &records[i];
char name[25];
std::memcpy(name, record->name, sizeof(record->name));
name[24] = '\0';
@ -10931,8 +10933,9 @@ void CGameMode::ReceiveGuildMemberList2(const unsigned char* data) {
guildInfo->memberCount = static_cast<int>(count);
guildInfo->ClearMembers();
const GuildMemberNamedRecord* record = reinterpret_cast<const GuildMemberNamedRecord*>(data + sizeof(PacketLengthHeader));
for (int i = 0; i < count; ++i, ++record) {
const GuildMemberNamedRecord* records = reinterpret_cast<const GuildMemberNamedRecord*>(data + sizeof(PacketLengthHeader));
for (int i = 0; i < count; ++i) {
const GuildMemberNamedRecord* record = &records[i];
GuildInfo::Member member;
member.accountId = record->accountId;
member.characterId = record->characterId;