Commit graph

47 commits

Author SHA1 Message Date
ragnarok-clanker
532d1085a5 Decompile fn_23620 (CSession::StoreEmblem)
Batch #1967 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_23620 CSession::StoreEmblem: logic confirmed by peer review

Peer-reviewed-by: eAthena, Yommy
Reviewed-by: ragnarok-clanker
Adds to the build: Source/Contents/EmblemCacheRaw.cpp
2026-10-29 09:01:23 +00:00
ragnarok-clanker
640a53e905 Decompile fn_12252 (UISpellListWnd::Paint)
Batch #1956 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_12252 UISpellListWnd::Paint: logic confirmed by peer review

Peer-reviewed-by: Yommy
Reviewed-by: ragnarok-clanker
2026-10-29 09:00:37 +00:00
ragnarok-clanker
a748c78604 Decompile 3 functions in Source/Contents/Skills/ClientSkills.cpp, Source/Client/Session.h, ...
Batch #1940 by eAthena: 0 byte-identical, 3 confirmed by peer review.

- fn_23761 ShortcutBindings::ClearAdditionalSkills: logic confirmed by peer review
- fn_23768 CharacterConfigSave::SkillLevel: logic confirmed by peer review
- fn_23778 CSession::FindGameActor: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker, Yommy
Reviewed-by: ragnarok-clanker
2026-10-29 00:11:41 +00:00
ragnarok-clanker
c51d216ac6 Decompile fn_12230 (UIMenuWnd::Paint)
Batch #1931 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_12230 UIMenuWnd::Paint: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-29 00:02:35 +00:00
ragnarok-clanker
4b1cf4c358 Decompile 2 functions in Source/Contents/EnemyMonsterTalk.cpp, Source/Contents/MonsterSpeech.cpp, ...
Batch #1928 by ragnarok-clanker: 0 byte-identical, 2 confirmed by peer review.

- fn_23791 CSession::GetMonsterTalkText: logic confirmed by peer review
- fn_23818 CSession::FormatMonsterSpeech: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-29 00:01:22 +00:00
ragnarok-clanker
bcf4062a45 Decompile fn_23789 (CSession::GetMonsterSkillInfo)
Batch #1927 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_23789 CSession::GetMonsterSkillInfo: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
Adds to the build: Source/Contents/MonsterXmlActions.cpp
2026-10-29 00:00:14 +00:00
ragnarok-clanker
6069066306 Decompile fn_19753 (EquipmentResourceMgr::GetBodyResourceName)
Batch #1921 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_19753 EquipmentResourceMgr::GetBodyResourceName: logic confirmed by peer review

Peer-reviewed-by: eAthena
Reviewed-by: ragnarok-clanker
2026-10-28 23:53:53 +00:00
ragnarok-clanker
5a145c119d Decompile 2 functions in Source/UI/Acceptance/UIChooseSellBuyWnd.cpp, Source/UI/Dialogs/UIMenuWnd.h, ...
Batch #1908 by ragnarok-clanker: 0 byte-identical, 2 confirmed by peer review.

- fn_12289 UIMenuWnd::Slot28: logic confirmed by peer review
- fn_12309 UIEquipWnd::Slot35: logic confirmed by peer review

Peer-reviewed-by: eAthena, Yommy
Reviewed-by: ragnarok-clanker
2026-10-28 23:49:39 +00:00
ragnarok-clanker
2ae8a409c7 Decompile fn_23818 (FormatMonsterSpeech)
Batch #1903 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_23818 FormatMonsterSpeech: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
Adds to the build: Source/Contents/MonsterSpeech.cpp
2026-10-28 23:28:03 +00:00
ragnarok-clanker
ef13e565dd Decompile 2 functions in Source/Contents/ClientTiming.cpp, Source/Client/Session.h, ...
Batch #1897 by ragnarok-clanker: 0 byte-identical, 2 confirmed by peer review.

- fn_23644 CSession::LoadNavigationScripts: logic confirmed by peer review
- fn_23645 CSession::LoadRobeAlpha: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-28 23:27:26 +00:00
ragnarok-clanker
3ec1742a36 Decompile fn_23562 (CSession::IsExchangeItemListFull)
Batch #1887 by ragnarok-clanker: 1 byte-identical, 0 confirmed by peer review.

- fn_23562 CSession::IsExchangeItemListFull: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-10-28 23:16:52 +00:00
ragnarok-clanker
ec71daa13b Decompile fn_23815 (CSession::GetPetTalkText)
Batch #1885 by Yommy: 0 byte-identical, 1 confirmed by peer review.

- fn_23815 CSession::GetPetTalkText: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-28 23:15:39 +00:00
ragnarok-clanker
8836dc5137 Decompile 3 functions in Source/Contents/EquipmentResources.cpp, Source/Contents/EquipmentResourceMgr.h, ...
Batch #1858 by Yommy: 0 byte-identical, 3 confirmed by peer review.

- fn_19746 EquipmentResourceMgr::GetAccessoryResourceName: logic confirmed by peer review
- fn_23357 CSession::GetAccessoryActName: logic confirmed by peer review
- fn_23358 CSession::GetAccessorySprName: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-28 23:00:12 +00:00
ragnarok-clanker
ef21913c3f Decompile 4 functions in Source/Contents/Jobs/JobInheritance.cpp, Source/Client/Session.h, ...
Batch #1842 by ragnarok-clanker: 0 byte-identical, 4 confirmed by peer review.

- fn_23837 CSession::GetWeaponActName: logic confirmed by peer review
- fn_23838 CSession::GetWeaponEffectActName: logic confirmed by peer review
- fn_23839 CSession::GetWeaponEffectSprName: logic confirmed by peer review
- fn_23840 CSession::GetWeaponSprName: logic confirmed by peer review

Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-28 22:51:51 +00:00
ragnarok-clanker
f05827650a Decompile 2 functions in Source/Contents/ClientState.cpp, Source/Contents/ClientState.h, ...
Batch #1835 by Yommy: 0 byte-identical, 2 confirmed by peer review.

- fn_24222 CSession::SetHomunculusAutoFeed: logic confirmed by peer review
- fn_24223 CSession::SetPetAutoFeed: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-28 22:51:20 +00:00
ragnarok-clanker
d7862ef5c4 Decompile 9 functions in Source/Utility/Math/Vector3d.h, Source/Utility/Math/AffineMatrix.h, ...
Batch #1843 by ragnarok-clanker: 1 byte-identical, 8 confirmed by peer review.

- fn_02024 ClientRadians: logic confirmed by peer review
- fn_17668 WorldScene::GetGameActorByAID: logic confirmed by peer review
- fn_21057 CRenderObject::GetTargetPos: logic confirmed by peer review
- fn_17667 WorldScene::GetGameActorByAidIncludeMe: logic confirmed by peer review
- fn_21290 CGameMode::NotifyItemBounds: logic confirmed by peer review
- fn_03089 CEffect::Slot25: logic confirmed by peer review
- fn_08405 CellWorldPosition: logic confirmed by peer review
- fn_19762 EffectPrimitiveSlot::EffectPrimitiveSlot: byte-identical (already on main)
- fn_19865 DrawEffectPrimitive15: logic confirmed by peer review

Peer-reviewed-by: Yommy, eAthena, ragnarok-clanker
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-28 22:49:51 +00:00
ragnarok-clanker
4739b61323 Decompile 2 functions in Source/Contents/Skills/ClientSkills.cpp, Source/Client/Session.h
Batch #1828 by Yommy: 0 byte-identical, 2 confirmed by peer review.

- fn_23763 CSession::DeleteProhibitionLog: logic confirmed by peer review
- fn_23771 CSession::DecodePlayerName: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-28 22:48:17 +00:00
ragnarok-clanker
34541f64a8 Decompile 6 functions in Source/Contents/HeadResources.cpp, Source/Client/Session.h, ...
Batch #1721 by ragnarok-clanker: 0 byte-identical, 6 confirmed by peer review.

- fn_19751 EquipmentResourceMgr::GetHeadName: logic confirmed by peer review
- fn_23373 CSession::GetHeadActName: logic confirmed by peer review
- fn_23374 CSession::GetPlayerHeadActName: logic confirmed by peer review
- fn_23375 CSession::GetHeadPalName: logic confirmed by peer review
- fn_23376 CSession::GetPlayerHeadPalName: logic confirmed by peer review
- fn_23377 CSession::GetHeadSprName: logic confirmed by peer review

Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Adds to the build: Source/Contents/HeadResources.cpp
2026-10-28 21:11:05 +00:00
ragnarok-clanker
8125ad1ce1 Decompile fn_06623 (BuildReplayTaggedRecord)
Batch #1714 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_06623 BuildReplayTaggedRecord: logic confirmed by peer review (annotation added to existing code)

Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-28 20:43:04 +00:00
ragnarok-clanker
ff83912b6b Decompile 9 functions in Source/Contents/Messenger/ClientMessenger.cpp, Source/Client/Session.h, ...
Batch #1711 by ragnarok-clanker: 0 byte-identical, 9 confirmed by peer review.

- fn_23304 SessionMessengerContext::UpdateRandomStats: logic confirmed by peer review
- fn_05603 EquipmentPropertyStore::EquipmentPropertyStore: logic confirmed by peer review
- fn_05771 EquipmentPropertyStore::Clear: logic confirmed by peer review
- fn_05740 EquipmentPropertyStore::~EquipmentPropertyStore: logic confirmed by peer review
- fn_05807 EquipmentPropertyGroup::~EquipmentPropertyGroup: logic confirmed by peer review
- fn_06013 EquipmentProperties::CEquipmentPropertiesMgr::CEquipmentPropertiesMgr: logic confirmed by peer review
- fn_06170 EquipmentProperties::CEquipmentPropertiesMgr::Clear: logic confirmed by peer review
- fn_17276 UIWindowMgr::NotifyItemWindows: logic confirmed by peer review
- fn_21290 CGameMode::NotifyItemBounds: logic confirmed by peer review

Peer-reviewed-by: eAthena
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-28 20:41:46 +00:00
ragnarok-clanker
b677bdbc59 Decompile 3 functions in Source/Client/Session.cpp, Source/Client/Session.h, ...
Batch #1704 by ragnarok-clanker: 0 byte-identical, 3 confirmed by peer review.

- fn_24179 CSession::IsDoramJob: logic confirmed by peer review
- fn_23770 GetSkillFactor: logic confirmed by peer review
- fn_19754 EquipmentResourceMgr::GetBodyRacePrefix: logic confirmed by peer review

Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-28 20:33:49 +00:00
ragnarok-clanker
0bc20896db Decompile 4 functions in Source/Contents/SpriteFrameSynchronization.cpp, Source/Contents/NpcLocationRadius.cpp, ...
Batch #1694 by eAthena: 0 byte-identical, 4 confirmed by peer review.

- fn_23819 CSession::GetSyncedFrame: logic confirmed by peer review
- fn_23467 CSession::GetNpcLocationRadius: logic confirmed by peer review
- fn_23823 CSession::GetRidingJob: logic confirmed by peer review
- fn_24152 CSession::GetSpriteJob: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
Adds to the build: Source/Contents/SpriteFrameSynchronization.cpp, Source/Contents/NpcLocationRadius.cpp, Source/Contents/SpriteJob.cpp
2026-10-28 20:24:26 +00:00
ragnarok-clanker
7a88edb84c Decompile fn_23848 (CSession::LoadXmlTables)
Batch #1684 by eAthena: 0 byte-identical, 1 confirmed by peer review.

- fn_23848 CSession::LoadXmlTables: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
Adds to the build: Source/Contents/ClientXmlTables.cpp
2026-10-28 20:23:55 +00:00
ragnarok-clanker
b7bd70ab06 Decompile 2 functions in Source/Contents/PetTalk.cpp, Source/Contents/EnemyMonsterTalk.cpp, ...
Batch #1692 by eAthena: 0 byte-identical, 2 confirmed by peer review.

- fn_23805 CSession::GetPetTalkActionName: logic confirmed by peer review
- fn_23834 CSession::GetMonsterTalkEventName: logic confirmed by peer review

Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Adds to the build: Source/Contents/PetTalk.cpp, Source/Contents/EnemyMonsterTalk.cpp
2026-10-28 20:12:56 +00:00
ragnarok-clanker
9aea62bd9b Decompile 47 functions in Source/Client/ClientOptions.cpp, Source/Client/Session.h, ...
Batch #1675 by ragnarok-clanker: 2 byte-identical, 45 confirmed by peer review.

- fn_10839 UIButton::Slot25: logic confirmed by peer review
- fn_10852 UIButton::Slot31: logic confirmed by peer review
- fn_10868 UIButton::Slot27: logic confirmed by peer review
- fn_10930 UIStaticBitmap::SetBitmap: logic confirmed by peer review
- fn_10931 UIBitmapButton::SetBitmap: logic confirmed by peer review
- fn_11320 UIComboBoxEx2::Slot15: logic confirmed by peer review
- fn_11326 UIListBox::Slot15: logic confirmed by peer review
- fn_11327 UIListBoxEx::Slot15: logic confirmed by peer review
- fn_11381 UIScrollBar::Paint: logic confirmed by peer review
- fn_11383 UIScrollBar_Navi::Paint: logic confirmed by peer review
- fn_11425 UIScrollBar::Slot25: logic confirmed by peer review
- fn_11440 UIScrollBar::Slot31: logic confirmed by peer review
- fn_11445 UITextButton::Slot31: logic confirmed by peer review
- fn_11468 UIScrollBar::Slot27: logic confirmed by peer review
- fn_11471 UITextButton::Slot27: logic confirmed by peer review
- fn_11494 UITextButton::Slot33: logic confirmed by peer review
- fn_11779 UIFrameWnd::Slot25: logic confirmed by peer review
- fn_11781 UIFrameWnd::Slot31: logic confirmed by peer review
- fn_11786 UIFrameWnd::Slot27: logic confirmed by peer review
- fn_12610 CSession::GetOption: logic confirmed by peer review
- fn_12689 ActivateShortcut: logic confirmed by peer review
- fn_12711 ShortcutTooltip::Hover: logic confirmed by peer review
- fn_12724 ShortcutDetails::Open: logic confirmed by peer review (already on main)
- fn_12760 UIShortCutWnd::SendMsg: logic confirmed by peer review
- fn_17144 UIWindowMgr::RemoveOrder: logic confirmed by peer review
- fn_17158 UIWindowMgr::Capture: byte-identical
- fn_17180 UIWindowMgr::BringToFront: logic confirmed by peer review
- fn_17192 UIWindowMgr::IsOrderFixed: logic confirmed by peer review
- fn_17232 UIWindowMgr::ReleaseCapture: byte-identical
- fn_17255 UIWindowMgr::SetCapture: logic confirmed by peer review
- fn_20382 CConnection::CConnection: logic confirmed by peer review
- fn_20383 CRagConnection::CRagConnection: logic confirmed by peer review
- fn_20384 CConnection::~CConnection: logic confirmed by peer review (already on main)
- fn_20389 CConnection::Connect: logic confirmed by peer review
- fn_20390 CConnection::Close: logic confirmed by peer review
- fn_20409 GetRagConnection: logic confirmed by peer review
- fn_21406 AutomaticSkills::Complete: logic confirmed by peer review
- fn_03927 CCharacterLinkedUserDataMgr::CompleteLoad: logic confirmed by peer review
- fn_03933 CCharacterLinkedUserDataMgr::Save: logic confirmed by peer review
- fn_03937 CSession::SetOption: logic confirmed by peer review
- fn_11073 UIScrollBar::UIScrollBar: logic confirmed by peer review
- fn_11102 UIComboBoxEx2::~UIComboBoxEx2: logic confirmed by peer review (already on main)
- fn_09150 AutomaticSkills::DisableAll: logic confirmed by peer review
- fn_09153 AutomaticSkills::Use: logic confirmed by peer review
- fn_10689 UIBitmapButton::~UIBitmapButton: logic confirmed by peer review (already on main)
- fn_10795 UIBitmapButton::Paint: logic confirmed by peer review
- fn_10817 UIStaticBitmap::Paint: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-28 20:01:00 +00:00
ragnarok-clanker
c934fe7820 Decompile 2 functions in Source/UI/Shortcuts/ShortcutCooldowns.cpp, Source/Client/Session.h
Batch #1653 by ragnarok-clanker: 0 byte-identical, 2 confirmed by peer review.

- fn_23876 CSession::IsSkillIdInRange6018: logic confirmed by peer review
- fn_23877 CSession::IsSkillIdInRange6001: logic confirmed by peer review

Peer-reviewed-by: eAthena
Reviewed-by: ragnarok-clanker
2026-10-28 19:47:58 +00:00
ragnarok-clanker
4bce141e4c Decompile fn_23811 (CSession::GetPetHungryStateString)
Batch #1625 by eAthena: 0 byte-identical, 1 confirmed by peer review.

- fn_23811 CSession::GetPetHungryStateString: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-28 19:45:56 +00:00
ragnarok-clanker
6ebe295226 Decompile fn_23814 (CSession::GetPetTalkName)
Batch #1621 by eAthena: 0 byte-identical, 1 confirmed by peer review.

- fn_23814 CSession::GetPetTalkName: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
Adds to the build: Source/Contents/PetTalkNames.cpp
2026-10-28 19:45:23 +00:00
ragnarok-clanker
499d5b8558 Decompile 2 functions in Source/Contents/MonsterResources.cpp, Source/Client/Session.h
Batch #1608 by eAthena: 0 byte-identical, 2 confirmed by peer review.

- fn_23788 CSession::GetMonsterActName: logic confirmed by peer review
- fn_23790 CSession::GetMonsterSprName: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
Adds to the build: Source/Contents/MonsterResources.cpp
2026-10-28 19:44:03 +00:00
ragnarok-clanker
b496a618dc Decompile 2 functions in Source/Contents/RobeOpacity.cpp, Source/Contents/RobeTopLayer.cpp, ...
Batch #1582 by eAthena: 0 byte-identical, 2 confirmed by peer review.

- fn_23486 CSession::GetRobeAlpha: logic confirmed by peer review
- fn_24176 CSession::IsTopLayerRobe: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
Adds to the build: Source/Contents/RobeOpacity.cpp, Source/Contents/RobeTopLayer.cpp
2026-10-28 19:10:37 +00:00
ragnarok-clanker
3d4b2c79dc Decompile 2 functions in Source/UI/Window/UIMessageBox.cpp, Source/UI/Window/UIMerInfoWnd.h, ...
Batch #1553 by ragnarok-clanker: 0 byte-identical, 2 confirmed by peer review.

- fn_11712 UIBank_NewWnd::TransactionAmount: logic confirmed by peer review
- fn_11767 UIMerInfoWnd::Paint: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-28 18:50:35 +00:00
ragnarok-clanker
943d22d0b8 Decompile fn_11762 (UICntWnd::Paint)
Batch #1544 by ragnarok-clanker: 1 byte-identical, 0 confirmed by peer review.

- fn_11762 UICntWnd::Paint: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-10-28 17:58:13 +00:00
ragnarok-clanker
16b72c624f Decompile 2 functions in Source/Contents/Skills/ClientSkills.cpp, Source/Contents/Skills/ClientSkills.h, ...
Batch #1471 by ragnarok-clanker: 0 byte-identical, 2 confirmed by peer review.

- fn_23753 CSession::ResetItems2B50: logic confirmed by peer review
- fn_23770 GetSkillFactor: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-28 15:32:17 +00:00
ragnarok-clanker
447fa8b9f6 Decompile 4 functions in Source/Contents/Jobs/JobInheritance.cpp, Source/Contents/Jobs/JobInheritance.h, ...
Batch #1470 by ragnarok-clanker: 0 byte-identical, 4 confirmed by peer review.

- fn_23590 IsVisibleJob: logic confirmed by peer review
- fn_23841 GetWeaponViewValue: logic confirmed by peer review
- fn_23906 ResetHotkeySlots: logic confirmed by peer review
- fn_23910 CSession::SetPairValue: logic confirmed by peer review

Peer-reviewed-by: Kisuka, eAthena
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-28 14:13:00 +00:00
ragnarok-clanker
c351db5d57 Decompile 4 functions in Source/Contents/ClientTiming.cpp, Source/Client/Session.h
Batch #1467 by ragnarok-clanker: 0 byte-identical, 4 confirmed by peer review.

- fn_23466 CSession::GetServerTime: logic confirmed by peer review
- fn_23605 CSession::AddPingSample: logic confirmed by peer review
- fn_23637 CSession::SetServerTime: logic confirmed by peer review
- fn_23638 CSession::SetHotkeyDescription: logic confirmed by peer review

Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
Adds to the build: Source/Contents/ClientTiming.cpp
2026-10-28 14:02:41 +00:00
ragnarok-clanker
b9474e7c82 Decompile fn_23379 (CSession::HomunSkillLevel)
Batch #1465 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.

- fn_23379 CSession::HomunSkillLevel: logic confirmed by peer review

Peer-reviewed-by: Yommy
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-28 13:55:33 +00:00
ragnarok-clanker
f61f0747fa Decompile 2 functions in Source/Contents/MapSkyMgr.cpp, Source/Contents/MapSkyMgr.h, ...
Batch #1449 by Yommy: 2 byte-identical, 0 confirmed by peer review.

- fn_17872 CPathFinder::Height: byte-identical
- fn_17873 CPathFinder::Width: byte-identical

Merged automatically: every function is byte-identical to the original.
Adds to the build: Source/Contents/MapSkyMgr.cpp, Source/Contents/EquipmentResources.cpp, Source/Contents/Pathfinding.cpp, Source/Resource/ImfResource.cpp
2026-10-28 12:59:53 +00:00
ragnarok-clanker
648ae44d9d Decompile 2 functions in Source/Contents/AdventureGuideMgr.cpp, Source/Contents/AdventureGuideMgr.h, ...
Batch #1377 by Yommy: 0 byte-identical, 2 confirmed by peer review.

- fn_05237 CAdventureGuideMgr::GetEpisodeList: logic confirmed by peer review
- fn_05238 CAdventureGuideMgr::GetContentsList: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-28 12:06:16 +00:00
ragnarok-clanker
64bd0730d5 Decompile fn_24225 (CSession::CollectCardItems)
Batch #1366 by Yommy: 0 byte-identical, 1 confirmed by peer review.

- fn_24225 CSession::CollectCardItems: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
Adds to the build: Source/Contents/ClientState.cpp
2026-10-28 11:42:30 +00:00
ragnarok-clanker
22d7370193 Decompile 4 functions in Source/Contents/Items/ItemInfo.cpp, Source/Contents/Items/ItemInfo.h, ...
Batch #1336 by ragnarok-clanker: 0 byte-identical, 4 confirmed by peer review.

- fn_02473 CTexture::Touch: logic confirmed by peer review
- fn_06603 ItemInfo::IsApprenticeItem: logic confirmed by peer review
- fn_24179 CSession::IsReducedSkill: logic confirmed by peer review
- fn_23614 CSession::ConvertTooltipText: logic confirmed by peer review

Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-28 10:35:18 +00:00
ragnarok-clanker
998a6de79a Decompile fn_06600 (ItemInfo::HasSpecialCard)
Batch #1330 by ragnarok-clanker: 1 byte-identical, 0 confirmed by peer review.

- fn_06600 ItemInfo::HasSpecialCard: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-10-28 10:19:34 +00:00
ragnarok-clanker
308cefc066 Decompile fn_23826 (CSession::SyncUnknown0E98)
Batch #1325 by ragnarok-clanker: 1 byte-identical, 0 confirmed by peer review.

- fn_23826 CSession::SyncUnknown0E98: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-10-28 10:10:19 +00:00
ragnarok-clanker
d7bd31b4a6 Decompile 5 functions in Source/Contents/PetStatus.cpp, Source/Client/Session.h
Batch #1190 by eAthena: 0 byte-identical, 5 confirmed by peer review.

- fn_23806 CSession::GetPetActionNumber: logic confirmed by peer review
- fn_23808 CSession::GetPetFriendlyState: logic confirmed by peer review
- fn_23809 CSession::GetPetFriendlyStateString: logic confirmed by peer review
- fn_23810 CSession::GetPetHungryState: logic confirmed by peer review
- fn_23817 CSession::GetPetEmotionNumber: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
Adds to the build: Source/Contents/PetStatus.cpp
2026-10-27 21:08:12 +00:00
ragnarok-clanker
22ebefe099 Decompile 4 functions in Source/Contents/PetStrings.cpp, Source/Client/Session.h
Batch #1192 by eAthena: 0 byte-identical, 4 confirmed by peer review.

- fn_23807 CSession::GetPetFood: logic confirmed by peer review
- fn_23812 CSession::GetPetIllustName: logic confirmed by peer review
- fn_23813 CSession::GetPetJobByEggItem: logic confirmed by peer review
- fn_23816 CSession::GetPetString: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
Adds to the build: Source/Contents/PetStrings.cpp
2026-10-27 21:07:55 +00:00
ragnarok-clanker
ab4477de24 Decompile 7 functions in Source/Contents/Skills/ClientSkills.cpp, Source/Client/Session.h
Batch #1179 by eAthena: 7 byte-identical, 0 confirmed by peer review.

- fn_23754 CSession::ClearItemQuantities: byte-identical
- fn_23755 CSession::ResetItems3500: byte-identical
- fn_23756 CSession::ClearSlots06EB: byte-identical
- fn_23757 CSession::ClearShortcutSlots: byte-identical
- fn_23758 CSession::ClearSecondaryShortcutSlots: byte-identical
- fn_23759 CSession::ClearUnknown0420: byte-identical
- fn_23774 CSession::CountItems5C68: byte-identical

Merged automatically: every function is byte-identical to the original.
2026-10-27 20:58:12 +00:00
ragnarok-clanker
4d9d775cc8 Decompile 3 functions in Source/Contents/World/WorldSpatialTree.cpp, Source/Contents/World/WorldSpatialTree.h, ...
Batch #995 by ragnarok-clanker: 0 byte-identical, 3 confirmed by peer review.

- fn_17651 WorldScene::WorldScene: logic confirmed by peer review
- fn_17654 WorldScene::~WorldScene: logic confirmed by peer review
- fn_17704 WorldSpatialTree::RefreshModelBounds: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
2026-10-27 08:51:12 +00:00
ragnarok-clanker
f575258340 Maintenance: Define every global once in its owner unit; session members replace member globals
Batch #906 by ragnarok-clanker: no function's compiled code changes; checked with 9 compiled unit(s), including every includer of Source/Client/Session.h, Source/Client/Registry.h, Source/Client/Application/LaunchInfo.h, Source/Client/Application/Launcher.h, Source/Client/Mode/ActiveGameMode.h, Source/Render/DeviceSelection.h.
Adds to the build: Source/Client/Session.cpp, Source/Client/Registry.cpp, Source/Client/Application/LaunchInfo.cpp, Source/Render/DeviceSelection.cpp
2026-10-26 18:34:25 +00:00