ragnarok-clanker
347c72405a
EffectPrimitiveState: split unknown_0258[4] into DHXJ chPoint/chVal1/chVal2/chVal3 (std::vector<float> each). Pure rename, codegen unchanged.
2026-10-29 16:53:57 +01:00
ragnarok-clanker
bdd9736af4
EffectPrimitiveState: name 84 CEffectPrim members after DHXJ (layout matches DHXJ member order with 12-byte std::vector and one extra 2026 dword at 0x1D8): stateCnt, duration, pattern, count, renderFlag, numSegment, speed/accel, gravSpeed/gravAccel, longitude/latitude/roll, size, alpha*, lati*/long*/roll* speeds and accels, radius*, width*/height*, orgPos, deltaPos/deltaPos2/deltaPos3, segPos, rotAxis, transform/rotTransform, etc. Pure rename, codegen unchanged (221/221 functions with includers).
2026-10-29 15:58:02 +01:00
ragnarok-clanker
7f3b43c8ef
Rename AttachedEffect -> CRagEffect (DHXJ), AttachedEffect.{h,cpp} -> RagEffect.{h,cpp}. Pure rename, codegen unchanged (129/129 functions identical with includers).
2026-10-29 12:19:20 +01:00
ragnarok-clanker
385c906a98
Align method names with DHXJ (GetGameMode/GetLoginMode, CRes::Lock/Unlock, InitSegment, ShiftSegment, AnimMotion, ProcessAlpha, Prim3DCircle/Casting4/Casting5/Cylinder/CylinderHalf/ParticleSpline, Get_Angle, GetRadian, matrix MakeXRotation/AppendYRotation/MakeTranslate/MakeInverse, ResetInput, IncreaseSelection, GetKeyStrokeSize, UpdateMatrix, ResetQueue, Cleanup, CGroundScope::OnProcess). Pure renames, codegen unchanged (baseline with includers).
2026-10-29 12:09:28 +01:00
ragnarok-clanker
e4be8f4190
Decompile 18 functions in Source/Client/Application/UnhandledExceptionHandler.cpp, Source/Client/Session.h, ...
...
Batch #2077 by ragnarok-clanker: 0 byte-identical, 18 confirmed by peer review.
- fn_04709 TopLevelExceptionFilter: logic confirmed by peer review (already on main)
- fn_08004 C3dGrannyModelRes::PlayAnimation: logic confirmed by peer review
- fn_09315 UIRequestJoinPartyWnd::SendMsg: logic confirmed by peer review
- fn_19761 EffectParticle::EffectParticle: logic confirmed by peer review
- fn_19768 EffectParticle::InitializeRecords: logic confirmed by peer review
- fn_20007 AttachedEffect::AttachedEffect: logic confirmed by peer review
- fn_20076 CreateEffectParticle: logic confirmed by peer review
- fn_20088 UpdatePartyEffect: logic confirmed by peer review
- fn_20991 CRenderObject::CRenderObject: logic confirmed by peer review
- fn_21069 ?CreatePartyEffect@?A0xba063134@@YAPAUAttachedEffect@@AAUEffectActor@@AAUPartyEffectMode@@@Z: logic confirmed by peer review
- fn_21086 RenderObjectState::Reset: logic confirmed by peer review
- fn_23396 CSession::GetJobName: logic confirmed by peer review
- fn_23495 CSession::InitJobNameTable: logic confirmed by peer review
- fn_23788 CSession::GetMonsterActName: logic confirmed by peer review
- fn_23791 CSession::GetMonsterTalkText: logic confirmed by peer review
- fn_20987 EffectActor::EffectActor: logic confirmed by peer review
- fn_22363 CSoundMaker::CSoundMaker: logic confirmed by peer review
- fn_24251 CEffectMaker::CEffectMaker: logic confirmed by peer review
Reviewed-by: ragnarok-clanker
2026-10-29 09:48:08 +00:00
ragnarok-clanker
2e808aaa74
Decompile 3 functions in Source/Contents/Effects/EffectPrimitiveMotion.cpp, Source/Contents/Effects/EffectParticle.h, ...
...
Batch #1853 by ragnarok-clanker: 1 byte-identical, 2 confirmed by peer review.
- fn_19849 EffectPrimitiveState::UpdateColor: logic confirmed by peer review
- fn_19762 EffectPrimitiveSlot::EffectPrimitiveSlot: byte-identical (already on main)
- fn_19865 DrawEffectPrimitive15: logic confirmed by peer review
Peer-reviewed-by: Yommy
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-28 22:53:38 +00:00
ragnarok-clanker
d7862ef5c4
Decompile 9 functions in Source/Utility/Math/Vector3d.h, Source/Utility/Math/AffineMatrix.h, ...
...
Batch #1843 by ragnarok-clanker: 1 byte-identical, 8 confirmed by peer review.
- fn_02024 ClientRadians: logic confirmed by peer review
- fn_17668 WorldScene::GetGameActorByAID: logic confirmed by peer review
- fn_21057 CRenderObject::GetTargetPos: logic confirmed by peer review
- fn_17667 WorldScene::GetGameActorByAidIncludeMe: logic confirmed by peer review
- fn_21290 CGameMode::NotifyItemBounds: logic confirmed by peer review
- fn_03089 CEffect::Slot25: logic confirmed by peer review
- fn_08405 CellWorldPosition: logic confirmed by peer review
- fn_19762 EffectPrimitiveSlot::EffectPrimitiveSlot: byte-identical (already on main)
- fn_19865 DrawEffectPrimitive15: logic confirmed by peer review
Peer-reviewed-by: Yommy, eAthena, ragnarok-clanker
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-28 22:49:51 +00:00
ragnarok-clanker
805cf67f82
Decompile 4 functions in Source/Contents/Effects/EffectPrimitiveMotion.cpp, Source/Contents/Effects/EffectParticle.h, ...
...
Batch #1793 by ragnarok-clanker: 0 byte-identical, 4 confirmed by peer review.
- fn_19800 EffectParticle::PrimEffectTexture2: logic confirmed by peer review
- fn_19802 EffectParticle::PrimEffectTexture_Ani: logic confirmed by peer review
- fn_19805 EffectParticle::PrimFirstAid: logic confirmed by peer review
- fn_19816 EffectParticle::PrimIntimidate: logic confirmed by peer review
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-28 22:21:46 +00:00
ragnarok-clanker
25dd065dbd
Decompile 8 functions in Source/Contents/Effects/EffectPrimitiveMotion.cpp, Source/Contents/Effects/EffectPrimitiveState.cpp, ...
...
Batch #1765 by ragnarok-clanker: 0 byte-identical, 8 confirmed by peer review.
- fn_19791 EffectParticle::PrimBottom: logic confirmed by peer review
- fn_19765 EffectPrimitiveState::GetColorOverride: logic confirmed by peer review
- fn_19779 EffectParticle::UpdateHit6: logic confirmed by peer review
- fn_19785 MoveEffectPrimitive: logic confirmed by peer review
- fn_19849 EffectPrimitiveState::UpdateColor: logic confirmed by peer review
- fn_20076 CreateEffectParticle: logic confirmed by peer review
- fn_19866 RenderEffectPrimitive15: logic confirmed by peer review
- fn_20088 UpdatePartyEffect: logic confirmed by peer review
Reviewed-by: ragnarok-clanker
2026-10-28 22:09:53 +00:00
ragnarok-clanker
fbb9a30daa
Decompile fn_19790 (EffectParticle::PrimBottom2)
...
Batch #1732 by ragnarok-clanker: 0 byte-identical, 1 confirmed by peer review.
- fn_19790 EffectParticle::PrimBottom2: logic confirmed by peer review
Reviewed-by: ragnarok-clanker
2026-10-28 21:47:19 +00:00
ragnarok-clanker
9e88189238
Decompile fn_19766 (CalculateVectorAngle)
...
Batch #1612 by eAthena: 0 byte-identical, 1 confirmed by peer review.
- fn_19766 CalculateVectorAngle: logic confirmed by peer review
Reviewed-by: ragnarok-clanker
2026-10-28 19:44:33 +00:00
ragnarok-clanker
e79c5afc99
Decompile 8 functions in Source/Contents/Effects/EffectPrimitiveMotion.cpp, Source/Contents/Effects/EffectPrimitiveState.h, ...
...
Batch #1425 by ragnarok-clanker: 0 byte-identical, 8 confirmed by peer review.
- fn_19772 EffectParticle::UpdateFireWall: logic confirmed by peer review
- fn_19775 EffectParticle::UpdateStoneCurse: logic confirmed by peer review
- fn_19776 EffectParticle::UpdateBeginSpell: logic confirmed by peer review
- fn_19779 EffectParticle::UpdateHit6: logic confirmed by peer review
- fn_19781 EffectParticle::UpdateDetoxication: logic confirmed by peer review
- fn_19782 EffectParticle::UpdateExit: logic confirmed by peer review
- fn_19764 EffectParticle::AdvanceFrame: logic confirmed by peer review
- fn_19931 EffectParticle::UpdateRecords: logic confirmed by peer review
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
2026-10-28 12:43:08 +00:00
ragnarok-clanker
4342eec591
Decompile fn_19762 (EffectPrimitiveSlot::EffectPrimitiveSlot)
...
Batch #1273 by ragnarok-clanker: 1 byte-identical, 0 confirmed by peer review.
- fn_19762 EffectPrimitiveSlot::EffectPrimitiveSlot: byte-identical
Merged automatically: every function is byte-identical to the original.
2026-10-28 02:04:38 +00:00
ragnarok-clanker
c6cc9dc69e
Decompile 6 functions in Source/Contents/Effects/EffectPrimitiveState.cpp, Source/Contents/Effects/EffectPrimitiveState.h, ...
...
Batch #1199 by eAthena: 0 byte-identical, 6 confirmed by peer review.
- fn_19765 EffectPrimitiveState::GetColorOverride: logic confirmed by peer review
- fn_19773 ShrinkEffectPrimitiveSlots: logic confirmed by peer review
- fn_19774 PulseEffectPrimitiveSlots: logic confirmed by peer review
- fn_19777 SpinEffectPrimitive: logic confirmed by peer review
- fn_19778 RollEffectPrimitive: logic confirmed by peer review
- fn_19784 AdvanceEffectPrimitive: logic confirmed by peer review
Reviewed-by: ragnarok-clanker
2026-10-27 21:09:20 +00:00
ragnarok-clanker
02df811b36
Maintenance: Add mandatory field offset markers /* XXXX */ and assertions to Contents headers (part 1: Actors, Effects, Ground, Hotke
...
Batch #1066 by ragnarok-clanker: no function's compiled code changes; checked with 70 compiled unit(s), including every includer of Source/Contents/Actors/RenderObject.h, Source/Contents/CashEmotionMgr.h, Source/Contents/Effects/AttachedEffect.h, Source/Contents/Effects/Effect.h, Source/Contents/Effects/EffectActor.h, Source/Contents/Effects/EffectParticle.h, Source/Contents/Effects/EffectPrimitiveState.h, Source/Contents/Emblems/GuildEmblemReqBundle.h, Source/Contents/Ground/GroundGeometry.h, Source/Contents/Ground/GroundSpatial.h, Source/Contents/Ground/GroundWaterState.h, Source/Contents/Ground/TerrainHeight.h, Source/Contents/Hotkeys/EmotionHotkeys.h, Source/Contents/Hotkeys/HotkeyInfo.h, Source/Contents/Hotkeys/UserHotkeyMgr.h, Source/Contents/InstantVar.h.
2026-10-27 13:57:41 +00:00
ragnarok-clanker
a47d20f8be
Reconstruct readable C++ and organize cohesive source subsystems
...
Administrative source import: native x86 compilation passed for 423 authored units. Source placement and submission states are migrated separately; this commit does not imply peer acceptance.
Previous head: 35d2a8cb36
2026-10-25 07:42:41 +00:00
