clank/rodecomp
1
0
Fork 0
Code Issues Wiki Activity
4,023 commits 1 branch 0 tags 45 MiB
Commit graph

11 commits

Author SHA1 Message Date
ragnarok-clanker
cb26c24e68 Maintenance: [forced, user-approved] Remove fabricated UIButtonContext (follow-up to #10125). Original button code reads globals dire 
Batch #10169 by ragnarok-clanker: forced by an admin (137 lower score(s), 472 changed function(s)); checked with 394 compiled unit(s), including every includer of Source/Contents/SignBoard/SignBoard.h, Source/UI/Buttons/UIBasicButton.h, Source/UI/Buttons/UIBitmapButton.h, Source/UI/Buttons/UIBmpRadioBtn.h, Source/UI/Buttons/UIBmpTextButton.h, Source/UI/Buttons/UIBmpTextButton2.h, Source/UI/Buttons/UIButton.h, Source/UI/Buttons/UICashEmotionSprBtn.h, Source/UI/Buttons/UICheckBox.h, Source/UI/Buttons/UIItemMoveInfo.h, Source/UI/Buttons/UIItemTagButton.h, Source/UI/Buttons/UIJobSlotButton.h, Source/UI/Buttons/UINaviLinkButton.h, Source/UI/Buttons/UINoneVisibleButton.h, Source/UI/Buttons/UIRadioBtn.h, Source/UI/Buttons/UIReplayButton.h, Source/UI/Buttons/UISlotBmpButton.h, Source/UI/Buttons/UISpriteButton.h, Source/UI/Buttons/UITVBitmapButton.h, Source/UI/Buttons/UITVTextButton.h, Source/UI/Buttons/UITagButton.h, Source/UI/Buttons/UITextButton.h, Source/UI/CashEmotion/UICashEmotionPiece.h, Source/UI/CashShop/UICashShopWnd.h, Source/UI/Chat/UIChatRoomTitle.h, Source/UI/Chat/UISubChatHisWnd.h, Source/UI/Chat/UIWhisperWnd.h, Source/UI/Clan/UIClanWnd.h, Source/UI/Dialogs/UIChooseWarpWnd.h, Source/UI/Dialogs/UIChooseWnd.h, Source/UI/Dialogs/UIEditctrlWnd.h, Source/UI/Dialogs/UIEmailAddressWnd.h, Source/UI/Dialogs/UIGraffiStrboxWnd.h, Source/UI/Dialogs/UIMemorialDunWnd.h, Source/UI/Dialogs/UIMenuWnd.h, Source/UI/Dialogs/UIMiniMapWnd.h, Source/UI/Dialogs/UIMinimapZoomWnd.h, Source/UI/Dialogs/UINotifyLevelUpWnd.h, Source/UI/Dialogs/UINotifyQuestWnd.h, Source/UI/Dialogs/UINpcEditDialogWnd.h, Source/UI/Dialogs/UIPasswordWnd.h, Source/UI/Dialogs/UIProhibitListWnd.h, Source/UI/Dialogs/UIQuitWnd.h, Source/UI/Dialogs/UIRestartWnd.h, Source/UI/Dialogs/UISelectCartWnd.h, Source/UI/Dialogs/UITipOfTheDayWnd.h, Source/UI/Dialogs/UITipboxWnd.h, Source/UI/Dialogs/UIWaitDBSaveWnd.h, Source/UI/Edit/UICandidateWnd.h, Source/UI/Edit/UIEditCtrl.h, Source/UI/Guild/UIAgitWnd.h, Source/UI/Guild/UIGuildHelperWnd.h, Source/UI/Guild/UIGuildWnd.h, Source/UI/Guild/UIGuild_Storage_Log.h, Source/UI/Item/UIItemBaseWnd.h, Source/UI/Items/MergeItemWnd.h, Source/UI/Items/UICardItemIllustWnd.h, Source/UI/Items/UIIllustWnd.h, Source/UI/Items/UIItemParamChangeDisplayWnd.h, Source/UI/Items/UIItemRepairWnd.h, Source/UI/Items/UIMakeTargetListWnd.h, Source/UI/Items/UIMakeTargetProcessWnd.h, Source/UI/Items/UIMakeTargetResultWnd.h, Source/UI/Items/UISpellListWnd.h, Source/UI/Items/UISwapEquipmentWnd.h, Source/UI/Items/UIWeaponRefineWnd.h, Source/UI/Lists/UIComboBoxDefWnd.h, Source/UI/Lists/UIListBox.h, Source/UI/Lists/UIMemberListBox.h, Source/UI/Lists/UITabControl.h, Source/UI/Lists/UITreeView.h, Source/UI/Navigation/UINavigationV4Wnd.h, Source/UI/Navigation/UIPrivateAirplaneWnd.h, Source/UI/Party/UIAdvenPartyBoardWnd.h, Source/UI/Party/UIApplyForPartyWnd.h, Source/UI/Party/UIPartyInfoWnd.h, Source/UI/Party/UIPartySettingWnd.h, Source/UI/Party/UIRegisterPartyWnd.h, Source/UI/Quest/UIRenewQuestWnd.h, Source/UI/RuneSystem/UIRuneSystemWnd.h, Source/UI/Shop/UIMerchantItemPurchaseMSGWnd.h, Source/UI/Shop/UIMerchantShopMakeWnd.h, Source/UI/Shop/UIMerchantShopTitle.h, Source/UI/Shop/UINoticeMessageBox_LockSellItem.h, Source/UI/Shortcuts/ShortcutControls.h, Source/UI/Shortcuts/UIShortCutWnd.h, Source/UI/Skill/UISkillNameChangeWnd.h, Source/UI/Status/UIStatusWnd.h, Source/UI/StylingShop/UIStylingShopWnd.h, Source/UI/Text/UIAchWnd.h, Source/UI/Text/UIStaticText.h, Source/UI/Text/UITextViewer.h, Source/UI/UIBarGraph.h, Source/UI/UIBasicCtrl.h, Source/UI/UIBroadcastBalloon.h, Source/UI/UICaptchaPreviewWnd.h, Source/UI/UICaptchaRegisterWnd.h, Source/UI/UIChangeMaterialWnd.h, Source/UI/UICheckAttendanceWnd.h, Source/UI/UIGradeEnchantWnd.h, Source/UI/UIHotkeyGuideWnd.h, Source/UI/UIIngredientInfoWnd.h, Source/UI/UIItemReformWnd.h, Source/UI/UILapineScrollBar.h, Source/UI/UILapineUpgradeBoxWnd.h, Source/UI/UIMacroBlackListCheckWnd.h, Source/UI/UIMacroUserInfoWnd.h, Source/UI/UIPreviewEquipWnd.h, Source/UI/UIRefiningWnd.h, Source/UI/UIReputeWnd.h, Source/UI/UISlotBitmap.h, Source/UI/UIStaticBitmap.h, Source/UI/UIStaticItem.h, Source/UI/Window/UIAccountLimitedToolWnd.h, Source/UI/Window/UIBalloonOpenBtn.h, Source/UI/Window/UIBank_NewWnd.h, Source/UI/Window/UIBasicInfoWnd.h, Source/UI/Window/UIBattleMsgOptionWnd.h, Source/UI/Window/UIChangeNameWnd.h, Source/UI/Window/UIChatRoomWnd.h, Source/UI/Window/UICntWnd.h, Source/UI/Window/UIDebuffRemoveWnd.h, Source/UI/Window/UIEscOptionWnd.h, Source/UI/Window/UIFrameWnd.h, Source/UI/Window/UIHomunInfoWnd.h, Source/UI/Window/UIJobListWnd.h, Source/UI/Window/UILoginOTPWnd.h, Source/UI/Window/UIMakeCharWnd.h, Source/UI/Window/UIMerInfoWnd.h, Source/UI/Window/UIMessageBox.h, Source/UI/Window/UIMileageWnd.h, Source/UI/Window/UIMonsterDisplayWnd.h, Source/UI/Window/UIMonsterInfoWnd.h, Source/UI/Window/UINavigationHelpWnd.h, Source/UI/Window/UINavigationWnd.h, Source/UI/Window/UINewMakeCharWnd.h, Source/UI/Window/UINewSelectCharWnd.h, Source/UI/Window/UINewSkillListWnd.h, Source/UI/Window/UINoteWnd.h, Source/UI/Window/UINoticeWnd.h, Source/UI/Window/UIOpenMailBoxWnd.h, Source/UI/Window/UIOpenRoulletteWnd.h, Source/UI/Window/UIPartyBookingHelpWnd.h, Source/UI/Window/UIPayConfirmWnd.h, Source/UI/Window/UIPetEvolutionWnd.h, Source/UI/Window/UIPetInfoWnd.h, Source/UI/Window/UIRebirthWnd.h, Source/UI/Window/UIReplayControlWnd.h, Source/UI/Window/UIReplayRECControlWnd.h, Source/UI/Window/UIRodexContentsWnd.h, Source/UI/Window/UISecondCostumeWnd.h, Source/UI/Window/UISeekPartyListWnd.h, Source/UI/Window/UISeekPartyMBWnd.h, Source/UI/Window/UISeekPartyWnd.h, Source/UI/Window/UISelectReplayDataWnd.h, Source/UI/Window/UISelectServerWnd.h, Source/UI/Window/UISerachStoreInfoWnd.h, Source/UI/Window/UIShowWarpWnd.h, Source/UI/Window/UITalkboxTrapInputWnd.h, Source/UI/Window/UITransMenuWnd.h, Source/UI/Window/UIVideoWnd.h, Source/UI/Window/UIViewCameraInfoWnd.h, Source/UI/Window/UIWindow.h.
 2026-11-02 18:51:23 +00:00
ragnarok-clanker
02912c5637 Decompile fn_09425 (UICashEmotionMiniWnd::UICashEmotionMiniWnd) 
Batch #9395 by secret: 0 byte-identical, 1 confirmed by peer review.

- fn_09425 UICashEmotionMiniWnd::UICashEmotionMiniWnd: logic confirmed by peer review

Peer-reviewed-by: gordaoprogramas, Bielhp, Toshiro
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
 2026-11-01 11:35:45 +00:00
ragnarok-clanker
330bff5807 Decompile 5 functions in Source/Contents/CashEmotionMgr.cpp, Source/Contents/CashEmotionMgr.h, ... 
Batch #8908 by youko: 0 byte-identical, 5 confirmed by peer review.

- fn_02966 CCashEmotionMgr::LoadScripts: logic confirmed by peer review
- fn_02971 CCashEmotionMgr::InsertEmotion: logic confirmed by peer review
- fn_03037 CCashEmotionMgr::InsertEmotionVarientListTable: logic confirmed by peer review
- fn_09367 UICashEmotionListChildWnd_Purchase::Refresh: logic confirmed by peer review
- fn_09393 UICashEmotionListChildWnd_UnPurchased::Refresh: logic confirmed by peer review

Peer-reviewed-by: gordaoprogramas, pedrao, dori
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
 2026-10-31 23:28:56 +00:00
ragnarok-clanker
c96c46d5c5 Decompile fn_21584 (CGameMode::sub_D079A0) 
Batch #8979 by KWDev: 0 byte-identical, 1 confirmed by peer review.

- fn_21584 CGameMode::sub_D079A0: logic confirmed by peer review (annotation added to existing code)

Peer-reviewed-by: Yommy, gordaoprogramas
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
 2026-10-31 23:23:51 +00:00
ragnarok-clanker
ca9d96ebee Decompile fn_09473 (UICashEmotionPack_Unpurchase::Slot53) 
Batch #8806 by kyoshi: 0 byte-identical, 1 confirmed by peer review.

- fn_09473 UICashEmotionPack_Unpurchase::Slot53: logic confirmed by peer review

Peer-reviewed-by: eAthena, gordaoprogramas, dori
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
 2026-10-31 21:27:58 +00:00
ragnarok-clanker
df3d8d3319 Decompile fn_09468 (UICashEmotionPack_Search_UnPurchased::UICashEmotionPack_Search_UnPurchased) 
Batch #6937 by aDw: 0 byte-identical, 1 confirmed by peer review.

- fn_09468 UICashEmotionPack_Search_UnPurchased::UICashEmotionPack_Search_UnPurchased: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker, willerthal
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
 2026-10-31 02:40:20 +00:00
ragnarok-clanker
1f7c277617 Decompile 2 functions in Source/Contents/CashEmotionMgr.cpp, Source/UI/CashEmotion/UICashEmotionPack.h 
Batch #5919 by superintelligence: 0 byte-identical, 2 confirmed by peer review.

- fn_09343 UICashEmotionScrollWnd::UpdateScrollBars: logic confirmed by peer review
- fn_09445 UICashEmotionPack::Slot15: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker, eAthena, System4z
Accepted without human review: peers confirmed the logic ("same" ahead by at least 3, with 70% of the votes).
 2026-10-30 19:01:28 +00:00
ragnarok-clanker
843f495bcb Decompile 9 functions in Source/Contents/CashEmotionMgr.cpp, Source/Contents/CashEmotionMgr.h, ... 
Batch #5093 by youko: 9 byte-identical, 0 confirmed by peer review.

- fn_02984 CCashEmotionMgr::Unknown59D040: byte-identical
- fn_09351 UICashEmotionListChildWnd_Basic::Filter: byte-identical
- fn_09353 UICashEmotionListChildWnd_Basic::Slot15: byte-identical
- fn_09366 UICashEmotionListChildWnd_Purchase::Filter: byte-identical
- fn_09368 UICashEmotionListChildWnd_Purchase::Slot15: byte-identical
- fn_09380 UICashEmotionListChildWnd_Search::Filter: byte-identical
- fn_09383 UICashEmotionListChildWnd_Search::Slot15: byte-identical
- fn_09392 UICashEmotionListChildWnd_UnPurchased::Filter: byte-identical
- fn_09394 UICashEmotionListChildWnd_UnPurchased::Slot15: byte-identical

Merged automatically: every function is byte-identical to the original.
 2026-10-30 07:44:35 +00:00
ragnarok-clanker
869ba38ea0 Decompile 12 functions in Source/Contents/CashEmotionMgr.cpp, Source/UI/CashEmotion/UICashEmotionPack.h 
Batch #1989 by eAthena: 0 byte-identical, 12 confirmed by peer review.

- fn_09458 UICashEmotionPack_Purchase::`scalar deleting destructor': logic confirmed by peer review
- fn_09462 UICashEmotionPack_Purchase::Paint: logic confirmed by peer review
- fn_09463 UICashEmotionPack_Purchase::SendMsg: logic confirmed by peer review
- fn_09465 UICashEmotionPack_Search::Paint: logic confirmed by peer review
- fn_09466 UICashEmotionPack_Search_Normal::`scalar deleting destructor': logic confirmed by peer review
- fn_09467 UICashEmotionPack_Search_Normal::SendMsg: logic confirmed by peer review
- fn_09469 UICashEmotionPack_Search_UnPurchased::`scalar deleting destructor': logic confirmed by peer review
- fn_09470 UICashEmotionPack_Search_UnPurchased::SendMsg: logic confirmed by peer review
- fn_09475 UICashEmotionPack_Unpurchase::Slot26: logic confirmed by peer review
- fn_09476 UICashEmotionPack_Unpurchase::Slot25: logic confirmed by peer review
- fn_09477 UICashEmotionPack_Unpurchase::SetPressed: logic confirmed by peer review
- fn_09478 UICashEmotionPack_Unpurchase::SendMsg: logic confirmed by peer review

Peer-reviewed-by: ragnarok-clanker
Reviewed-by: ragnarok-clanker
 2026-10-29 08:58:56 +00:00
ragnarok-clanker
f464cd3f17 Decompile 41 functions in Source/Client/Input/InputCharset.cpp, Source/Client/Input/InputCharset.h, ... 
Batch #1607 by ragnarok-clanker: 0 byte-identical, 41 confirmed by peer review.

- fn_11718 DrawItemIconById: logic confirmed by peer review
- fn_11719 DrawItemSlotBackground: logic confirmed by peer review
- fn_11721 UICntWnd::DrawBorder: logic confirmed by peer review
- fn_11760 UIBank_NewWnd::Paint: logic confirmed by peer review
- fn_11761 UIChatRoomWnd::Paint: logic confirmed by peer review
- fn_11767 UIMerInfoWnd::Paint: logic confirmed by peer review
- fn_12085 UIWindow::DrawPanelBackground: logic confirmed by peer review
- fn_12086 UIWindow::DrawPanelBackgroundAt: logic confirmed by peer review
- fn_12088 UIWindow::DrawButtonBar: logic confirmed by peer review
- fn_12089 UIWindow::DrawButtonBarAt: logic confirmed by peer review
- fn_12098 UIWindow::DrawTitleBar: logic confirmed by peer review
- fn_12099 UIWindow::DrawTitleBarAt: logic confirmed by peer review
- fn_12120 UIWindow::LoadStyledBitmap: logic confirmed by peer review
- fn_12219 UIDisconnectedServerMsgWnd::Paint: logic confirmed by peer review
- fn_12233 UINoticeConfirmWnd::Paint: logic confirmed by peer review
- fn_12245 UIQuitWnd::Paint: logic confirmed by peer review
- fn_12246 UIRestartWnd::Paint: logic confirmed by peer review
- fn_12258 UIWaitWnd::Paint: logic confirmed by peer review
- fn_14470 CUIFrameWnd::RefreshSkinColors: logic confirmed by peer review
- fn_14471 CUIFrameWnd::Paint: logic confirmed by peer review
- fn_14472 CUIFrameWnd::SetSkinColors: logic confirmed by peer review
- fn_14635 CUIControl::LoadBitmapResource: logic confirmed by peer review
- fn_17781 InputCharset::Prefix: logic confirmed by peer review
- fn_17788 InputCharset::ServiceName: logic confirmed by peer review
- fn_17847 FadeOutMode: logic confirmed by peer review
- fn_18378 Resolve: logic confirmed by peer review
- fn_02111 RendererDX7Operations::SaveLogo: logic confirmed by peer review
- fn_09446 UICashEmotionPack::Paint: logic confirmed by peer review
- fn_09453 UICashEmotionPack::SetSaleBadge: logic confirmed by peer review
- fn_09483 UICashEmotionPiece::Paint: logic confirmed by peer review
- fn_45445 CSkinMgr::CSkinMgr: logic confirmed by peer review
- fn_09681 CSkinMgr::~CSkinMgr: logic confirmed by peer review
- fn_09683 CSkinMgr::Prepare: logic confirmed by peer review
- fn_09684 SkinPaletteColor: logic confirmed by peer review
- fn_09685 SkinPaletteChannels: logic confirmed by peer review
- fn_09686 CSkinMgr::Name: logic confirmed by peer review
- fn_09687 CSkinMgr::Prefix: logic confirmed by peer review
- fn_09688 CSkinMgr::Name: logic confirmed by peer review
- fn_09690 CSkinMgr::Selected: logic confirmed by peer review
- fn_10758 UIEditCtrl::DrawSelectionAt: logic confirmed by peer review
- fn_10759 UIEditCtrl::DrawSelection: logic confirmed by peer review

Reviewed-by: ragnarok-clanker
Adds to the build: Source/Contents/SkinMgr.cpp
 2026-10-28 19:13:07 +00:00
ragnarok-clanker
98c2dc3244 Decompile 3 functions in Source/Contents/CashEmotionMgr.cpp, Source/Contents/CashEmotionMgr.h, ... 
Batch #1438 by Yommy: 3 byte-identical, 0 confirmed by peer review.

- fn_09447 UICashEmotionPack::Slot26: byte-identical
- fn_09448 UICashEmotionPack::Slot25: byte-identical
- fn_09449 UICashEmotionPack::Slot27: byte-identical

Merged automatically: every function is byte-identical to the original.
 2026-10-28 12:52:30 +00:00